Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <c7296e7c-8920-4bd7-b2a8-c5dc6ffdee03@amd.com>
Date:   Thu, 7 Dec 2023 14:39:58 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] Input: i8042: Avoid probing if no keyboard and
 mouse are set in quirks
Content-Language: en-US
To:     Rahul Rameshbabu <rrameshbabu@nvidia.com>
Cc:     dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231206212140.7458-1-mario.limonciello@amd.com>
 <87il5bgfmp.fsf@nvidia.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <87il5bgfmp.fsf@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXJRQTFkRHNCM0xYZW1kRWhuaXFUVHNQTlJwa28wOXJBdGhwWE52N3lyQWM0?=
 =?utf-8?B?Y2JaRFBXRHl5SFBadXcycnhPT3VIZHhqdkRRZzltWWpqMDBXQ0hoQndYRCtC?=
 =?utf-8?B?RlVOQjEvZ2ZqU0N3OVcreWRIR1plRk9TWTJnYWFiUDV0TCtJVlhEN3lyZk13?=
 =?utf-8?B?MXRiejlmcmtQdElTSk5lUFBkVVlVdWpiNXdlUTFhbHNzbUcxNGhxQlZ3aS82?=
 =?utf-8?B?WjZnUUJmUlRia2MvbWhTYnNwTGdScDhmdE5Sci9IQ0lwRGxKd09kb0wrNjFp?=
 =?utf-8?B?Z0FoWk5VUTdDS20zbUFqaUcxMzBrMnVLd3VYNGloNUR6Z3QxRXFMY1c3clVm?=
 =?utf-8?B?eWk3bnI1TklLaUROcEcvK0dWZWxVL1Vnb1hDM0t6MkpyQ21RVlJpUFVCdVo0?=
 =?utf-8?B?VGRTOHhLL2F3RDY2YXFqaDJlWm1yU1RyQ3NzMDRBRGExU2UvNkhDMHEwdW1F?=
 =?utf-8?B?UXlCb0RoMlkvdmZ5a3Y5ZnF1azJHdlNTMjc0UkpvSjBnSVdMdEFsclBnZVlO?=
 =?utf-8?B?eVR3VnhZMXV6Q1JxK2tsMFVQc2F6cEhRendESjV0ZUlxR3FpSUtDTzU0VUF2?=
 =?utf-8?B?TVgrMFJBZDNaOHhZMVBBVTBVQUZlN0RSaVdPSDVRaGZtTTRzMDNtd3dtRjNI?=
 =?utf-8?B?VDc4ZDBWRi9Nd01iWS9TMURFeWJ6aDZsY2E5cXRtNkVKS3BqVEFpK2VURXNa?=
 =?utf-8?B?c2xibDJybHlEdnRHQVZ5bTJ1RmFKbzdYaTl6VEo4Q3FqMkFzSkFORSt0dlBD?=
 =?utf-8?B?YVZwRDRGOC9kc1lvNDZOdUpVTGQzdkUzSk9nZFhxZGQ3RW80TExOSWNFOWhS?=
 =?utf-8?B?VjBOTmZqNVJBc3lDNjdQdVZWM2lQdDFuSHJCcFJPQUJXaFlpZWt4N2x6Z05m?=
 =?utf-8?B?blBOQkR4MWdHT3lIWkZ0b1NZU1RERzJrWW9rSlpZbEsxVzBaZlJGVVYrVmls?=
 =?utf-8?B?c2VyeFlyeXczYkc5UGJDOWpzU2VHUVpPUHV2bkNaTEZHbFY5bGhoY3RkNFRr?=
 =?utf-8?B?c1lEcDFZTVFYd1hJazJ6OEdFbXU2SmF3NFZDUjRCYiswaDVodVFodS92MEgw?=
 =?utf-8?B?Y0VvcUdVRTRxbmNJcUVOcVE2YXpwQUxlVGNCcFhOajcvMVROaTlBR05YNi9F?=
 =?utf-8?B?amJ2T1NtdnI2a1VEUDhnRko1aVZKbTR2U1JwWkhrQThLbW9nVjl3K2haZHQ4?=
 =?utf-8?B?K1E3ZURleWhRWjBTV1ZWMnNPVTJPZUZaWnFqWENZRkc4Z2RnYUFwK3ZJbU5y?=
 =?utf-8?B?NFRxYnBpKzkyK01xeHFnV0RNdUZSKzdiWlFVakgxRWdsKzZ0TXRMbmJRNHJq?=
 =?utf-8?B?eGg5cElWY3pPVmN1cW16bXA5dVM3UWRTR0d6SXlleDRSWUVqaU9oK3grUzUx?=
 =?utf-8?B?NHd4WFN2a2srNXA1dDlzZ0laYkZGcXQyc3g3OFlkT09Bc3BBSnNtb205TjBq?=
 =?utf-8?B?Rk9wT1hQN3hzZXpQaDF2QVN0M2Y5VXd0VzZlSFNnbFFMZ0N2aHZYRTVRbktH?=
 =?utf-8?B?anZDcnJvQUNuRzZwaEhXTm53Sy9ONG5BQ2k3UGFRcDdhcUVRN0wzUTlncmEv?=
 =?utf-8?B?bFQxSDlaV01sK0NTSlNKcG4xbjEwM3prWkVBNHF1TjdkeURYdDVQcnoxV0Jo?=
 =?utf-8?B?ZkZneUFqNURMV0ltdDAyTFA5M2ZCUU9ncVE5eTB3SFB1TGt4akN4cHRHOVVD?=
 =?utf-8?B?MS9mQXUzRXlPVnpQbTJuaXR0YmhaRm01dytjMGpLV2M5Tk5wbGVvTElOVWVw?=
 =?utf-8?B?S3NMN2o4SGpwN2NRWjFLMms4RjkzMDlpZ3NEWUM3aDFqaXQvU1pzTDh6dVNq?=
 =?utf-8?B?Ym9RQno1eGxkd3RkUW94MVNOWFR4YTB1S3czQVVrb0E0NDNqbmFpaDB6R2Ni?=
 =?utf-8?B?a3JnS3FzME5FYUVkQXhFWWF2SlFtcDZDR1pMQjZ5Ui84UGx0Y1RMRUU0Rndw?=
 =?utf-8?B?a2MyRUtBRDBBODkyMHhiSjFqeHZ0bFNJTm1BbU5wS3hTSXZuRHgyaVV3OTJO?=
 =?utf-8?B?ajV1R0tybm9oQTNDT3pPSjVuRFF5cDdpZzVORDVJYXNnbGpTVFNueTBwU1lz?=
 =?utf-8?B?UEJXRjJKZFZNUCtPZlRlNUVSTzdpa1ZmM2V4QkIrU2prTzB6aWxyUjJYRXkr?=
 =?utf-8?Q?WHgtb8aWFFipTWQTk3E6D/yBw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 323791d4-a5b9-43cb-4e28-08dbf764af40
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 20:40:01.3797
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yAlJ/7pCOKLBG5KKI7exm9YSrMXqdHQ89xoJNamqPG0ItiIFmxnSxcTzXQGMzpk9U9opX6xRO81yAHunWfncuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8935
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 07 Dec 2023 12:41:31 -0800 (PST)

On 12/6/2023 15:55, Rahul Rameshbabu wrote:
> On Wed, 06 Dec, 2023 15:21:39 -0600 Mario Limonciello <mario.limonciello@amd.com> wrote:
>> Some laptops have an i8042 controller in the SOC, nothing mentioned in
>> ACPI PNP and nothing connected to the controller. Add the ability to
>> skip probing in this case.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
> 
> Thanks. I think this is a good choice for handling the issue you
> presented with the Framework 16.
> 
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>

Thanks!

Dmitry,

Are you OK with this?  The other direction I considered was to add a DMI 
BIOS year check and "only continue to probe" non PNP devices on systems 
older than 2023.

That could let you cut and run without needing to continue to add quirks 
like this but it could be riskier.