Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Thu, 7 Dec 2023 13:18:22 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Ira Weiny <ira.weiny@intel.com>, Robert Richter <rrichter@amd.com>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     Ira Weiny <ira.weiny@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fan Ni <nifan.cxl@gmail.com>, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] cxl/pci: Get rid of pointer arithmetic reading CDAT table
Message-ID: <6572369ea4080_4568a2945f@dwillia2-xfh.jf.intel.com.notmuch>
References: <20231116-fix-cdat-devm-free-v1-1-b148b40707d7@intel.com>
 <ZVfIaNhiSc-yQZo5@rric.localdomain>
 <ZVfJ6Fxidvw_gz7r@rric.localdomain>
 <656648433bd82_888fe294a6@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <656648433bd82_888fe294a6@iweiny-mobl.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D0HUA3OVo+yZY6i+xzZITTc4FWG3tIegrlM/2HbtrpQjHIqvBtO4ryxMpEcV?=
 =?us-ascii?Q?yakT0sDBwkRJB2RJ1zwG2WghLfnk5omwudFBtRPBJukYyu5H1Gy9cvvam9SP?=
 =?us-ascii?Q?5CxX06JE/dISxc/ItRmbxSeW+7r5p6OGFK9Ebdfbh9e7Z+Ee6GeRlP/hQ6Iw?=
 =?us-ascii?Q?6W+Teg9+uVeg5bYsKOjYmuCJrvd5pBwNao3Yn8X40oCkPszdmY1r4/aVS3fl?=
 =?us-ascii?Q?gEkNyJWty6RwCBXNCxQ30ziL4jj1uXaQIVhlWcIACKHfnLVPIHFYv3wCNREm?=
 =?us-ascii?Q?znSmvSMbzQ4Rg4BXoaC0+9h2X2cs5QV3semCWXUCs0g/MouUcuDkgPWB4Lzi?=
 =?us-ascii?Q?TCS7LF/0RQv/B2OTNBZpbkTFi+V2AflEQHo5rXH+Hu7dpEnxDtJ3Q0oB7g1U?=
 =?us-ascii?Q?3yswhcU+zgI0JMMw2ndl9UQVqhYyQ56SatWWliOFFn6QxerbZvEah3AN5pHI?=
 =?us-ascii?Q?tA3PuKRXrySuoEWBU+mTV2zb95QOMC4wjcewTOYpNMpt/646zvHxBBHkelo/?=
 =?us-ascii?Q?+O3D3ShcuaeYCbcBaks5WByD2NQ3UIC9sqG2m/4Gh0SxjLhuZ+/qmZwSgrCT?=
 =?us-ascii?Q?s7MW/yTb3jO1ZlCM3zeyb0Y0m6VqZGoR8rLXJzrbJYMyHrdVGP6RA03aFV9H?=
 =?us-ascii?Q?wroXGe1Yryc6paogGVlBwkZSHGtWhbR5Rk8DkuX76j8moS52h8qcOzlGBj/s?=
 =?us-ascii?Q?+BgDDnrhClFwWCgq8fVuk1nr3MQ42be3dRfKE27nazfhCECLfRUPodGgTVsr?=
 =?us-ascii?Q?FYM6WOMhOnlPPamZGv62tkb0k8uYd46mrA28haNwaWK8wgkkJEv+CfqrwnYF?=
 =?us-ascii?Q?TvA58FUM3Mkv+YPEmqxMo+ZJbushgGio7q6ZLa8th19gPEvN0Qv88aMond4c?=
 =?us-ascii?Q?YP59FbFxEGY15d3S+U0M+GrwsLpyKG544+YDte1vnxqAgw74RDrFb+B+RRrE?=
 =?us-ascii?Q?itdsgVrnPlh6p2A7mN5nrs/dcC+WDa3eVt2qnHBCNnjY4XuaIFWz3BHwC01O?=
 =?us-ascii?Q?htV7FUmXD3x8BuPslnn+HHfkYpyNl7unlZKf/Jam2vEzFhKtCvweYsxoPjNr?=
 =?us-ascii?Q?jhMvhzuGaCyF0FaAXNWtJdXOO6a51ppSiqyNN8X076qF1uxm1jAtW4IZFEMl?=
 =?us-ascii?Q?DaMz6VJjcMl7Rn8vQuBw1MvLecW+kninUBU42RzhVO/CjSSW4mb1Ec9VLWM3?=
 =?us-ascii?Q?z7GhRh3BPYIdG8ZksuyJl5pECUJJdoaImSt0n3i0kKIF67Pm6wC9V/YbSIlX?=
 =?us-ascii?Q?RjP9CjPUAD//Loh/1mwVPpHuLP9fzqFl3zoGADt3Kkc9A/0BxRsSWXJcfCna?=
 =?us-ascii?Q?JY5vabYpc4INRgm/2F97neL3gLPc++Tgvwfj3m4JRZsc4E/0PVoOLfW8Bp5i?=
 =?us-ascii?Q?kl2ZJYc/1TzBE0lURT3k/HaGv4YzKnXDA7TQ724bYkS7NNFcQeKKvotdgcNW?=
 =?us-ascii?Q?0FlCzBeze7I+lXC2qccEYpH0V/NSMOEZc3YijnBAJAmtQIel7nJkbabeGPYN?=
 =?us-ascii?Q?x6JyTQtqgmHsCQ9DsLeyGJpK7vh4s1CZMrHoZasMg6b5FZl1xedFjJqKmonE?=
 =?us-ascii?Q?OGaJ9qsAqRqXGdJaBj/4pVfUaFiQj7OucAXAHIiZoKu4uihqtwzfWxT83wjg?=
 =?us-ascii?Q?cQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 67ffa599-688b-4a84-b59d-08dbf76a0cb9
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 21:18:25.6831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fcluFKQBhROcG0R8fSDh0PwcOESfHCYAjSWfrHXsyf9S5D/WflZqttANoBmCUlx+zQqbzeJPd3xjDYBvIRfLCvyGXhSOcaPaPoemOIRsNuI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4661
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 07 Dec 2023 13:18:46 -0800 (PST)

Ira Weiny wrote:
> Robert Richter wrote:
[..]
> > -	cdat_table = cdat_buf + sizeof(__le32);
> > -	if (cdat_checksum(cdat_table, cdat_length))
> > +	if (cdat_checksum(doe->table, length))
> >  		goto err;
> >  
> > -	port->cdat.table = cdat_table;
> > -	port->cdat.length = cdat_length;
> > -	return;
> > +	port->cdat.table = doe->table;
> 
> As an aside: the type of port->cdat may need to change at some point too.

I did not understand this comment relative to what you expect to see in
the next posting, but maybe Robert will when he respins this patch.