Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Thu, 7 Dec 2023 17:27:52 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] ring-buffer: Add offset of events in dump on mismatch
Message-ID: <20231207172752.01ec634c@gandalf.local.home>
In-Reply-To: <866d40a8-4e0c-465c-ab8c-b5d864c1a668@efficios.com>
References: <20231207171613.0592087d@gandalf.local.home>
        <866d40a8-4e0c-465c-ab8c-b5d864c1a668@efficios.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 7 Dec 2023 17:19:24 -0500
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> On 2023-12-07 17:16, Steven Rostedt wrote:
> 
> [...]
> 
> > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> > index 8d2a4f00eca9..b10deb8a5647 100644
> > --- a/kernel/trace/ring_buffer.c
> > +++ b/kernel/trace/ring_buffer.c
> > @@ -3424,23 +3424,27 @@ static void dump_buffer_page(struct buffer_data_page *bpage,
> >   		case RINGBUF_TYPE_TIME_EXTEND:
> >   			delta = rb_event_time_stamp(event);
> >   			ts += delta;
> > -			pr_warn("  [%lld] delta:%lld TIME EXTEND\n", ts, delta);
> > +			pr_warn(" %x: [%lld] delta:%lld TIME EXTEND\n",  
> 
> Please prefix hex values with "0x", as in:
> 
> pr_warn(" 0x%x: [%lld] delta:%lld TIME EXTEND\n"
> 
> Otherwise it can be confusing.
> 

Heh, sure. I'm so use to looking at hex for the ring buffer offsets, that I
seldom add the 0x in my debug anymore. But as this is permanent, and not
just a one off print, I'll make the update and post a v2.

Thanks,

-- Steve