Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <92e5cc01-e8b3-b6d2-e884-3d6bd001f0d0@intel.com>
Date:   Thu, 7 Dec 2023 15:25:47 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v4 iwl-next] i40e: Use correct buffer size in
 i40e_dbg_command_read
Content-Language: en-US
To:     Alexander Lobakin <aleksander.lobakin@intel.com>,
        Kunwu Chan <chentao@kylinos.cn>
CC:     <jesse.brandeburg@intel.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <jeffrey.t.kirsher@intel.com>, <shannon.nelson@amd.com>,
        <kunwu.chan@hotmail.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Simon Horman <horms@kernel.org>
References: <20231205095844.2532859-1-chentao@kylinos.cn>
 <2a0f3c2a-71fe-4c79-8827-e53088bf3761@intel.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <2a0f3c2a-71fe-4c79-8827-e53088bf3761@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU5vWDVXdmVFUzd4a3dJUUxrZUpOVktldWVyaEhZOTI1Q0FyTENBQ3dVbjg2?=
 =?utf-8?B?bnpBclVwVXVMQ2hvOUUxcWpvbW5TeitJSU82RU9ZUFJnNG1qYTUvUWJHdkNU?=
 =?utf-8?B?clBMazdsaVZIWlY3WFpCOXFOcHpCOXpYODRRc3JJTEFRNXhwSGEzZkxKVTVY?=
 =?utf-8?B?L2JwOXcwdjRMSXpka0NGT0hJbWZ0NGhBVDBxRnVZMWhpTWJTaFlIaVlmWVRW?=
 =?utf-8?B?aUpiSWZFQ041UGhXc0w3d0FKQUlVMEoxS1RHOElIT3d2TU9pZ2lmYjNzV2pq?=
 =?utf-8?B?YUVWdnFONHFteDhtWFRDdEI3SmlJRElGbFVWcGNhZEl1Y0xyNWU4aHQybVdI?=
 =?utf-8?B?ZVB5SW05Y0V3Q3V0eHM5M0d2V0FXK2wzWGhzYStHMFJUdW14TGZ1dTFiY1J0?=
 =?utf-8?B?R1JaSEoyd2t0WDFXbUcxNGVaU0tKTk9GWDVRaTRFcG5pOUNReEdJOGJrMDNi?=
 =?utf-8?B?OGk3NkwyL1NJczZva2JCNFdvQ3hGMHRTb1gyTjNNZDZRQitMQ3V2eFhPaitF?=
 =?utf-8?B?Rk1MRHo0RTNtNHVZNEw5RExQb3FzY0NQcGJkU082UDBvaGVHTHRZSElHaFpD?=
 =?utf-8?B?Z1B2bWlPam5EeW5jYXdKTklxWGZRMGs3RHA3YVdOaHRHS0R3OUMra05ZTjBD?=
 =?utf-8?B?Mkl6MjQzT2RMZGFrWDRxSGlPeTdLY0QyR1JGZzZzNGdYRnRsUmphL21hOWQv?=
 =?utf-8?B?bTV3QUNXb280VlpYVXI0eTd4K1k3RVhOT0Q3ZnlHZC9pNmJJb0p4Qms0MFh6?=
 =?utf-8?B?b1YyMDZBUDAxZ3dZa0pmY3VnVEcwUTJLTmh2TjFXeXAvOW5wSVhLYU5DOTJY?=
 =?utf-8?B?Y3hsR1FuV0UvSjBsaGNIRnMyTU9jRTlpaVlaMXpYeE1NdlRuK3B3VTFPY1Rl?=
 =?utf-8?B?UEVud0orMmFobzBqQVlseHgxczh2ODFqWlFLaUVEaHczajRTQTlOUnhvMkJM?=
 =?utf-8?B?UG96MWdmNnRneUZQeG9hS0hPemRUNHZwdHJOeld4UERrRGN6a2hrZTlUa25h?=
 =?utf-8?B?cTEzTVA3ZEZCeHlTVGlpWk5zSm5sZVVPNHFTS1pjdjBkTHhBQnZ3Ty81ZEps?=
 =?utf-8?B?dEVVR2k3ZkRqTnI4ZTd0Z2ZLdDRaTGJ3OHg1bkpCNzR0c1poR2xaUjlvM1Vm?=
 =?utf-8?B?M1hLMTFoZVJUTlhMSHBKWlRJSktEeXJ2aTMxbTNwdHlKN1F4WnUzSDAySUZn?=
 =?utf-8?B?Y0xhb1M0R0FoWjF5UmtnRUJ1SWFqVTN0bGhpb3E0eU41SG1PTW42L2xGaE5H?=
 =?utf-8?B?R0h0Rm5KeERtZVJKWnoxeE9tU2UzV1hzbnV0Y09DdU1NbGV6UWRkVWsxbWIy?=
 =?utf-8?B?Q2diT0lDcnhuYWdhYVJYeTdRMWEzVjc2UlQ5cDArK1RNNHNWVFJXVG5OM3pX?=
 =?utf-8?B?eWtjVGo4eG56NDZjWjgwSjZZdXBKNmJMMHlzREZtU0RYSHphVFlYSmI4YWJG?=
 =?utf-8?B?VmJ4blJWRmNrYURLdm5ubWM3UWZ1Y3pPN0FOUjlaQi9pcGFsU3FUaElNd3lT?=
 =?utf-8?B?ci9rUWUyajR0VkhuSUJPQThDZ3hTMFFzNlUwdlhDU2xyTDZtb0UxQWJvYjc4?=
 =?utf-8?B?YTRiNVk3TXFWRzE0Y0xBMWpuR3VTb28vOXh0TlZDbkt5RTRzTWVUbVdQVVB0?=
 =?utf-8?B?WndPaU13a1pCa1VwNzU4N1I3NngyQ09yeURrazd5NU0wRFdadmZKOVArYWFD?=
 =?utf-8?B?Uys4QlV0dFRiQVlqZ0YyenNpaVZJL3YyZW5RTUlhQ25vSGJlNXlKWU5zTzVT?=
 =?utf-8?B?aU51NWRDT2w5UVp3WTUwY3F0Rk1sSGlIckFiTHMwd0tSaDc4MDgzVVdMOXpG?=
 =?utf-8?B?S3BPL3BNUlZrcW9xalY3OUU0N0Irei93cVY2UkJsckxrRmJCU25WNmtjdjU5?=
 =?utf-8?B?c3hzVDIycHI3Vng1SVhwdXFhWEZMZkNlRWV3SlZKbm9iN2pYQ1hzL3AyTndN?=
 =?utf-8?B?OC94cnAwV1NIcHJoWVJReEV2UGlWQzd0eE54QlAyNXhXWTJvbDNaV0ZXM0ZD?=
 =?utf-8?B?V0thQUk2c3liRVRTOEFaTWx6RndvWWsrQ3BENnFLRkNDa3VJNE9kcHhKMFlH?=
 =?utf-8?B?cEdxNitFU3FCZ2FCK0R3ODAzV0RYaitRelViVG1Xek8ydk95OG9xWmo1R3Fz?=
 =?utf-8?B?eVd4U0d6Z0ZvM2w1WnBEUDd2S1lubEFNN2NUTmFWNzNKTlVURGJnaSszOFo4?=
 =?utf-8?B?OEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 23770800-eaee-476d-bca1-08dbf77bda58
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6435.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 23:25:52.1136
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cpgJh8FfN7jcxgfirBQmhPWbEdROBODr+ICXM4JSBpld49ZutCdXQosb1byQYqRMvxFCkZBS2kxjj3EJHllxgFapBoHeT0Cok8j3mxVHwUs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5826
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 07 Dec 2023 15:26:15 -0800 (PST)


On 12/6/2023 4:40 AM, Alexander Lobakin wrote:
> From: Kunwu Chan <chentao@kylinos.cn>
> Date: Tue, 5 Dec 2023 17:58:44 +0800
> 
>> The size of "i40e_dbg_command_buf" is 256, the size of "name"
>> depends on "IFNAMSIZ", plus a null character and format size,
>> the total size is more than 256.
>>
>> Improve readability and maintainability by replacing a hardcoded string
>> allocation and formatting by the use of the kasprintf() helper.
>>
>> Fixes: 02e9c290814c ("i40e: debugfs interface")
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>> Suggested-by: Simon Horman <horms@kernel.org>
>> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> 
> Your Signed-off-by must be the last tag in the block.
> Perhaps the maintainer could fix it when taking, so that you wouldn't
> need to send a new version only due to that.

You missed Intel Wired LAN (intel-wired-lan@lists.osuosl.org) on this, 
though the other versions did have it. Could you fix this up and be sure 
to include Intel Wired LAN?

Thanks,
Tony

>> ---
>> v2
>>     - Update the size calculation with IFNAMSIZ and sizeof(i40e_dbg_command_buf)
>> v3
>>     - Use kasprintf to improve readability and maintainability
>> v4
>>     - Fix memory leak in error path