Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 7 Dec 2023 19:05:18 -0500
From:   Gregory Price <gregory.price@memverge.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
        jgroves@micron.com, ravis.opensrc@micron.com,
        sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
        linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-api@vger.kernel.org, Linux-Arch <linux-arch@vger.kernel.org>,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, Michal Hocko <mhocko@kernel.org>,
        Tejun Heo <tj@kernel.org>, ying.huang@intel.com,
        Jonathan Corbet <corbet@lwn.net>, rakie.kim@sk.com,
        hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
        Peter Zijlstra <peterz@infradead.org>,
        Frank van der Linden <fvdl@google.com>
Subject: Re: [RFC PATCH 07/11] mm/mempolicy: add userland mempolicy arg
 structure
Message-ID: <ZXJdvmZCjRLDV50L@memverge.com>
References: <20231207002759.51418-1-gregory.price@memverge.com>
 <20231207002759.51418-8-gregory.price@memverge.com>
 <67fab0f1-e326-4ad8-9def-4d2bd5489b33@app.fastmail.com>
 <ZXHdhVeel1dOxlYJ@memverge.com>
 <cddbf290-021a-49d5-8729-e98cb099ff67@app.fastmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cddbf290-021a-49d5-8729-e98cb099ff67@app.fastmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gmadOaYVVt8S8Kh8qzD4hHjBpSnZmU1T3TxQAVgwNumpF74wLh2y7urvwq9b?=
 =?us-ascii?Q?F6+TMt8Jo2mOf1yGeoUhKIUmQgO+rLeM8c329Ekjzq/xa1G67oluIzy5jzJU?=
 =?us-ascii?Q?mkMavlZ7drbAFcBmbdrKGRGYDiPz5JeJ65S5eQ1RlhvKwcqOVMURenAkSI/D?=
 =?us-ascii?Q?hZ1ZQaw+3r7sknWVTGI1VPYNVNb5ZhdBZxrHVEA62R25aHcbMq59uZWA0qLP?=
 =?us-ascii?Q?kA22i8Hjcf4vgfWDkL9MFiGYFyQEbtmGtuEaUeeihIj/YkkUxWUqabPlipqE?=
 =?us-ascii?Q?Xp/u4KF4kJrCIfNRerXIGt2diyTmQOqrCoMImCrR7mkQk7GP6o1OrFgp3yT6?=
 =?us-ascii?Q?ufJNxB0+h9z0d3MfzZn50NPo+4a6PpHFeewN3MfbSREAuOnjqy7jmtvSHSYH?=
 =?us-ascii?Q?sryrIVQGw7y/6djFJykc3FcOwG/3wfNrftNhVrvLC93zKid4mi2h/C3liYI5?=
 =?us-ascii?Q?WUNN0JUO3CW7e47ZTPox8/73bg1wrsHpMGGJKYv9+jIZy9R66EkJc89h6+9W?=
 =?us-ascii?Q?Qlwq+d1sdPP0EugG8Yqpr8Mtr2r1jMhCoCobmmVMF2wp2LjqatRZZrih3cEa?=
 =?us-ascii?Q?KCexQ7eAaxmgDxAMeSLF7g8u8QGo8xYD4/dLSez0vuXDMDOXVOsBT46pI/SY?=
 =?us-ascii?Q?G24ZAkcEn9uxdbvSjKZLp0ADfsaQ98n0aeRfd9x2TJe9JK5Hy27JqhudcvvJ?=
 =?us-ascii?Q?XSwEMBxz0lgSCblZWFgVfAg0u09nuUX8OQdQNUAYlon3lKBSqr2KQMS+P9YH?=
 =?us-ascii?Q?RVM3beby354Ud1BZQIubZK7oiG2CofT9u+a0KpeLwASediyN6oEr0evIVhYq?=
 =?us-ascii?Q?MV0XQCCzqqrZr7d7DDN2B5YQa1Oj1FGo8oPB3NWBqwf85P8RZ4WUUixwYCrV?=
 =?us-ascii?Q?/JC0m74AJfmbytQdneDnPZbYnGqof5KJKdaJGn0lpd57nuy4NG3172xi7IgZ?=
 =?us-ascii?Q?qO00IdioIR0SXFnKrPVyk2T7on8U64ESoAH+wCF4kamAiYMb5PhoprQVbO7q?=
 =?us-ascii?Q?dnovyGlz7Fcd3rB8byVTJIsuObk+9W+7rolgpSF+xYA12ZkqrBHM0Kd5jXlZ?=
 =?us-ascii?Q?nhm80WDKXjtt872iMxNRUy+q9WUnwKx9vncijFnTMca2G/RJJBDH3Vy5QlBH?=
 =?us-ascii?Q?Uqzmp2IX0CvHaTn0p5ER9v+Vb4jwDAMIxq3IZvICJ7BeNtfsXxqnr/gXlPkf?=
 =?us-ascii?Q?FF2V0oD5lUI1/VDf0Y3FExEUghf7I2RtAK/LPBxHgh15aryQrMnMtKNYlvxn?=
 =?us-ascii?Q?hl0NZ6Znyb0Ix9LtzFPeQ5hjwR6c5LKHcuYDb4K5ZgbEStvbGkUnMS5S3Ee6?=
 =?us-ascii?Q?KjQZRp5iHTfuOqVCFNQUkON02tyoxphLwOzZ6R07uy/iMAS499iwxWTHdEeJ?=
 =?us-ascii?Q?CB/qPcESU6SulRHQr2M4yDWZ9kKXDaIje6eQCAqPXanqwsJy/cvSGdXEW/VC?=
 =?us-ascii?Q?evzsURoDj871TsyEQzynkVbEWFr5K9cZFMc3ALu8t4lVuf91E0mRWCC3Yapa?=
 =?us-ascii?Q?5IKn6wH+fLpd5wyqPd9KrjqQEynFXSrWuQrOnFIP8oSlpn6RYyxtnOpD4bRm?=
 =?us-ascii?Q?bTh96czPlcLNMS8i6rpbO3d13OT5Qg1BMWHUoOUT5sU01u1YPg3oswntAxBv?=
 =?us-ascii?Q?kw=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f415cc7-0824-4c7c-9cd7-08dbf781604b
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 00:05:24.3987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zvakIcKHlXidbGI3qAlGm/pX23tawRr3opOxMggkhmlLw/yNrNtV/BYCrB5AkRO6XebWAezWBMpVSFa7ydUqVDQAGl8MS1F1Gq6FLSuyRAo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR17MB6371
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 07 Dec 2023 16:06:08 -0800 (PST)

On Thu, Dec 07, 2023 at 04:43:03PM +0100, Arnd Bergmann wrote:
> On Thu, Dec 7, 2023, at 15:58, Gregory Price wrote:
> > On Thu, Dec 07, 2023 at 08:13:22AM +0100, Arnd Bergmann wrote:
> >> On Thu, Dec 7, 2023, at 01:27, Gregory Price wrote:
> >> 
> >> Aside from this, you should avoid holes in the data structure.
> >> On 64-bit architectures, the layout above has holes after
> >> policy_node and after addr_node.
> >> 
> >>       Arnd
> >
> > doh, clearly i didn't stop to think about alignment. Good eye.
> > I'll redo this with __u/s members and fix the holes.
> >
> > Didn't stop to think about compat pointers.  I don't think the
> > u64_to_user_ptr pattern is offensive, so i'll make that change.
> > At least I don't see what the other options are beyond compat.
> 
> Ok, sounds good.
> 
> I see you already call wrappers for compat mode to convert
> iovec and nodemask layouts for the indirect pointers, and they
> look correct. If you wanted to do handle the compat syscalls
> using the same entry point, you could add the same kind of
> helper to copy the mempolicy args from user space with an
> optional conversion, but not having to do this is clearly
> easier.
> 
>      Arnd

I don't know that either is easier, it's basically just what annoying
way do you want to handle this annoying problem.  I'll poke at it
and decide which one I hate less.

One thing i didn't really think about, probably the iovec/len
fields should just be args for mbind2, rather than embedded in
mpol_args - since mpol_args is supposed to describe the mpol
while the iovec/len describes what it applies to.

Simplifies the mpol_args structure a bit. Doesn't change the handling
at all. (bit of a rubber ducky comment here)

As always, I appreciate the input

~Gregory