Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2023387rdb; Thu, 7 Dec 2023 16:17:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFP8ZSOl3M0NgHZNQnaL7sntrqkUswtC/d+hM2y8bWL9GJurvNaCB7onA/v28RgspoY7pdN X-Received: by 2002:a05:6358:7e47:b0:170:5f9:9cd9 with SMTP id p7-20020a0563587e4700b0017005f99cd9mr4479815rwm.2.1701994633105; Thu, 07 Dec 2023 16:17:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701994633; cv=none; d=google.com; s=arc-20160816; b=tSm0MwhS70mi2c5ISbxijGFhH5R+iCRRpspnQHVJCP7Ra/ymeCwfWSNyf8T7nCUfw2 eSzPT+66Ubjl83mefU4fAPD9xxeNAtu54yiR2zHYfQACcTho9Dwlv9LC7rVp5nvQmKhH GwaBxUR1BYySnax4rqxgomUw3HlVQ7b67b/iBXw2hEIGg7nA8wDLOhvu0TnpWZduLAm2 ev0BncIde60tevO05vybsr25GfiTzmx0C6KciNftSX/d88ZG+7kO2SyxfK0rKakj0tN+ H3qvtvYZTAJKmEoh/t2pQD06gWVKcuHXyOEVPS3noFCIkHG7Vwo4RJfXJ8+LfpnyxnVi EGvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VDBtxhHmRb9xUvMy+TwyAcV6s+hWcrLfWnhfzgBeMmA=; fh=Zewmf3wThiipMhDjR96yol5QxF5bGjQ0muN6YDM9mM0=; b=aTMKCLMI4+5pLPiD7dpxk0foKTV2WNXYzZYb6RTJfuYeWmvRMGNn4Oc027rtUvMixe 1hdvBtUhYmGsDFxTYBOpIkYTgKOf3+etpObtl3zzXplr2ANpfT1XpyzKBwOm1Hgx/u2I KlwvlBCmFEqN/k6F56I+w1uDqK982EJRRj16GUNu6YOrNxjpemb0teCPirBWWjcNKeYQ Tf0V7IzxctfoykA30nH09FDrwZRyWXo+tPGcEaYvc1xkL3FqnraZLDRxrHYCpIptlUSa JqbdFoFNgAmkN3QhchAiJkx6GLcOsizGJm5sx13tT0laNBTYFAGDWU1axriTlFgFJGMA swcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Rf6BmGxX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id u2-20020a63df02000000b005be03f0da7csi531824pgg.61.2023.12.07.16.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 16:17:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Rf6BmGxX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0FEE88069F19; Thu, 7 Dec 2023 16:15:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444154AbjLHAP0 (ORCPT + 99 others); Thu, 7 Dec 2023 19:15:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232621AbjLHAPV (ORCPT ); Thu, 7 Dec 2023 19:15:21 -0500 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C1B71713 for ; Thu, 7 Dec 2023 16:15:27 -0800 (PST) Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-7b70db00e64so7050139f.2 for ; Thu, 07 Dec 2023 16:15:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701994527; x=1702599327; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VDBtxhHmRb9xUvMy+TwyAcV6s+hWcrLfWnhfzgBeMmA=; b=Rf6BmGxXmVlBpa/MZVcW3uzUzHhpOU6/SkHHBI9ThduSIB+etFo3ePYODmF1U8nGA/ ma00S1zylH3VRvnM8PdSVyRZ1PCSBguNIlX9Q+4tPypAXwaJfyekWsgDpFVczDm8D4UU S/CeGJ1hK6U3hs1mt64IYbkXFYFw/OKDNzqWzaMjIjqu4ENSdPhi9ogT+1fxiZ2/kdBc tI0XYG9TDWuT0PhXDDVslvm2On7cXeTemjmkQPI3+VMF8UnSPEu4eCck2zRfy2htPLW4 ufoPui3PbrvhBAldjdSM/6PByUm1kYSDjqMUtBh+ADr/kYVY1GwJwewJd6d92A9wLQaO jPxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701994527; x=1702599327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VDBtxhHmRb9xUvMy+TwyAcV6s+hWcrLfWnhfzgBeMmA=; b=B3K6Rlw9dp0ngHwhdehi8/JA7mCHuzA32YKObdSn7QRy/Y4mqKSMcQ5WnaIRcSGQfi HEKjMbis+8aAw3RoABlRmGrd7H9UlU3sTLjC69O95OF/cvlwOBAe1OuZ+i9YDiw+o1QD DzrH7iisDhLqjeQPg1zAlerfbs8/SKI60a5d9H5b/Rdff46ZwsdDOtBQZwzlLUnBldrA kM7f8swKsC8o0I6tFOM04H7xhNK9vUc9fhumMYmQ51G3AdqyTuisriofa2EZvBTqsNl8 EZnX02wWgkheosOsKkxuJNX5ils5wbvhTKlzf/ZmMhj8f80vCShAmBkzWhs0xSbENCPK NiKw== X-Gm-Message-State: AOJu0YwViGapH30+liQ0KH+H0stW5Kt0p3dTOCdlKu9dDYP1dodf5CXK IBgZ2CZlk9F2LAppGrmYQtE= X-Received: by 2002:a5d:93d1:0:b0:7b3:d91a:4936 with SMTP id j17-20020a5d93d1000000b007b3d91a4936mr3961806ioo.9.1701994526962; Thu, 07 Dec 2023 16:15:26 -0800 (PST) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id z18-20020a056638241200b004664a0a7f2csm184652jat.177.2023.12.07.16.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 16:15:26 -0800 (PST) From: Jim Cromie To: lb@semihalf.com, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, bleung@google.com, contact@emersion.fr, daniel@ffwll.ch, dianders@chromium.org, groeck@google.com, jbaron@akamai.com, jim.cromie@gmail.com, john.ogness@linutronix.de, keescook@chromium.org, pmladek@suse.com, ppaalanen@gmail.com, rostedt@goodmis.org, seanpaul@chromium.org, sergey.senozhatsky@gmail.com, upstream@semihalf.com, vincent.whitchurch@axis.com, yanivt@google.com, gregkh@linuxfoundation.org Subject: [re: PATCH v2 00/15 - 03/11] dyndbg: disambiguate quoting in a debug msg Date: Thu, 7 Dec 2023 17:15:06 -0700 Message-ID: <674f65e71c5c3e874b6b72b6f9d8cdd7a091b6d0.1701993656.git.jim.cromie@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 07 Dec 2023 16:15:43 -0800 (PST) When debugging a query parsing error, the debug message wraps the query in escaped-double-quotes. This is confusing when mixed with any quoted args where quotes are stripped by the shell. So this replaces the \"%s\" with <%s> in the format string, allowing a user to see how the shell strips quotes: lx]# echo module "foo" format ,_ -f > /proc/dynamic_debug/control [ 716.037430] dyndbg: read 26 bytes from userspace [ 716.037966] dyndbg: query 0: on module: <*> Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index fc94f09b20db..bde96ad867c6 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -955,7 +955,7 @@ static int ddebug_exec_queries(char *query, const char *modname) if (!query || !*query || *query == '#') continue; - vpr_info("query %d: \"%s\" mod:%s\n", i, query, modname ?: "*"); + vpr_info("query %d: <%s> on module: <%s>\n", i, query, modname ?: "*"); rc = ddebug_exec_query(query, modname); if (rc < 0) { -- 2.43.0