Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <2e6b0d17-4731-4c92-ab0d-6f01d1069963@intel.com>
Date:   Fri, 8 Dec 2023 09:41:45 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 09/39] mm/huge_memory: page_add_file_rmap() ->
 folio_add_file_rmap_pmd()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Hugh Dickins <hughd@google.com>,
        Ryan Roberts <ryan.roberts@arm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        Peter Xu <peterx@redhat.com>
References: <20231204142146.91437-1-david@redhat.com>
 <20231204142146.91437-10-david@redhat.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20231204142146.91437-10-david@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TytTYXVWcEtNSjVYZnlpbkt2UzlJUmpsMUF3eVp6cGcrK0VGSU94Y0d3M1p6?=
 =?utf-8?B?VmJodGd3MVd4cWh1WURSZ3VDT1Y2NHhQRXZmWkNlbStXandjMmgxMm40SEZ4?=
 =?utf-8?B?d3NnelpGUFA0NmJNaXRIcUdsNzBFQjl6Tkwzc3UxYVJZRU1YSVVLYW5VbmFT?=
 =?utf-8?B?dkUwRG9talhRZEVPdy91elgvc3NCTHZmSE5BUDVTN1A1UnlVSWRrZm9KMWZp?=
 =?utf-8?B?SWVYWmFBU0twK29ONnAyOGtObFFBNmQ1TlAvZmpaeFhya0taeFFmSlVBMmRO?=
 =?utf-8?B?OXZGcUdDSldKZnJNYUJma2Z5bWpvd1Fhd0Y3Ky9lTVdmNFN5a2UyZzZ2dEZs?=
 =?utf-8?B?azZieGZLQVVta2I3L2ZJMUVMQ2tIQXBoeCtpMDNzeGUzTldNcmtSNE81R0ZP?=
 =?utf-8?B?TTFtSk8wSFJQNENGQXkxakpTV29RZ3dsRm5pa2hCdVU4Vzc2SmNQM3RmK01G?=
 =?utf-8?B?bTJFZGpxZVdQSjFlTklxcGdOZzdnQzd5Y3ZpY243aythcTlHVUNGNnU4RzJ2?=
 =?utf-8?B?UmVCOVlRNHBrS1I0OVFkbStFVGJKWDIwTnFKeC9zbmRUcFFQWG9MSGg4Ri9E?=
 =?utf-8?B?Z0t4WURkSkRSK2VMOU9hUmErcnVkREkrTFdnQXROMmt6ZGJzV2pQMi9Wcnk1?=
 =?utf-8?B?c0dBVWEvMjd4NTErZi92N2t6T2pYOTdnMDBaRDJ6cTE5ZHU1b0s1dUl0anBq?=
 =?utf-8?B?REdCaWFBVUlIS0hJNVg2cTNkditFblllUWtjZkJYaForRmVHbXVOSXlnM1p1?=
 =?utf-8?B?emlXOXBmTmludjRXR0V2aC96dVM4bDVMZjBZbFEwTGpmc1dkMnd6NjNzYlhV?=
 =?utf-8?B?YjgxanFMdXNxd21TcWtsZzhOODMvSTFuQTJwM2VXa2JHM3Z1NzhJUEVzN2xw?=
 =?utf-8?B?UkJXY09FcW1oN2dDdWx5NVo0eDF2bkM4ODJmQVZkN2oxdWhDY2NwOEFTRTJZ?=
 =?utf-8?B?NHNIRWR3eTFPSmxQWnpiYUU0dkI0K1pBcTRGRm1mYnNTenhWemIrL280bTRv?=
 =?utf-8?B?N05lbkVJbnpZMjNkNmFHdThBc1dHakRaWEV6azQrRU1FazhZOGoyMkcyeU56?=
 =?utf-8?B?QnMrNHpvSHBmRXExOW51YlNBS1JWb0Z0SGJ5dFJuazNqeTVCUE83enpnYWp1?=
 =?utf-8?B?bEhzV09XLy9KY1o4aGwveEk5U2k1VU41V0lyVFRkVHVUaDA0SDdRdWNYMjFz?=
 =?utf-8?B?ZVRqWTRnTGtHUGdxMUhRMU9iYkttc0xoWmxSR3cvYUIxeW5iQmMyU1l0UGw1?=
 =?utf-8?B?V0VDRDRpNkpyUWVQelAxYTJhdTFWSnFCNUNEWFdnbko3eXZiOGRwRWN4dzdZ?=
 =?utf-8?B?N3NIcldUSXk1RTFOZUFLRHd4b3lsK0NPM3gycXozOEttY3RJSnlDU1RmNGgw?=
 =?utf-8?B?ei9mSXhGZzNBUC9QNjZTZis0bTF4Mm4zUUkwQ3k2VCtNcGlqVTc1cDZYZERl?=
 =?utf-8?B?V2pSOStwRVVHS3hqdzFOZGp3TlJ2eFZCdkRjaThFMTErbzNPSlJRcWpxMDJv?=
 =?utf-8?B?dEpXR05sYWdFQmthcmxpNlZFZEtGNTRTUS9vcDdSbzNzLzhFenpjenoxd1k3?=
 =?utf-8?B?clE3OWtRRlV6UVd3R0VRQys5Y2xQcmRkdExvS25Gbm5ON0lCMDF2R2lDeStZ?=
 =?utf-8?B?anpTNWFuUWlETC9QL3BXeFRLalB3SlRzajdTRW93aVNoaUFjT2dVL205U2gy?=
 =?utf-8?B?MlFmV2VJR3RJTSszYzdpdGRYOUN5L0R3Kyt1WWlEbUFRM2ZaZEp0WENrWDBR?=
 =?utf-8?B?MFNIWUZSREtEelVwaUpHRVJzT3JuQlN1a3pCbU50dWkyNExFcjlpRUs4K25H?=
 =?utf-8?B?UFNiVmJDcU5qZGMyN2JKMTNaTU9jY2YrR2hrK1lhSHpaaGdmRWsvNUhaWEEv?=
 =?utf-8?B?ZSt5Nk01bFhURWJHYlVGQTM3bmNSYnNEbjU0MFJSOE5oR0QxeWtUNlhNU3k3?=
 =?utf-8?B?NnJreFJPQzI0THBGU3k3RkpZdGNMNXZWSXlHN0pGNzArejJjN1JGM0lMVk1H?=
 =?utf-8?B?ZERURlhIeW83K0VVVmc0cnBHRFI2SmR1L0FVdGZIanVXUmFkbHBPa0pOb0d5?=
 =?utf-8?B?RnlvNU4vcXJnOWcxL20wOVgwRlAyem5PUk52QUtIbWhpNUNYWFhOS1pYZUNl?=
 =?utf-8?Q?72+mgcJiW2PtpGa7MvdmODCwA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e58d852f-cdef-4432-b46e-08dbf78ed7ff
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 01:41:48.7048
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VSyg0jGCwFT7ox3DYvAIXr7EYmP2DuinMf3Jcuyd3XY486XRvfOQMRsnKySKZ10waEkj114c8CJZYBSeo+x4VQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8504
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 07 Dec 2023 17:42:06 -0800 (PST)


On 12/4/2023 10:21 PM, David Hildenbrand wrote:
> Let's convert remove_migration_pmd() and while at it, perform some folio
> conversion.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>

> ---
>   mm/huge_memory.c | 11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 4f542444a91f2..cb33c6e0404cf 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -3276,6 +3276,7 @@ int set_pmd_migration_entry(struct page_vma_mapped_walk *pvmw,
>   
>   void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new)
>   {
> +	struct folio *folio = page_folio(new);
>   	struct vm_area_struct *vma = pvmw->vma;
>   	struct mm_struct *mm = vma->vm_mm;
>   	unsigned long address = pvmw->address;
> @@ -3287,7 +3288,7 @@ void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new)
>   		return;
>   
>   	entry = pmd_to_swp_entry(*pvmw->pmd);
> -	get_page(new);
> +	folio_get(folio);
>   	pmde = mk_huge_pmd(new, READ_ONCE(vma->vm_page_prot));
>   	if (pmd_swp_soft_dirty(*pvmw->pmd))
>   		pmde = pmd_mksoft_dirty(pmde);
> @@ -3298,10 +3299,10 @@ void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new)
>   	if (!is_migration_entry_young(entry))
>   		pmde = pmd_mkold(pmde);
>   	/* NOTE: this may contain setting soft-dirty on some archs */
> -	if (PageDirty(new) && is_migration_entry_dirty(entry))
> +	if (folio_test_dirty(folio) && is_migration_entry_dirty(entry))
>   		pmde = pmd_mkdirty(pmde);
>   
> -	if (PageAnon(new)) {
> +	if (folio_test_anon(folio)) {
>   		rmap_t rmap_flags = RMAP_COMPOUND;
>   
>   		if (!is_readable_migration_entry(entry))
> @@ -3309,9 +3310,9 @@ void remove_migration_pmd(struct page_vma_mapped_walk *pvmw, struct page *new)
>   
>   		page_add_anon_rmap(new, vma, haddr, rmap_flags);
>   	} else {
> -		page_add_file_rmap(new, vma, true);
> +		folio_add_file_rmap_pmd(folio, new, vma);
>   	}
> -	VM_BUG_ON(pmd_write(pmde) && PageAnon(new) && !PageAnonExclusive(new));
> +	VM_BUG_ON(pmd_write(pmde) && folio_test_anon(folio) && !PageAnonExclusive(new));
>   	set_pmd_at(mm, haddr, pvmw->pmd, pmde);
>   
>   	/* No need to invalidate - it was non-present before */