Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <0a734107-292e-47fe-b2ac-d295ec3dd9a0@intel.com>
Date:   Fri, 8 Dec 2023 09:42:10 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 10/39] mm/migrate: page_add_file_rmap() ->
 folio_add_file_rmap_pte()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Hugh Dickins <hughd@google.com>,
        "Ryan Roberts" <ryan.roberts@arm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        Peter Xu <peterx@redhat.com>
References: <20231204142146.91437-1-david@redhat.com>
 <20231204142146.91437-11-david@redhat.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20231204142146.91437-11-david@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWl3RzdzVUlIMS9BWjZpYTJFWmptZXZaUkdmc2l1RzJ1Wk03L2RDeDhNejUv?=
 =?utf-8?B?WE5UTnh0N2RwbE1ISmpxL3ZMZU5NYWNIVUZPSGZBR0ZFWmk3amNSWGdBRzNL?=
 =?utf-8?B?V1RFNWNONjE4NmpGVHlLZ1ZHcXVQdG5lQmJIbCtMUXZ1anlxMWRQc29xbTRt?=
 =?utf-8?B?cTNyb1VYcEFraG1OaVBmbHNkS3pJVXE3NWdNRmQ5eFk0UHBJdDdlZTd4eDNH?=
 =?utf-8?B?UmxIbjJvNWJpbGRLQnhib2xYUjV4SVBCSVdHRUN6ZlhCa2JrblhvUkxxTnJi?=
 =?utf-8?B?S1pkU1JVa1BnMjI1TkI2Y0FaNTgzWTAxa3RVSFU2WHRRTVhXL0N0ZHh2QW9q?=
 =?utf-8?B?ekFCRGtCTFJBSWRwTEI0Y3pOajZCVUdGMm1hQW1nL3o2TFcxcG5TdjdIa01y?=
 =?utf-8?B?TUFpWElNZzBHZzV2MFpvdExMd1lybEo1Yk05dEcrMlpvaWMzelc2emtIbTh4?=
 =?utf-8?B?TnhDL2xQN1p1VUVSRlZwSjROQ2prSGQ1eUNjNE1JN3Y0WDVMWXQvRytMRHRN?=
 =?utf-8?B?ekpZb3NEdVBoUG1nT1RzVHlHZEVRSXJzT1JlZDg1Vy9nb1JYMi9ZU0JBdktk?=
 =?utf-8?B?OTJCM05sc0ltUTFHKzhMamVZaFZ6RFNPbTQyUmh1ME0yQm5jUUdleUJRbDlL?=
 =?utf-8?B?NEJENDJaYXBFekVub3RPNlNOWEg4eERkcS9yaHRTbWtiUXBLQVk1empCU2ZD?=
 =?utf-8?B?QUJidmVuRzhwZVNGVmFuYXFSbHdCN3NMUkNTcU5SeWRMbFdHOVJQNWwzeVB4?=
 =?utf-8?B?OUE1cFFyK0FaN0hQek5wMjhvRlVHNGdBa1RaL3g3Q0VnaWJNdG41NndDSHJp?=
 =?utf-8?B?WXFsSCtwNTJrWW1TQ0FMT2FncnEzWHUxWnhKTkVqcjNvbFZtZDdleVcvSnpw?=
 =?utf-8?B?MmM4aWdUd3hOM1JhTDBKTHRrcXgrK2lpUUx2SWFmVW13Sk4wckNlMzNxVzVv?=
 =?utf-8?B?UExGa2g2T0lHKzVrcElWN2xxZjR1SWRVWkZJWVBkcjcwZmljckdUY2JkNnVI?=
 =?utf-8?B?SWRGRVVpMGZOMm93dmFxMmhNUllmYkMvcW5ON3JSNDZvNlV1ZVU4Z2ZwWUUy?=
 =?utf-8?B?UTlWcWhCRkpmZW9KdnBZcVpHb25vS3ZhbWc3Kzh6cDZuWEFTR2ttMXhmK0hw?=
 =?utf-8?B?Q1lpMWVqSWtWZC91dWlVUCtPYlpXWmdPaHBoeGFxMmhEZGpkOG85NjBGSFFr?=
 =?utf-8?B?VG5qL3pNVUhtTTBlL3NqZWFSVjUwN1FZVlJkU2t3RXkzSWJVYW4rdzZLdXJV?=
 =?utf-8?B?S0doRFRMYUtLcldPbW43OFpJNWswOVA1WFc0Y3A1dW9LemFrMXBVbG5MWUov?=
 =?utf-8?B?cHAvSTRzT2pUend4QXB1N3B0OVp0SDB0Vm1tZlNRS0JGdFduamM3aUJuako2?=
 =?utf-8?B?T21wOEttOE1vVmYrMXFvUVl2M0M3Vkh0bDJmUzFmeXpNR2Y5NjNNSkd0NVov?=
 =?utf-8?B?dEJzYjRNcW52QnRPVHd5Snk2RjlpbURjUGttcTltUGlTTy9KdDlVZmpFdFMx?=
 =?utf-8?B?SXAybUVIaFU4b24yWkQ2L1ZsZHV0WkhlSkVWNUUzTjJ0Y1FYZVUxZWt6N2hS?=
 =?utf-8?B?WkRidzNFOHhsTW5XY3M1NWRFTXZJazVjb0NOeXNOZjlIRUxMQjVnOENKK01I?=
 =?utf-8?B?azdUa3drczlQdmtUNXd4MmRqRCtJcjdSa1MzaTFiZ0dJazlwbmxscnpieWsy?=
 =?utf-8?B?amhEcDVmdnc1QVZIMWlXTS8va3RVUDN1Rkd0QUhQV3BvZXpGNXp3N0lJMllX?=
 =?utf-8?B?Uy9KbmJsd3lQSWRLT282NXRyT1g0UUVxdlR6OWY5YWNzM3FXM2c5LzlkcmRu?=
 =?utf-8?B?Z0YwMDJDcklkZk1YOHlLWHhQbE5FSTJHUCtzOVl0eGZibmJZU1RuYnFPems3?=
 =?utf-8?B?M2RSdFRYenhsZXZJaEJ0dkIvR3E2Z3V6RFNVR0NCdTRBcU1BaWJQb1hvYmZS?=
 =?utf-8?B?QnQweWpKTStCQUVaUER0a21TMWFkRXBCTWN1VVFvelg1YTZRZHhuc1RpVCtC?=
 =?utf-8?B?SkI0clo5bTlLME9HUWtqZzcxT0NyOFlUUExGYjRMS1pnWnNRbW1LOUQ1MnJ0?=
 =?utf-8?B?UlVJbTRoNDhFQVI5VXduOUErTGZJLzJia2kwOVB2S0JMc1pqaVJYS2VnK1I0?=
 =?utf-8?Q?++GE/7n6qXdV0yHuyZ57dk9qq?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 90c7449b-1432-4971-e7ca-08dbf78ee732
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 01:42:14.1672
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E8MMmMaHX094xCSXbTSkDZORf9sqlxjdEH+gwE8OHbI+XKFXnSqke98DAtPwH9tJcbQaX/1KLuGJoijASsz21Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8504
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 07 Dec 2023 17:42:27 -0800 (PST)


On 12/4/2023 10:21 PM, David Hildenbrand wrote:
> Let's convert remove_migration_pte().
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>

> ---
>   mm/migrate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index de9d94b99ab78..efc19f53b05e6 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -262,7 +262,7 @@ static bool remove_migration_pte(struct folio *folio,
>   				page_add_anon_rmap(new, vma, pvmw.address,
>   						   rmap_flags);
>   			else
> -				page_add_file_rmap(new, vma, false);
> +				folio_add_file_rmap_pte(folio, new, vma);
>   			set_pte_at(vma->vm_mm, pvmw.address, pvmw.pte, pte);
>   		}
>   		if (vma->vm_flags & VM_LOCKED)