Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <9dd3769e-2ca8-4fbd-8e1f-5aa304cdf442@intel.com>
Date:   Fri, 8 Dec 2023 09:42:30 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 11/39] mm/userfaultfd: page_add_file_rmap() ->
 folio_add_file_rmap_pte()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Hugh Dickins <hughd@google.com>,
        "Ryan Roberts" <ryan.roberts@arm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        Peter Xu <peterx@redhat.com>
References: <20231204142146.91437-1-david@redhat.com>
 <20231204142146.91437-12-david@redhat.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20231204142146.91437-12-david@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUU4ZFZuOHM0Vjg5eHRNTGI2YlpTZTJxcTdWcUp6b016Wm1YYUJaLzJRZy9Z?=
 =?utf-8?B?Nzc0MmR2VDFhbEZnSWJiZU5LdFJpYXpLVHZwbG91U2x5ZmtIaStDM1RCVmRm?=
 =?utf-8?B?NktVa2kzNUdLOGFxTjZzUGhFanAzNzBOVjJ5WHlYQnNweGFYNm41eEFpY1VF?=
 =?utf-8?B?MzZ1Y0VBczdJUHBmeUNCL2lLV1JKYy8rU3B6YVpZczdxc1dMYmdhOWFnOE1Q?=
 =?utf-8?B?ZXVEWTVJZktFZnVNREU4bHNualhpTmo0YTRETjhjOHBOeXpaamNscm81NUNS?=
 =?utf-8?B?OFlYcXZlYWp4b3RpZzl6bzRoZ1piNldVdlVDYlUzTGExL3ZSZmJ4VVIybThF?=
 =?utf-8?B?QSt6aklQakJPZFFETGQxZlZvVng4K0w0NlhNSmlYSk1NMnN3dkZUWVU5dEhU?=
 =?utf-8?B?NWp0Yk5mNFRvbEk3ZWFNeEhPMDlwVWM4dk1ZV09IekswdXlhWWxxVFN2bWJC?=
 =?utf-8?B?OXFiQ0pGMFdJczEzRi8xNk40QWMxcmx0Nm5PVm16ZTFhNWhVUUYzZTdLWExs?=
 =?utf-8?B?YjVUdWZUQUx1TzV3U24rcktZN3lqdmtYQVFRbkdqbW1DOVN5K0Y5Qm94ellr?=
 =?utf-8?B?Q0ZXdHZ6RHd3QlVNeitWdHppeGpyeUJhQzdiUzhwRytmcFduTmIwT2l5Mmp6?=
 =?utf-8?B?Z2Z4NWV5WlNrdndvR24vaHo4Mzd6SXpWREE3Yzg5ZmpIYzJxOTIxem8yeVNs?=
 =?utf-8?B?S1cwZi9FUkdwV2hxdjNxVC8yWlZONi9jbUwwM2IwWkp2VWJqYjRuWEIza1Zu?=
 =?utf-8?B?RzBBdWxiYzh4WmZRblN5cGlINm1hayt5ZHdDbmdCbWRmOURlK0FZejEwNkkx?=
 =?utf-8?B?R0VFbFRORC81NkF3ODkycVJCQmRHcG1Id042bGxjRVBZZklxYUR3MWNxWnJa?=
 =?utf-8?B?bTJubHJ0cU4wb3JORFBaWTk3MCtKbGRleWZoSmwyd1RrN2ErZ2pXYVVJMmQ3?=
 =?utf-8?B?Z0habjBCaTNwQnlMemV5RjBISmJhcXYrTVE5Nkt3eFQ2Z0dRMUZEOE5XK2FR?=
 =?utf-8?B?dStYSDR1a2hTY0lYUEFxd2xxM1B6ODJ2bVNIUDFYTHY4RU9lbmppRW1Zcy9Q?=
 =?utf-8?B?NUFkWGQrNy90THJmTUNDOU5VTTgrY3AyV1Y2ZjhsOWxrVXBUajZSU1lwV3Nq?=
 =?utf-8?B?QlFpeVRubnJ1R1Z0Ylo3NXFnbGNkUU1DaHgwTy80NEt3UTJrVEl5cCt1STZl?=
 =?utf-8?B?RTNYbytFdkpERUFOT0FwbURIaVFGdTFicVhTZmwwM0RKbmRIei9kTjBYVW9S?=
 =?utf-8?B?VCtab01Eb3RNZm5DL2pvTEFJcTR5RGlMTFc5ZVRQT2NWK2lRWTlmVGhzWDhB?=
 =?utf-8?B?UWMrdzNnM0svNW5Sb1Z4ajh4MlFWVlVzMW5VWStHTks2V045VXZwOFdnNHp6?=
 =?utf-8?B?ZWxCUFdjb3pJRVAzUUhXVS9sV1BOc0xtNHhFWjNVc2R2anFqK3pOWk1iejBW?=
 =?utf-8?B?TXVEQmpVSjhrUENsc1VWSTcwQVJoOEc4bTN3ZDFFSG1HenYzbUx0ZkpiYVNM?=
 =?utf-8?B?Zkg1blc2UVhHL0ZzSDcydkJ0WTNsdUFjM1UzWjdnbmY1cEpKMVJza0xka2Zk?=
 =?utf-8?B?NXBiYmNwYWp2UUhyem1vVEw5OXhIMGxSYkNSR3BEbHFjU3hqZzlYZTZ3cExK?=
 =?utf-8?B?bk05T290U2MxZ2JJYXFTNlZwYkdzS0VVTUpqKzlyVFVuTHMrbUd2dHU1eTdW?=
 =?utf-8?B?UGI3eG1FVEw5MVo2Q2wrZEZveVBGZTgwMm1hTXQ4MHpuTFJNOWVUL09odVFr?=
 =?utf-8?B?YTg1dE5Mb09pSlR1NGZDUENydEVMTGEwQmRad0t3VUJVZTRNV0ZJaW5lVURz?=
 =?utf-8?B?TzFpRlRyV1ltaGlCeDlFNjI1TnMwc0RRUkcrQ2JicExzb3kzUDV3bVFFRnhp?=
 =?utf-8?B?cVFFckxLRkRDbC9zR1Q2NGxjMEpOc2JsUXRYZUlOVEJHQks2bkVJZWhrUlJC?=
 =?utf-8?B?SnUzSEUrOURndURjeGE0RVFJd210S1BxeXFYV1ZyU3BnRnFCbmtwdHQxOU1K?=
 =?utf-8?B?dU9SREt4VUY4R3hjN3VtVkxxbys3QXMzRE1lemVZeGdZZGNHcUR5bFcvbjJK?=
 =?utf-8?B?YXUyVVY3LzFQd1FPMjg1UWhSNStyNFc2RmVXMHIvK0dSTGxtRWhoMkFJNDlz?=
 =?utf-8?Q?OyB2aXIsbUjdDPDP0wcDIePn8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e1622334-bab0-4e2f-896c-08dbf78ef2d2
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 01:42:33.6758
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u0Gvsu2iYFvRDqLjpfBTCZBonS3eAnA/gGXuga11cRIHM/7YN7RuLrN6ytrf4yh0RYqWa0C1pIQLCEOfRBRmvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8504
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 17:42:49 -0800 (PST)


On 12/4/2023 10:21 PM, David Hildenbrand wrote:
> Let's convert mfill_atomic_install_pte().
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>

> ---
>   mm/userfaultfd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
> index 0b6ca553bebec..abf4c579d328a 100644
> --- a/mm/userfaultfd.c
> +++ b/mm/userfaultfd.c
> @@ -114,7 +114,7 @@ int mfill_atomic_install_pte(pmd_t *dst_pmd,
>   		/* Usually, cache pages are already added to LRU */
>   		if (newly_allocated)
>   			folio_add_lru(folio);
> -		page_add_file_rmap(page, dst_vma, false);
> +		folio_add_file_rmap_pte(folio, page, dst_vma);
>   	} else {
>   		page_add_new_anon_rmap(page, dst_vma, dst_addr);
>   		folio_add_lru_vma(folio, dst_vma);