Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <3a9fa1b7-6bcc-4749-92e7-ef3563a70701@intel.com>
Date:   Fri, 8 Dec 2023 09:42:53 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 12/39] mm/rmap: remove page_add_file_rmap()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Hugh Dickins <hughd@google.com>,
        Ryan Roberts <ryan.roberts@arm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        Peter Xu <peterx@redhat.com>
References: <20231204142146.91437-1-david@redhat.com>
 <20231204142146.91437-13-david@redhat.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20231204142146.91437-13-david@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFJzWTlzWmZqVkVZcUMrZ01XcXE3b2p0Qi9FZzBqczdhRnpwbEtWTE5XUVBa?=
 =?utf-8?B?UFJnZDEzNkJ1a0ZCbDlSTDJnc1VQZWUzNHI5b2gvYlRqOFRmcmtZQlBuYmtF?=
 =?utf-8?B?bGk5L0tXQTRFUzFLMnQyd0s4Rng2YldwNS83U0dPdWVERytyOWtONE1Nb0No?=
 =?utf-8?B?bmN5UzgyR1hManhFbW1BUzM2V0tnU0RhZDRZVEdScWpmTlJENTNPZjV0dFJs?=
 =?utf-8?B?WXQyUmlIbk8yK0hGVEMrOHJkdzBTbDRsSCs4cGRXZlI4WlFQSVZOandsNE4v?=
 =?utf-8?B?YlI3Rk54dEJackh4OG83ajFORVAweTNCVDJGdWRGTVRmcjZYbGhiQ1BTaTJE?=
 =?utf-8?B?MjVaL1c3UFM3YTM4WFB3b0V3L054M04weU9NTTNIM1ZmSFl1ejNmMjhnYUhB?=
 =?utf-8?B?WVJsc1hBSVNRK2ZCL2tYRDcvRmNLQVlDYjUzSXk4eG10eFdYR2Zqa3dhZGEx?=
 =?utf-8?B?R01LYXQzZGV5Z3paalRMUE1IaVVGbXZ0SFdGcGMvcExFbW96VnY4a1hWNTRT?=
 =?utf-8?B?ODZnazFPcE5zS013c0grRTIxNEU4UTcvMExIMDNGTUZ6OWllUEhKZTdCbDZr?=
 =?utf-8?B?L2FCLzRhT2FZZXd5ejJDTmVGc3hobWFDZC9vSlhFQmsyL3hWQ1poUXZRRlRZ?=
 =?utf-8?B?ekNNZDhOMHhRMGJjZXpKVnhteG5LMFZUaEpxVkloTk9GbjZWeE5hRHJFQlhv?=
 =?utf-8?B?OW9saU1SRWg5bVhQS1A2VUJNdmViL0xiTXZaOC9KTjJRMXBXSE8wNlE2cVQ4?=
 =?utf-8?B?eTN3SDdPS2hiWmZGQWNlbXduejFYNHIzSFczUktGTmx6b2ZMR29PYS81UjR1?=
 =?utf-8?B?M2dqejdGMG5heGVKT3R4U1NQWnRNS3FzQzkwcVU5Sm53bDNTQ3dGblI1Q2Ni?=
 =?utf-8?B?WlBhWit1RjRqcTc3U2ppcURyMVZoeFZPZ0lKa0xTWjJuK3dVcXJ1Y3J3MTg1?=
 =?utf-8?B?VVZpR2lqUVhUUTVmS29sTGxaTU9qRG1RNDVacTh3ZzdkcnF3MC9ZdjFYZy96?=
 =?utf-8?B?WlJlczdMYlNabkZEVGdFN1BmOVVCUkVKM2xPZE9jL2xoZDJXeTNOaWRXaFkr?=
 =?utf-8?B?cHZTSFVEQlV4OXpSOU50S1BRNWEzM0xncGlyZE52VHczdFN0RDdweGVHekti?=
 =?utf-8?B?STFyWmtOTHhvcExZdTRnWVJYOTFpeUhVMWc4bXVUdjdUQndkcGlEVTAveXZM?=
 =?utf-8?B?Y1RyMkVQbG1oeFBxak5YYk5RaUJuWVNpUjgxbWRhZ1dyUThKL0hMaGlaSS9Y?=
 =?utf-8?B?NTM0eUNXbGcxcVQwVXd1djd5ZHpYT1l4T3RVd0JVMkkwY0ZRUWR6cWhVS241?=
 =?utf-8?B?UGN1elRzeS80dHRRTFdvV0JobEZRUmNsV3pMcG8rOXp5R2phQ0hTRFJqbUwy?=
 =?utf-8?B?WTFCWjRLZ3hlSWFGZUd6ZUlNWExZYjNCK29lYW9xTTZCOU84RldVL2NOdHJP?=
 =?utf-8?B?Skt5Q0tETzBENysvUzdVbVlOWnpaekEwZHRaaTJoWHB0V2Z3Tk1vTGdHL0VF?=
 =?utf-8?B?cGtzYTAwQ1lVT2xqVHRJVmFidXVXbTNXNU5HSjFWY1ZOb2g1VWhnb2hETUYw?=
 =?utf-8?B?eUVrOUY5VU9pMm1uTk1HaDE3N1NsUmdtQ21Cc1Q5V2pqWXdHY053SW5NbUJK?=
 =?utf-8?B?VXBWMlN0Tjc5bFhFMTE0eVhmUVJhNUxoS2xSQklWaktUNlEyMjFRTFBxOUhk?=
 =?utf-8?B?VUlXa01VQ3piTU4yUGZpcWJkV0UxQmZUVjFyNVN0aVJsZC9YMnZZcTJPb2dC?=
 =?utf-8?B?L0poMFFncnR6Vi9OenZKL3VGMHN6dHIrc0VjenozQTNuODJUZXo2bE9UMzlK?=
 =?utf-8?B?TDhXNnU0WmF2VHJBcWFVOFFSbUdOWUFrUis5b3JOeWhwMGhUMEpsKzdhREFa?=
 =?utf-8?B?MTNCdGRUdDhYUVhSS3pKajVhc3N4eld5T3ZMM1RxUUl2UXp2TFFKU251ZUlQ?=
 =?utf-8?B?ZVdLckVzSlhkaW94Z29teUpsOEIxWFlFd2ZWV2JjNVp4TEFWaitidmhWaWNR?=
 =?utf-8?B?YkxpVTZoU3U0UFRjdXphdnBqYkc2RUdmcDcyTFo4MlBYZU84Sk1ndnV5N09I?=
 =?utf-8?B?VlJudk13V1hXNmpHRmkyY2xaWlhta3hPYWR1NWhIcjMrM1VqOGdIQ0NKTUx4?=
 =?utf-8?Q?FxsScQpBDO0yNItlUy8X72rU4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fc864315-f532-42c6-a0ff-08dbf78f00a9
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 01:42:56.8972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /opP/9YZr+bJuePJGm5vSTOqud8S2UCPU+RCOLdNDrbROZsbFbjnlznk4yHPbAgsuOMXgxS6ZQcb4KYxoJYZTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8504
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 17:43:19 -0800 (PST)


On 12/4/2023 10:21 PM, David Hildenbrand wrote:
> All users are gone, let's remove it.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>

> ---
>   include/linux/rmap.h |  2 --
>   mm/rmap.c            | 21 ---------------------
>   2 files changed, 23 deletions(-)
> 
> diff --git a/include/linux/rmap.h b/include/linux/rmap.h
> index a4a30c361ac50..95f7b94a70295 100644
> --- a/include/linux/rmap.h
> +++ b/include/linux/rmap.h
> @@ -235,8 +235,6 @@ void page_add_new_anon_rmap(struct page *, struct vm_area_struct *,
>   		unsigned long address);
>   void folio_add_new_anon_rmap(struct folio *, struct vm_area_struct *,
>   		unsigned long address);
> -void page_add_file_rmap(struct page *, struct vm_area_struct *,
> -		bool compound);
>   void folio_add_file_rmap_ptes(struct folio *, struct page *, unsigned int nr,
>   		struct vm_area_struct *);
>   #define folio_add_file_rmap_pte(folio, page, vma) \
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 1614d98062948..53e2c653be99a 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1422,27 +1422,6 @@ void folio_add_file_rmap_pmd(struct folio *folio, struct page *page,
>   #endif
>   }
>   
> -/**
> - * page_add_file_rmap - add pte mapping to a file page
> - * @page:	the page to add the mapping to
> - * @vma:	the vm area in which the mapping is added
> - * @compound:	charge the page as compound or small page
> - *
> - * The caller needs to hold the pte lock.
> - */
> -void page_add_file_rmap(struct page *page, struct vm_area_struct *vma,
> -		bool compound)
> -{
> -	struct folio *folio = page_folio(page);
> -
> -	VM_WARN_ON_ONCE_PAGE(compound && !PageTransHuge(page), page);
> -
> -	if (likely(!compound))
> -		folio_add_file_rmap_pte(folio, page, vma);
> -	else
> -		folio_add_file_rmap_pmd(folio, page, vma);
> -}
> -
>   /**
>    * page_remove_rmap - take down pte mapping from a page
>    * @page:	page to remove mapping from