Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <b0745f11-0483-4898-9b92-dc73afd5e64b@kylinos.cn>
Date:   Fri, 8 Dec 2023 10:05:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 iwl-next] i40e: Use correct buffer size in
 i40e_dbg_command_read
To:     Tony Nguyen <anthony.l.nguyen@intel.com>,
        Alexander Lobakin <aleksander.lobakin@intel.com>
Cc:     jesse.brandeburg@intel.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        jeffrey.t.kirsher@intel.com, shannon.nelson@amd.com,
        kunwu.chan@hotmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Simon Horman <horms@kernel.org>,
        intel-wired-lan@lists.osuosl.org
References: <20231205095844.2532859-1-chentao@kylinos.cn>
 <2a0f3c2a-71fe-4c79-8827-e53088bf3761@intel.com>
 <92e5cc01-e8b3-b6d2-e884-3d6bd001f0d0@intel.com>
Content-Language: en-US
From:   Kunwu Chan <chentao@kylinos.cn>
In-Reply-To: <92e5cc01-e8b3-b6d2-e884-3d6bd001f0d0@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thanks for the reminder. It was my negligence.

I'll resend the v5 patch:
1. Keep 'Signed-off-by' be the last tag in the block
2. Cc to 'intel-wired-lan@lists.osuosl.org'
3. Cc to my personal email 'kunwu.chan@hotmail.com'

Thanks again,
Kunwu

On 2023/12/8 07:25, Tony Nguyen wrote:
> 
> 
> On 12/6/2023 4:40 AM, Alexander Lobakin wrote:
>> From: Kunwu Chan <chentao@kylinos.cn>
>> Date: Tue, 5 Dec 2023 17:58:44 +0800
>>
>>> The size of "i40e_dbg_command_buf" is 256, the size of "name"
>>> depends on "IFNAMSIZ", plus a null character and format size,
>>> the total size is more than 256.
>>>
>>> Improve readability and maintainability by replacing a hardcoded string
>>> allocation and formatting by the use of the kasprintf() helper.
>>>
>>> Fixes: 02e9c290814c ("i40e: debugfs interface")
>>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>>> Suggested-by: Simon Horman <horms@kernel.org>
>>> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>>
>> Your Signed-off-by must be the last tag in the block.
>> Perhaps the maintainer could fix it when taking, so that you wouldn't
>> need to send a new version only due to that.
> 
> You missed Intel Wired LAN (intel-wired-lan@lists.osuosl.org) on this, 
> though the other versions did have it. Could you fix this up and be sure 
> to include Intel Wired LAN?
> 
> Thanks,
> Tony
> 
>>> ---
>>> v2
>>>     - Update the size calculation with IFNAMSIZ and 
>>> sizeof(i40e_dbg_command_buf)
>>> v3
>>>     - Use kasprintf to improve readability and maintainability
>>> v4
>>>     - Fix memory leak in error path