Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Fri, 8 Dec 2023 11:28:17 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        wangyangxin <wangyangxin1@huawei.com>,
        Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH v2] crypto: virtio-crypto: Handle dataq logic  with
 tasklet
Message-ID: <ZXKNUdXNV7G3ED3P@gondor.apana.org.au>
References: <ad8c946eb2294a7bb9eef26066c06b72@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ad8c946eb2294a7bb9eef26066c06b72@huawei.com>
Precedence: bulk

On Wed, Dec 06, 2023 at 11:52:51AM +0000, Gonglei (Arei) wrote:
> Doing ipsec produces a spinlock recursion warning.
> This is due to crypto_finalize_request() being called in the upper half.
> Move virtual data queue processing of virtio-crypto driver to tasklet.
> 
> Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver")
> Reported-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: wangyangxin <wangyangxin1@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  v2: calling tasklet_kill() in virtcrypto_remove(), thanks for MST.
> 
>  drivers/crypto/virtio/virtio_crypto_common.h |  2 ++
>  drivers/crypto/virtio/virtio_crypto_core.c   | 26 ++++++++++++++++----------
>  2 files changed, 18 insertions(+), 10 deletions(-)

Your patch has already been merged.  So please send this as
an incremental patch.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt