Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Quan Nguyen <quan@os.amperecomputing.com>
To:     Brendan Higgins <brendan.higgins@linux.dev>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Andi Shyti <andi.shyti@kernel.org>,
        Andrew Jeffery <andrew@codeconstruct.com.au>,
        Wolfram Sang <wsa@kernel.org>,
        Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
        Guenter Roeck <linux@roeck-us.net>, linux-i2c@vger.kernel.org,
        openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     Cosmo Chou <chou.cosmo@gmail.com>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>,
        Quan Nguyen <quan@os.amperecomputing.com>
Subject: [PATCH v3 0/2] i2c: aspeed: Late ack Tx done irqs and handle coalesced start with stop conditions
Date:   Fri,  8 Dec 2023 10:31:40 +0700
Message-Id: <20231208033142.1673232-1-quan@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X1xR5eN0pHZh1uAhSSyXy0A5LWj7k4hl7WRijPJlme6viubNkPgymyHLtvbC?=
 =?us-ascii?Q?Ur9x/9tVF7PuE3UfM39W8HnmJPAaAcOiTLx0+mB7Vx1zSYqT6bsh8x+lqOtA?=
 =?us-ascii?Q?UjojgQ6djk36tFulp0FlgAmHiI4ayDXNPMUmCXhsBW5kewOzFS+1O/rrp9Kk?=
 =?us-ascii?Q?pti3ct6cVGG7SYAmrePej5ZzExMfqvMXFn+Kluw501cny8ukfvkOw758zte6?=
 =?us-ascii?Q?hfXO2xgYCLCBBj2jbseuDpnDpxrhfPwsyc3HXbsdVWj+TK4ymuf5TdqGo9El?=
 =?us-ascii?Q?o4xX/dR9L3B4ZFCBEigbB6sWPHUjZvRym/3DPbwKS98yF013k/oK6+VvizHn?=
 =?us-ascii?Q?Iw2nu/W96UPsAY8cic0Ke/TwbsOkJK2yyKbDg9xE9aISK+hH3JbYrDDiy+TV?=
 =?us-ascii?Q?vElGtPPXE+y7Uj7OFXv/DL2dBrgIntORT+yB86sgKIeIsVoHsxIydfJNP48v?=
 =?us-ascii?Q?tju6spFWhns61icoZcoX0dY7xHeIiP68CMFPRXuAlYoUKPn4tYmI2Ng4ALcb?=
 =?us-ascii?Q?jLC0cX+LKTQVqf9Oxy61sfd13AU5lgNPmQol0i3AwfyWa7g3DI4M79cQhA5J?=
 =?us-ascii?Q?loZCOItp1AsTHTlW7VEHLrxOOgSZCDHK0QbhpQ0v8FYNM7AhI1HB4QUKW/nl?=
 =?us-ascii?Q?Ptagz0d4TvCnPRxn9TCtESUaV7HHPRTzXkVXbybf6KwnoWSt4VrATRTG3xJx?=
 =?us-ascii?Q?dlX77/ESgdMjV2UTG3EtIHClwuGonSWz16o4FyOcpasKib8tYy7tWtKRJiul?=
 =?us-ascii?Q?9VNPITtIPnGrCa+0M1Zj3Jho12x5K0ga1WsSHhDuUPH1EL7HD4yUEIa0TLkQ?=
 =?us-ascii?Q?VN+XD8RyUkDL5NPtPZmLL61SeMmJlsRTjOrbCx80Lw8DYvjYtmy7OVqJIBXD?=
 =?us-ascii?Q?vwmK9/3gtShffMm61zekUtpscxO00vDSn8o/16kho70jN9tKjjerl3pwWhPn?=
 =?us-ascii?Q?Q4icBy8Fq+LvpfqhyI/hUlJ2c2Aye20Lr1uOdl/559TsHmUucNfnwVOL0YdN?=
 =?us-ascii?Q?QoDXkllQ15ywZEnG5ppgeMESqPOvIcay7A047sXd14lBpnkDbJc22Rfv6DyO?=
 =?us-ascii?Q?XoleG35HnCPIIFLWV1tGl5BTZaJ9NAlNuP1WaiwKOrBJ2gTCD5GsCbp7G4bj?=
 =?us-ascii?Q?6b2TG/DnfggrHG+nntSztjJoasHAiuVRsLfXH+F6Qe6Jj5sWIRr3VHQgiwwv?=
 =?us-ascii?Q?JNuQjuws/f00lwmS00qBZgMP+48nLM/kQ84BZvI00KzPut31cyAMYEfbrBoi?=
 =?us-ascii?Q?vLazwEqYg7hCu6ZuUAqldEH1AZr0GeNGQsWZot3fSUKygVu3I5V/Esbms14D?=
 =?us-ascii?Q?m0yLgJiqgDWvp7EJdQQ6tC73t84A9SHIsfIiCh742ol+D44mgi/j9OCGlQy9?=
 =?us-ascii?Q?fRfgJ4az3YByOLbmnjXZPmkpdfOcJOmxsrGO3SPNXZg2ZcMiRaHjnnzrqi22?=
 =?us-ascii?Q?lBLB7hYiFJRpxdrkd7o7PV49T0VUbxjJ/q9BjDFiXlXm/ufWvtaVqZPKANS6?=
 =?us-ascii?Q?Qb65RO5wKX8ga5WXf8rnLmJr+WvviBC28jxzUN2YQ4rV3g+nddu7xicVpk8a?=
 =?us-ascii?Q?Thy3tihiN8ai1bh5YxdecgB+4J9JHiFh2z3G4BHjbnViC4AKi+kqLUX6AqMu?=
 =?us-ascii?Q?pMKa/jr2s1/Gj3AqEj7fGr0=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be53e5db-e957-4c65-4f3f-08dbf79e3ed8
X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 03:32:03.7359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: reYVh9vf0Ut9jJckx0NRMM/OP1S08MqYWorP4HMiT7wpxEoxRDltJ1p3rckgmPjzGA10Im3YF/bb4XOA+aFV9m8/p47GGX+ECkVbWfVkVs0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR01MB7784
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 07 Dec 2023 19:32:23 -0800 (PST)

This series consists of two patches to handle the below issues observed
when testing with slave mode:
  + The coalesced stop condition with the start conditions
  + Early ack'ed of Tx done (ACK and NAK) causing "Unexpected Ack on
  read request".

This series was verified with ast2500 and ast2600.

The prior discussion could be found at:
https://lore.kernel.org/all/20231128075236.2724038-1-quan@os.amperecomputing.com/

v3:
  + Fix the unconditional write when ack the irqs              [Andrew]
  + Handle the coalesced stop condition with the
start conditions                                               [Andrew]
  + Refactor the code to enhance code readability                [Quan]
  + Revised commit message                                       [Quan]

v2:
  + Split these patches to separate series                       [Joel]
  + Added the Fixes lines                                        [Joel]
  + Fixed multiline comment                                      [Joel]
  + Refactor irq clearing code                          [Joel, Guenter]
  + Revised commit message                                 [Joel, Quan]

v1:
  + These patches are first introduced from this disscusstion
https://lore.kernel.org/all/20210519074934.20712-1-quan@os.amperecomputing.com/

Quan Nguyen (2):
  i2c: aspeed: Handle the coalesced stop conditions with the start
    conditions.
  i2c: aspeed: Acknowledge Tx done with and without ACK irq late

 drivers/i2c/busses/i2c-aspeed.c | 68 +++++++++++++++++++++------------
 1 file changed, 44 insertions(+), 24 deletions(-)

-- 
2.35.1