Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.7\))
Subject: Re: [PATCH v2 05/13] crypto: simd - Update `walksize` in simd
 skcipher
From:   Jerry Shih <jerry.shih@sifive.com>
In-Reply-To: <ZXKV/nLAQpUx6AX0@gondor.apana.org.au>
Date:   Fri, 8 Dec 2023 12:18:39 +0800
Cc:     Paul Walmsley <paul.walmsley@sifive.com>, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, davem@davemloft.net,
        conor.dooley@microchip.com, ebiggers@kernel.org, ardb@kernel.org,
        heiko@sntech.de, phoebe.chen@sifive.com, hongrong.hsu@sifive.com,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <5684F139-A0DE-4A9A-B937-9DF5130E5BD7@sifive.com>
References: <20231127070703.1697-1-jerry.shih@sifive.com>
 <20231127070703.1697-6-jerry.shih@sifive.com>
 <ZXKV/nLAQpUx6AX0@gondor.apana.org.au>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Precedence: bulk

On Dec 8, 2023, at 12:05, Herbert Xu <herbert@gondor.apana.org.au> =
wrote:
> On Mon, Nov 27, 2023 at 03:06:55PM +0800, Jerry Shih wrote:
>> The `walksize` assignment is missed in simd skcipher.
>>=20
>> Signed-off-by: Jerry Shih <jerry.shih@sifive.com>
>> ---
>> crypto/cryptd.c | 1 +
>> crypto/simd.c   | 1 +
>> 2 files changed, 2 insertions(+)
>>=20
>> diff --git a/crypto/cryptd.c b/crypto/cryptd.c
>> index bbcc368b6a55..253d13504ccb 100644
>> --- a/crypto/cryptd.c
>> +++ b/crypto/cryptd.c
>> @@ -405,6 +405,7 @@ static int cryptd_create_skcipher(struct =
crypto_template *tmpl,
>> 		(alg->base.cra_flags & CRYPTO_ALG_INTERNAL);
>> 	inst->alg.ivsize =3D crypto_skcipher_alg_ivsize(alg);
>> 	inst->alg.chunksize =3D crypto_skcipher_alg_chunksize(alg);
>> +	inst->alg.walksize =3D crypto_skcipher_alg_walksize(alg);
>> 	inst->alg.min_keysize =3D crypto_skcipher_alg_min_keysize(alg);
>> 	inst->alg.max_keysize =3D crypto_skcipher_alg_max_keysize(alg);
>=20
> Sorry but this patch doesn't apply any more now that we have
> lskcipher.

The lskcipher is merged in kernel `6.7`. I will rebase the v3 series to =
`6.7` later.
Link: =
https://lore.kernel.org/all/20231205092801.1335-1-jerry.shih@sifive.com/

Some dependent patches are not applicable to `6.7` now. I will check the =
status for the
dependent patches.

-Jerry=