Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2124865rdb; Thu, 7 Dec 2023 21:07:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHnOQnT34zpnegFYHDyCQmRm+GDehwBpoIZwZWtNxWIdsCD0fACpRMkzzvy3CP/wcR339+z X-Received: by 2002:a05:6358:9141:b0:170:2f74:9311 with SMTP id r1-20020a056358914100b001702f749311mr3488399rwr.45.1702012060773; Thu, 07 Dec 2023 21:07:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702012060; cv=none; d=google.com; s=arc-20160816; b=L/hQl2bpL5NNCuzcRcQyjD30xlc6SCCuNA7k3Sc5aY4O88drva1v5FXtS25m/kwIEY gIN8gwqBgk2bTxd3yUZXz9rI7XrgwwNKnl0uC+YiHL0w8/q/HLeEnS+6+9Lyuq6pcaHT XyVEjPvwpSn/JXezSQ6NcizH+rkEAKMFQw0B5LbV4a4giCnLlXOWkOPsJc3Q4JGCax2J 5FFjLLXWuKulO3yTZjW3/qbsdgjIqCD66RRamKepxD1N/zK2oi2t+q8rEFPvmwVqhTQE 7zz9EVHiZf8aRDQy7vWaCCVd18EmvrLqm0rybVKhf2ioHDOmk8RkF/vgzj9AFjRce7qu xcwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sFAZQh7Op4A+uCLjA7Qf2L2PPhQEVm3aZqLD93pQD0A=; fh=bCPr6FtHW7vqpnFZy/5ChZdmzRzyfr1lCT+1Yh+hWj4=; b=N14mV+WI+/S9Hl6UA90AZ/ksa3Addz38yYeuGBVHG8BjFuM/J5sK1hfhAMzI1+DO5F HGLGjcuOXLvl6ejAiwyyCTbhU18R2MJY2471dT7SJJqrKa4VsxAaDq3QUY/NgmgtoW5l LcBqECQmqdu33y93X/5t3KY2Yxasd3ueicBubxb7Te6F701gk1vEfN0H8u7nPC5fVNCX qleHYTMoFlwaaaF7k0TbhKzveSfXN+BGbQRg54TdW/Yt7i18v5q9kOu35CVK1K3rQVpK SpD0d/bjV/gTylzsqkuLIoMHjXIVDKZ/u2bkgjWyZGIJ6KbYIolEE4AWop3ULmm8RYkS z4zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=gpP7pEmI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id q24-20020a63e958000000b005ab53fee611si879058pgj.423.2023.12.07.21.07.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 21:07:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=gpP7pEmI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3BCDA8106792; Thu, 7 Dec 2023 21:07:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233163AbjLHFHG (ORCPT + 99 others); Fri, 8 Dec 2023 00:07:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232268AbjLHFHF (ORCPT ); Fri, 8 Dec 2023 00:07:05 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD69010F9; Thu, 7 Dec 2023 21:07:09 -0800 (PST) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B856oja020854; Fri, 8 Dec 2023 05:07:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=sFAZQh7Op4A+uCLjA7Qf2L2PPhQEVm3aZqLD93pQD0A=; b=gpP7pEmIUchpQAT8SY2VmvnMlRwFCf7qdBmUBTTpnohFRRA2FL486Ablo8XzqvinFHNz +VJTOkZ0sV2Dm1ga++sY5jNV/4XwB1vOQXmRoct7Qpe7IiaE/rGlmBhAyrfAEyElgF9D RQEhN5LdOTZTOM+FL21fal4wFKSEWHp1WjLKQQQhEi+6X19FdrN6m2PPmi8prNnct7HQ UkQRkZIFDLMI4pI6zSq5/1XkBXhXS5Fohmy550fJabX2ER4HDPbhu/3mBbpfAzu0MI5J ukln8B9Do+R+WoEYQ1e7oRlj7MgjHWSLOlUp9xpBJSTjnbxsFZOLnkC9vHW3wQODz0wy mw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uuphg8na3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Dec 2023 05:07:04 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3B8573FL014591 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Dec 2023 05:07:03 GMT Received: from abhinavk-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 7 Dec 2023 21:07:02 -0800 From: Abhinav Kumar To: , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , "Daniel Vetter" CC: , , , , Subject: [PATCH v2 03/16] drm/msm/dpu: fix writeback programming for YUV cases Date: Thu, 7 Dec 2023 21:06:28 -0800 Message-ID: <20231208050641.32582-4-quic_abhinavk@quicinc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231208050641.32582-1-quic_abhinavk@quicinc.com> References: <20231208050641.32582-1-quic_abhinavk@quicinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: SqAPlZCyzLvb_FBEDwH6TyMNvYe4MQlD X-Proofpoint-GUID: SqAPlZCyzLvb_FBEDwH6TyMNvYe4MQlD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-08_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 malwarescore=0 mlxlogscore=966 suspectscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312080038 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 07 Dec 2023 21:07:33 -0800 (PST) For YUV cases, setting the required format bits was missed out in the register programming. Lets fix it now in preparation of adding YUV formats support for writeback. changes in v2: - dropped the fixes tag as its not a fix but adding new functionality Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c index ed0e80616129..e75995f7fcea 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c @@ -89,6 +89,9 @@ static void dpu_hw_wb_setup_format(struct dpu_hw_wb *ctx, dst_format |= BIT(14); /* DST_ALPHA_X */ } + if (DPU_FORMAT_IS_YUV(fmt)) + dst_format |= BIT(15); + pattern = (fmt->element[3] << 24) | (fmt->element[2] << 16) | (fmt->element[1] << 8) | -- 2.40.1