Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <c8e1594e-1379-4fb3-904f-fba2cd194cdc@redhat.com>
Date:   Fri, 8 Dec 2023 15:07:22 +1000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] KVM: selftests: Fix Assertion on non-x86_64 platforms
Content-Language: en-US
To:     Shaoqin Huang <shahuang@redhat.com>, kvm@vger.kernel.org
Cc:     Paolo Bonzini <pbonzini@redhat.com>, Shuah Khan <shuah@kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvmarm@lists.linux.dev
References: <20231208033505.2930064-1-shahuang@redhat.com>
From:   Gavin Shan <gshan@redhat.com>
In-Reply-To: <20231208033505.2930064-1-shahuang@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/8/23 13:35, Shaoqin Huang wrote:
> When running the set_memory_region_test on arm64 platform, it causes the
> below assert:
> 
> ==== Test Assertion Failure ====
>    set_memory_region_test.c:355: r && errno == EINVAL
>    pid=40695 tid=40695 errno=0 - Success
>       1	0x0000000000401baf: test_invalid_memory_region_flags at set_memory_region_test.c:355
>       2	 (inlined by) main at set_memory_region_test.c:541
>       3	0x0000ffff951c879b: ?? ??:0
>       4	0x0000ffff951c886b: ?? ??:0
>       5	0x0000000000401caf: _start at ??:?
>    KVM_SET_USER_MEMORY_REGION should have failed on v2 only flag 0x2
> 
> This is because the arm64 platform also support the KVM_MEM_READONLY flag, but
> the current implementation add it into the supportd_flags only on x86_64
> platform, so this causes assert on other platform which also support the
> KVM_MEM_READONLY flag.
> 
> Fix it by using the __KVM_HAVE_READONLY_MEM macro to detect if the
> current platform support the KVM_MEM_READONLY, thus fix this problem on
> all other platform which support KVM_MEM_READONLY.
> 
> Fixes: 5d74316466f4 ("KVM: selftests: Add a memory region subtest to validate invalid flags")
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> ---
> This patch is based on the latest kvm-next[1] branch.
> 
> [1] https://git.kernel.org/pub/scm/virt/kvm/kvm.git/log/?h=next
> ---
>   tools/testing/selftests/kvm/set_memory_region_test.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 

Reviewed-by: Gavin Shan <gshan@redhat.com>