Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2157968rdb; Thu, 7 Dec 2023 22:50:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEDfFdd/7mB4H/br9R8kaQH0uuDl3Tme/XuTLNnaZ4S4L1+L8R4mLgBxui5gc4yQ90IFTr+ X-Received: by 2002:a17:902:e882:b0:1d0:b340:43a5 with SMTP id w2-20020a170902e88200b001d0b34043a5mr3459153plg.89.1702018235180; Thu, 07 Dec 2023 22:50:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702018235; cv=none; d=google.com; s=arc-20160816; b=nWMQ4SqelANXxMHPJLusgaWW7ds6cxm77KvXJLQvrmIsFsBeeEGVl/U5vhT1DP3OrF pzhA6V6rLdFHR2vwe3CQoBcGle+yrXGClAtKwRzwImjKW9NsEN5ezKc4JxiwVYH8xmAl iZ2gzw7kkaGJBhSk1DNnBraPcXgkyxU7QtDjn0P8MHdmzZPovxvh1dYZmEaOjFEZmBzQ U0IOKMGI70CN/VYLzDKN8uJS6kkJNJo4CQTPKC0dTIASnWAM8vrkux8F81G+QHIGAvVL 8xMLET2PvRaBrzO7sdOA+u4NDmqfQ+U+Tnd5PeCODkBF4Y7nOD/BjeeQsDx9L+KU2d1m FIZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6vNx/GObIoBCOfOe8R9wec9Jk1YEd/189TnXX5w65+Y=; fh=JRsfYrXvNIZ84hhNbDna781vC2RCIEaktV+JrfR19PU=; b=0KE3CRlzJbkmlyCVBqygmWZV4IzDkDrDW1qMYHeuN6mX6veqwIg/K63iFgBaV23iBU S6ZCNqEj/YNPZqhYYcFgfDsVW+STeBm8amILokojgIA1qB4Xk3HJDrt1FGh4sBFYi3iV KTLywi7CyOQrxISYmfpKZK2s4lhxrPoqY1AkhWrRBzC+5pxDJrpZa4cQxbJN5DakHbpc LwjFIxO8ER7c2OMxGHkfxWE7D4cPqBE8GlFW5RB17RzhCaN+boLrYSijJSIvSNezOJq2 DOM21VHhhCunQfN3CBKABSDnKdFAKznmRVQ26CnRQ+ttD5nzc45zsOsq9BGIdfUOMFaJ ASkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=grMw9MAi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id 11-20020a170902c20b00b001d06da42b0csi1025070pll.503.2023.12.07.22.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 22:50:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=grMw9MAi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 7914B833E1EB; Thu, 7 Dec 2023 22:50:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbjLHGr1 (ORCPT + 99 others); Fri, 8 Dec 2023 01:47:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbjLHGrZ (ORCPT ); Fri, 8 Dec 2023 01:47:25 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3F2F1723 for ; Thu, 7 Dec 2023 22:47:31 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 241D6C433C8; Fri, 8 Dec 2023 06:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702018051; bh=aVwOp1aJPsPh7+HlQ/vujBgUZmjHqe7FfCfwGE1YeZ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=grMw9MAilAqZVJpURavXBJKJpCfqFYqXS/93nfol1/6O4gqg8/TbHPtjeINDoQ3XL 5o0UXU39UnthFKO8a/M6TZ5cd9D5f/5lIVWYHc3xDCUI9NjoTSRfNEWfr6eNmHJFAM G40GKVqdEDQ2ZeQYF3wiWqFQCn6t9VlU2zUH/HPM= Date: Fri, 8 Dec 2023 07:47:29 +0100 From: Greg Kroah-Hartman To: Alexey Khoroshilov Cc: stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com, "lvc-project@linuxtesting.org" Subject: Re: [PATCH 5.10 000/131] 5.10.203-rc3 review Message-ID: <2023120849-catalog-pretzel-ee8f@gregkh> References: <20231205183249.651714114@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 07 Dec 2023 22:50:32 -0800 (PST) On Thu, Dec 07, 2023 at 02:00:06AM +0300, Alexey Khoroshilov wrote: > On 05.12.2023 22:22, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.10.203 release. > > There are 131 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.203-rc3.gz > > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > > It seems something is seriously broken in this release. > > There are patches already applied in 5.10.202 that are in 5.10.203-rc3 > transformed in some strange way, e.g. > > Neil Armstrong > tty: serial: meson: retrieve port FIFO size from DT > > > commit 980c3135f1ae6fe686a70c8ba78eb1bb4bde3060 in 5.10.202 > > diff --git a/drivers/tty/serial/meson_uart.c > b/drivers/tty/serial/meson_uart.c > index d06653493f0e..78bda91a6bf1 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -728,6 +728,7 @@ static int meson_uart_probe(struct platform_device > *pdev) > { > struct resource *res_mem, *res_irq; > struct uart_port *port; > + u32 fifosize = 64; /* Default is 64, 128 for EE UART_0 */ > int ret = 0; > > if (pdev->dev.of_node) > @@ -755,6 +756,8 @@ static int meson_uart_probe(struct platform_device > *pdev) > if (!res_irq) > return -ENODEV; > > + of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize); > + > if (meson_ports[pdev->id]) { > dev_err(&pdev->dev, "port %d already allocated\n", > pdev->id); > return -EBUSY; > @@ -784,7 +787,7 @@ static int meson_uart_probe(struct platform_device > *pdev) > port->type = PORT_MESON; > port->x_char = 0; > port->ops = &meson_uart_ops; > - port->fifosize = 64; > + port->fifosize = fifosize; > > meson_ports[pdev->id] = port; > platform_set_drvdata(pdev, port); > > vs. > > commit 71feab929585232694b4f2fb7d70abde4edc581e in 5.10.203-rc3 > > diff --git a/drivers/tty/serial/meson_uart.c > b/drivers/tty/serial/meson_uart.c > index bb66a3f06626..c44ab21a9b7d 100644 > --- a/drivers/tty/serial/meson_uart.c > +++ b/drivers/tty/serial/meson_uart.c > @@ -765,6 +765,8 @@ static int meson_uart_probe(struct platform_device > *pdev) > of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize); > has_rtscts = of_property_read_bool(pdev->dev.of_node, > "uart-has-rtscts"); > > + of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize); > + > if (meson_ports[pdev->id]) { > dev_err(&pdev->dev, "port %d already allocated\n", > pdev->id); > return -EBUSY; > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE > > > > See also: > > Qu Huang > drm/amdgpu: Fix a null pointer access when the smc_rreg pointer is NULL > > Axel Lin > i2c: sun6i-p2wi: Prevent potential division by zero > > Takashi Iwai > media: imon: fix access to invalid resource for the second interface > > > Also there is a strange pair: > > Patrick Thompson > net: r8169: Disable multicast filter for RTL8168H and RTL8107E > > Heiner Kallweit > Revert "net: r8169: Disable multicast filter for RTL8168H and RTL8107E" > Ok, I dropped all of these and manually verified that there were no other duplicates. thanks for catching them and letting us know. greg k-h