Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2161539rdb; Thu, 7 Dec 2023 23:01:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGU0pHDbtyb73kSOd2x0hqmDVx57na2OzN94xmNSjvJPEZzXilEXZP2KOQUy68vc7kBAROx X-Received: by 2002:a17:90b:4c05:b0:286:8abe:4d42 with SMTP id na5-20020a17090b4c0500b002868abe4d42mr3808698pjb.21.1702018889828; Thu, 07 Dec 2023 23:01:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702018889; cv=none; d=google.com; s=arc-20160816; b=aHgBN2CjYV7GLB2gZnCB0J9zgLdWKjrJSOpyMwGHno9Y2ZRaezSXZFIojY7Ie+5sfo DeqZ6yIUVt5GbHN3nSYUPgLeDsbkE90WLk4ANW1ueGkTP5+KKnOBJ0WdOcFGbFYHWFSe Uz+hQGB/tc1NuQmET/+NUZYnCnCvDEJe6DGF1wNMwqwAP+Rb4CGSTNndNSE1scLY1qrQ tG7oGXqDW8zD0hWHlW5VFeA8465UAkpVLCv6VGLVlTU/9ty3m2dlJhqFP3TMS4dzaCm2 fn73lmTTASEtZDyu3fPrzv6CFoy2hZGA0vOFsQRlKAo0pWeGgOS5bJVOgH4Q39gCqQC+ LqMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZMlhD8WS0RVtXNWZq8+Ekz+zAl7Mbew6ctHcI4T3R2A=; fh=3M/8bTCRB16Lsc02X7bSCpILCqUt5UU6Z9lIcVlF+qQ=; b=hq8gTmWnlnI/V1UvsT8a10QL9+e48bRkzcZpBn892ibU1FgQLcrXsWZ3eP7ElguTBO AzCzhRIwAwTDvUgpvWkJei+1I5/qycFFHL9/Y8KNd0fVNUY/YiuBurYZGvbJKlmHRL2T mY7RZV0afQWz2OQccIbn+GkXjSe4xbvxhvHTO0kbbyuCJkZPPBpjlIuDGFHXQm34wy40 uxNtD68AUq1+3UtmP1Y/p5UtSqRoVAR9lcBpjlgpqFy3s1GahgBRFUbuHv3LZXDU7tx7 W1fsyig1CxONpy2ycYf06CFXx2YqoxNws2uXG4u6sIvPvUm+NXikZJbnRIUXHLNBzSKv 7Zkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w17CAwjn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id f2-20020a17090a664200b002869b531c26si2464556pjm.96.2023.12.07.23.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 23:01:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w17CAwjn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3179680A21BD; Thu, 7 Dec 2023 23:00:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235757AbjLHHAR (ORCPT + 99 others); Fri, 8 Dec 2023 02:00:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235706AbjLHG77 (ORCPT ); Fri, 8 Dec 2023 01:59:59 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7228E173B for ; Thu, 7 Dec 2023 23:00:02 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1d1e1edb10bso16238105ad.1 for ; Thu, 07 Dec 2023 23:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702018802; x=1702623602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZMlhD8WS0RVtXNWZq8+Ekz+zAl7Mbew6ctHcI4T3R2A=; b=w17CAwjnBiSA5PJez0PVyJiJdKr/bj+JBOG20onw+6Kv5mV1jQX9kB9ucvfRm1QHs/ c2jwDB3MqsglMdnhWbqWuVqvbrVeQDGTlTDVBigWMpryNNVx3vhS39gDjuuYbyj5c21y QwyephmqTeaTT4CfzzCZ41c7fNJfP3LTVWWvLKXlxQnlBA+0NWY+ZTUdV6b8TOnMzk4T Cpc3d7vOH+etmycLfQrfGZIq8xioTBmpi/zHcLTL+1KbcWybspNc6wNRzGty9KJxe3yF oW8pr+uHjJbTuEO66KtKGY/qFPGm1xz9XXxvboOb5DgLmoGAGnfKvB2JalZ8VVqWecKG Yfmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702018802; x=1702623602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZMlhD8WS0RVtXNWZq8+Ekz+zAl7Mbew6ctHcI4T3R2A=; b=CEOi70zrVxmyEcsJTX1O8CSO7YnxiIy5C3ll96s/1MHXmb4fPiwP2wgR6haeHTIOGD Wu/60CvvoAWMcpPUcMBNIe1ozg2CENzTChv03SZ9707GbQITcaCnuN6AYCNhLH3BcFYU guOLbAWtGyxxn6+GFLv1efFQPNte9XUEfFCswoa8LaCrhqkNFQmIaDESvxd04onEhA2I CB7uXxdzv/2/HE+EtWmU1qKbNGH1WxgKSH1c8Yx+L8T586CS63JZgxTPDoxGebKqLcuM swOqO63mQP8SMFZJ9yYq1rMaKXsv3627A4zSdlpJ1OIpjBHCPRfAgFORIjirigaq1ZSg TBrA== X-Gm-Message-State: AOJu0Yw8fjZM9l3y2GlAVEUyTAGDebByCQ0j9/6rnh4a7fGadxSsReE2 nfRvxOfhc96Ld5TcfqPL8jG0 X-Received: by 2002:a17:902:f68e:b0:1cf:ad5f:20ab with SMTP id l14-20020a170902f68e00b001cfad5f20abmr4410627plg.19.1702018801803; Thu, 07 Dec 2023 23:00:01 -0800 (PST) Received: from localhost.localdomain ([117.216.123.142]) by smtp.gmail.com with ESMTPSA id n8-20020a170902e54800b001b03f208323sm934263plf.64.2023.12.07.22.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 23:00:01 -0800 (PST) From: Manivannan Sadhasivam To: martin.petersen@oracle.com, jejb@linux.ibm.com Cc: andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, ahalaney@redhat.com, quic_nitirawa@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 09/17] scsi: ufs: qcom: Remove redundant error print for devm_kzalloc() failure Date: Fri, 8 Dec 2023 12:28:54 +0530 Message-Id: <20231208065902.11006-10-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231208065902.11006-1-manivannan.sadhasivam@linaro.org> References: <20231208065902.11006-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 07 Dec 2023 23:00:43 -0800 (PST) devm_kzalloc() will itself print the error message on failure. So let's get rid of the redundant error message in ufs_qcom_init(). Signed-off-by: Manivannan Sadhasivam --- drivers/ufs/host/ufs-qcom.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index b141dd2a9346..05a9a25bc34c 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1109,10 +1109,8 @@ static int ufs_qcom_init(struct ufs_hba *hba) struct ufs_clk_info *clki; host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL); - if (!host) { - dev_err(dev, "%s: no memory for qcom ufs host\n", __func__); + if (!host) return -ENOMEM; - } /* Make a two way bind between the qcom host and the hba */ host->hba = hba; -- 2.25.1