Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Jiangfeng Ma <Jiangfeng.Ma@synopsys.com>
To:     Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Simon Horman <horms@kernel.org>,
        Andrew Halaney <ahalaney@redhat.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Johannes Zink <j.zink@pengutronix.de>,
        "Russell King (Oracle" <rmk+kernel@armlinux.org.uk>,
        Jiangfeng Ma <Jiangfeng.Ma@synopsys.com>,
        Jochen Henneberg <jh@henneberg-systemdesign.com>
CC:     "open list:STMMAC ETHERNET DRIVER" <netdev@vger.kernel.org>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        James Li <James.Li1@synopsys.com>,
        Martin McKenny <Martin.McKenny@synopsys.com>
Subject: [PATCH] net:stmmac:stmmac_platform:Add snps,xpcs devicetree parsing
Thread-Topic: [PATCH] net:stmmac:stmmac_platform:Add snps,xpcs devicetree
 parsing
Thread-Index: AdopoV2G4U4p6KhERnimGhWz15Hefg==
Date:   Fri, 8 Dec 2023 07:02:19 +0000
Message-ID: <SA0PR12MB44138E48A245378CF54D2F9ED98AA@SA0PR12MB4413.namprd12.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kPygtv7u6zRw4l4RVO7jmubN0tmuLc3CzjhEHLlue2EB3iHqV3xb2gE5+YQo?=
 =?us-ascii?Q?VApwC9OTqPuWE85W4eGjdTb2B4QwsJbNISshPig+u8jOAspji3nZDgnymH1l?=
 =?us-ascii?Q?kgTzgzkP0Gol82a5Onq7Ia94IuF0zRHsKqySqslg5EDoNEXUqSmsA0ktdvwz?=
 =?us-ascii?Q?dkkRluOz9bPHquf4AmtLR/mwhIJln18Lxkw/27SgL2QGKImG99zyXOLDfKxB?=
 =?us-ascii?Q?O2vxCF30cJctBp9dAwL7RkHdPuqcs4ptRvlelpAbubkr60IKVzUh38UQk/UT?=
 =?us-ascii?Q?MpEyiqVTCkYnjx+sygAqeNILbsV00FfERuQ2sS48aABgqF6O7KFmtRzO0mc5?=
 =?us-ascii?Q?y8pLzcNXZJ2HRqOzDsixUsxtYmoaicFufHx2D8/9521m2/WZZWDJGJnINi9K?=
 =?us-ascii?Q?RGoAskJ9xYr7GUgTuUDBdKMuR4LQsznBS3N7ThVzEv9Fqh+GUTJEJgzlRNZj?=
 =?us-ascii?Q?f1GuNwOgMgtFMBkEPSNzeYegPf5PnAjQdfMcrAVY/oZ0PaPz8meeEER3S268?=
 =?us-ascii?Q?7d/9U0Rco3fIFg18yq5ePqYJA7e+vxAziAt2Su4s1GhogOm5Ju38acUI/V54?=
 =?us-ascii?Q?Xc5cQR2nU6HhteJ24+wttJhTsarNDVeWP1NI+BVl2DBZ+/yrYaJOKWJ7NnBB?=
 =?us-ascii?Q?B6LGKFecuq3QQRWogMs53W5eitr+Vngd6vyzE/HaZNlgcOxRYF3SvrkkHuGf?=
 =?us-ascii?Q?AMQn+3ZgIaGGfVyjQagWnZirzWEVl9MMenoz8WHcGeeDbqXahg5rasrwsrhI?=
 =?us-ascii?Q?ANQRuSIy9WJfGGmhYWcZ8jI6ZGwiEFfYBTtTrqr9f7jc3EBHKtgDmqNDbu0m?=
 =?us-ascii?Q?9UqmfGDPIhriRoabWPMacTxFEyhrxtclf5qJEM/Ptqm649ZPsKtIajFW/III?=
 =?us-ascii?Q?4bUODPo925D4XoXA2JNem7HRZzFchrvd9t45xJz3NCuAeMGxqb1KhX3SVdm2?=
 =?us-ascii?Q?TJ5ywau/dsGUYkawdP3ax6mdb036h6pYnCYjkFIhesXERH08U4MR8mRyn1kt?=
 =?us-ascii?Q?4burDkk0EcNjNKbl2E0kxelRCFJ4g1mUNnkf22g7iBtseUUtXxD/NeFwkNsJ?=
 =?us-ascii?Q?p/YDCVduMWTpFjGEIBfjWnKX4mB0Pt7hz3Uv1Su71+U8vUX5ZUyDCLtJiv3L?=
 =?us-ascii?Q?CwLiCUVSWM/KjMN4Mq8tK3XiwL6GAw2RMKAAyBhWm0snshNNf1J9pL2tsyAR?=
 =?us-ascii?Q?b3JORizQux33g7NYpivKPll5QA/fs4kfCad8dVwMJGvuyInwj27JlvKnDFQM?=
 =?us-ascii?Q?YJWRrETKLrfgU2EBl/YWteaal2fq13hGc6EA3ZorT9PWSrGNTkgoxkA5UPYX?=
 =?us-ascii?Q?Rd9JrnIWTiuJRQZPFor8GgZXCWa6UFMBxvL2GZ3WOYaR+0jR64i8wT2WSZT3?=
 =?us-ascii?Q?HFML0NCN4wZ+D88XdDJcnQwQ9TydxojrbwAbUXtr/gw0Rxqh08r/n/dkV+cc?=
 =?us-ascii?Q?77t2cYZVO5WhnivbRXeUlVSub1twRYAyk+5WwvQnWYxZz5a0bEiJVi+BQsAw?=
 =?us-ascii?Q?oN+KePuTIdsdp+tKd86EdGIot7vNlghR7rXbkhFCmaJiyxU+I6Lh0IXPkisS?=
 =?us-ascii?Q?TSgEvFPHesA/kXWP5BU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?gjrmHc8NwC0Pb8SWPMgB1GIQMLR7iDzHt/I0kV4TNRpfujAo+MUniGHbpa3W?=
 =?us-ascii?Q?NPHdXJbqfBDX7RFtcr/UKEeaAbQGsV2kBtfZlp0yBUFQ/r+9FhSuVJnWaEHw?=
 =?us-ascii?Q?5ni+fiS9yJ1cl45P1j4CLmkbgT6VXqeFmoQgoYhgBL7xTkQw9n8Xko5erlLK?=
 =?us-ascii?Q?qRHKpjdEa4m38+MixnmfttT9RsaBjkEGnGhJfZ5cppI4SfYdd58v7+xKEQxK?=
 =?us-ascii?Q?1iMagPoeB8MTQuGbdUQbjBqT7pSvxrl7AwMbIzIW9Ebu0/HUOQ/xj4LgplHY?=
 =?us-ascii?Q?sqDr6sp+WQ4oF85b8Ej7XU698AwXjvjeIH0fZRMvMhZkVdAibbNUxzRbqliE?=
 =?us-ascii?Q?aWtFUG7cP6b/ejcO90zUzDhnobvgjBiscxAL2mduR3EQG0vpOxTbQbb3gk85?=
 =?us-ascii?Q?oqT2XY2GgH88Xr/luOFYFQ+a0heppAp9nRbrZqcHJBhUGpfaQfHs9yfl/bbO?=
 =?us-ascii?Q?YKHYQhybNdaU+mXl/I2VPqedUA56uPq6/Qo3qw3uD7yeces/+ZnzkT9C4N70?=
 =?us-ascii?Q?gqwvXj/pQLGSkt0Nd886W9u2n5ftv54FHi/rxKJCYoehgQnqLdMccQMTSns1?=
 =?us-ascii?Q?3vNqgvaX/NVAk8fyX7gwps8Iu8pSUZ5PButE9GNJOICrtJHCaSz75N4F2Sxw?=
 =?us-ascii?Q?Hle7TRivZUcoXog9snumn9wjBEOWiOrOPiQZOVdrjJyp8hZyBPZO17234pK0?=
 =?us-ascii?Q?FDFL+i9GjoxvFvgy9dlRS8unmSvQ3pIimSFtQUU+mf/6x9kmjJ3z+8z1byoI?=
 =?us-ascii?Q?x9mq3o1bcRvj1mFPEvgZFjgUG36Bk9grAFiGU1ekL0rrzWGeR+GiP5gZidM8?=
 =?us-ascii?Q?4EZDA1zJq/bsB/O6KI7EIOeQ42tKF/c2VvAZlGd/utTSNQp2HeIPWOBE31dL?=
 =?us-ascii?Q?lPlApAS5vtUtTknPxuM7TbkXNtI6vgyrg35dichx5E5DPgcF5Cy71y1LvoKY?=
 =?us-ascii?Q?Khh861xWShsp7l3D+a4NATKtUxXmZOUfcpAbidkp7+b+fOBBxr9PwkyFqFf2?=
 =?us-ascii?Q?HUid2UNsSeX9sKS5C8qtev/1AWw74l2/jhtkX9iBBv/9fJn4HwxxpBiUG0n5?=
 =?us-ascii?Q?i+DjM8YV25E1emmjjRTX9AsHzVOrsrJxu/OF4hWbkRl5sN/xD7gR4ik7+crG?=
 =?us-ascii?Q?7FzTSYem4dQN/yg/KiEeUi/qRqgYQj88/oAu5iYaCHgJw+ADTf4zT04zZMA2?=
 =?us-ascii?Q?4/ffbRSb0saQeSjI0S5DJlmFH9tBq3nLuLwI4giHspUl4bVxazAGIWeMyI6C?=
 =?us-ascii?Q?cAIxJ6Zhx4TfTiBXvVfDt4DhxJXCs6z+gdQFaHddpOz6H5MIj7xXSFLWLNN7?=
 =?us-ascii?Q?yOMJ3PUvqwnLtOAU3hDn+A4q?=
X-OriginatorOrg: synopsys.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4413.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6673443e-a292-40b9-9e42-08dbf7bb9eb4
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2023 07:02:19.6136
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uEypVRFpnX6yaAfo59bmPPDcwZvMlji2YrAoavdoa+5AY6HW7BRz5+RHXBNzsVBP/zZ67RTc4pYt1fjHOZNJWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8851
X-Proofpoint-GUID: QshAu9IbALMXv6kYSOX-DvpYXTbcQS-p
X-Proofpoint-ORIG-GUID: QshAu9IbALMXv6kYSOX-DvpYXTbcQS-p
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-08_02,2023-12-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_active_cloned_notspam policy=outbound_active_cloned score=0
 phishscore=0 spamscore=0 clxscore=1011 suspectscore=0 impostorscore=0
 adultscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 bulkscore=0
 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2311290000 definitions=main-2312080055
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 07 Dec 2023 23:03:58 -0800 (PST)

In order to setup xpcs, has_xpcs must be set to a non-zero value.
Add new optional devicetree properties representing this.

If has_xpcs is set to true, then xpcs_an_inband should preferably be
consistent with it, Otherwise, some errors may occur when starting
the network, For example, the phy interface that xpcs already supports,
but link up fails.

The types of has_xpcs and xpcs_an_inband are unsigned int,
and generally used as flags. So it may be more reasonable to set them to
bool type. This can also be confirmed from the type of @ovr_an_inband.

Signed-off-by: Jiangfeng Ma <Jiangfeng.Ma@synopsys.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 +++++
 include/linux/stmmac.h                                | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/driver=
s/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 1ffde55..6ebc2a9 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -324,6 +324,7 @@ static int stmmac_dt_phy(struct plat_stmmacenet_data *p=
lat,
 			 struct device_node *np, struct device *dev)
 {
 	bool mdio =3D !of_phy_is_fixed_link(np);
+	bool has_xpcs =3D false;
 	static const struct of_device_id need_mdio_ids[] =3D {
 		{ .compatible =3D "snps,dwc-qos-ethernet-4.10" },
 		{},
@@ -345,6 +346,7 @@ static int stmmac_dt_phy(struct plat_stmmacenet_data *p=
lat,
=20
 	if (plat->mdio_node) {
 		dev_dbg(dev, "Found MDIO subnode\n");
+		has_xpcs =3D of_property_read_bool(plat->mdio_node, "snps,xpcs");
 		mdio =3D true;
 	}
=20
@@ -356,6 +358,9 @@ static int stmmac_dt_phy(struct plat_stmmacenet_data *p=
lat,
 			return -ENOMEM;
=20
 		plat->mdio_bus_data->needs_reset =3D true;
+		plat->mdio_bus_data->has_xpcs =3D has_xpcs;
+		if (plat->mdio_bus_data->has_xpcs)
+			plat->mdio_bus_data->xpcs_an_inband =3D true;
 	}
=20
 	return 0;
diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
index dee5ad6..dea35ee 100644
--- a/include/linux/stmmac.h
+++ b/include/linux/stmmac.h
@@ -82,8 +82,8 @@
=20
 struct stmmac_mdio_bus_data {
 	unsigned int phy_mask;
-	unsigned int has_xpcs;
-	unsigned int xpcs_an_inband;
+	bool has_xpcs;
+	bool xpcs_an_inband;
 	int *irqs;
 	int probed_phy_irq;
 	bool needs_reset;
--=20
1.8.3.1