Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 8 Dec 2023 03:35:01 -0500
From:   Paul Gortmaker <paul.gortmaker@windriver.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        regressions@leemhuis.info, richard.purdie@linuxfoundation.org,
        regressions@lists.linux.dev
Subject: Re: [patch 0/2] x86/alternatives: Prevent crash in NOP optimizer
Message-ID: <ZXLVNeWBOWiauOjT@windriver.com>
References: <ZXCXc+BtnLzqMbFv@windriver.com>
 <ZUEgAAGDVqXz2Seo@windriver.com>
 <0adb772c-e8d2-4444-92b0-00cbfdaf1fac@leemhuis.info>
 <87r0k9ym0y.ffs@tglx>
 <20231207193859.961361261@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231207193859.961361261@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wnvtNRUMIuSe5B+FvzFKX2kEkkW/c2k8xLwEzZfIpIE/nsgRVVHTUGYLCUb1?=
 =?us-ascii?Q?CS4OhyaN7wya6e261/vI2b9x/IX/MaQa+Q7gfTb89+sTbB+yRXkcJxcVfMci?=
 =?us-ascii?Q?X5hEzHCWbORwrlwb9Ygh+qOHgP1LcWoyH3geciqj1Dum5Wrb2ZyCTCDGaYfr?=
 =?us-ascii?Q?dozqHTDwqkWWnifA15hb9RSe4H0qr2Aotqd/pIQB78wrEdHa3U2EVD/0rnV4?=
 =?us-ascii?Q?kdPKWlYdD+IQCEePM/uueQNjrGtL+uj0VstqyKFAHwglKx0E4IdmpI78Ss4m?=
 =?us-ascii?Q?6nF1ShyPhvk5tbSGrsmkAasdgmWaTg1X+TGz5eb2DGjArp+G7ZKzVTr/MeFI?=
 =?us-ascii?Q?CUOzep4eOM5ObN2DweI5aApfQisA+gO3J7fkhIbJYz62KZq6rK8uSTWxVnv3?=
 =?us-ascii?Q?dur54nVXyuKpePuc11D9BuCkNEYiHl6AXWWiaGK19PUa5uALSaXk8KmM2OiQ?=
 =?us-ascii?Q?LYAQMrROFmyI7RHsch2Dh1W/cshPjR0c4NM47kvhM3WfZutYUQm6dIfr1b6h?=
 =?us-ascii?Q?b3n0xqcOmI0CUR/cSXuOIGhJ3kwqRJbb9hSmhrrXw9B9mikDLUU9w4DDC5W8?=
 =?us-ascii?Q?gH6CPD4M9O3jb3uEZ+9OKFA094VT6zAmD62KUdangwHOteDQ+py3n+lYNaa9?=
 =?us-ascii?Q?zcfyWpxsqetCavr1To/Y+rcaueN/wLsRAMeKt7fw7Cq2UdUw/jtxJ/7kb6kd?=
 =?us-ascii?Q?TCNnG7h8iasIQcYBLgTGV7h9SjpM+crQx1HBQdWdjW2xrfXGO8aBN7fm4F5r?=
 =?us-ascii?Q?NZ9iKux6vN7pSVukW968gl0Z5kSRSuTtn8WS5rCNztnxCYb4T28xcvxwsw/C?=
 =?us-ascii?Q?xEd8SLoJcNzD2KcBfX4MivNPzchTLnXHAcx2Sewl8F/LN1yJzyM9Ler4rQCk?=
 =?us-ascii?Q?ta0JCTt6sxqn9YEX8kumlr7aFsmBrxtAP/eGZSde8DvGXD9zJssn5TWHZ8QH?=
 =?us-ascii?Q?CKteLWDwNGNGjNTfjiVpAxMRM5OneZwhtSAP3FMmIoVdP5z4DEZz1ysLQQpO?=
 =?us-ascii?Q?ewE5lJivLMxHxoO1qeLRGUJj3F2Qp07sl8+BCvxP1j8nrVxZgIFYUTMPrMXQ?=
 =?us-ascii?Q?NfhlY3mKejuzMCKMzuANYiAfkqzkwEH6a10EnbQKDWrkHfl/vSatGJdMm8nK?=
 =?us-ascii?Q?yJYV+zPTD9ERIpKV3Lb6c53ISeIvlGA1zRAqX9684humOXBrzl1kQhXlr3WY?=
 =?us-ascii?Q?57Ppj3lpO5a1tmZ06E958A4c1mwJjSU8YfpFsoWfSmsoMCwlATgQ3+YIEZ74?=
 =?us-ascii?Q?S910G9W36iVjlvFkXrQaLvHGC5R+kGbSyZhFHjU7HOIFBa5joENGY1z6x0RG?=
 =?us-ascii?Q?HeWHeW4qv0J1bf5tzyf42pEj+ZUfUuGffMrHI7xoyEAF9f2u23ffqEKuKO/D?=
 =?us-ascii?Q?BKRkiZbsENjF67l//pIrATF9z/tQDgDm8CpL6cBXD7ZsfBXulkthDhMDdXqk?=
 =?us-ascii?Q?x+HS7iZ1ACZ0qzaIGsPrEFOWbKIhlH9WGOXpfuuAKk9w1H7oMG7dubHu9wGG?=
 =?us-ascii?Q?8t7RdAu1zKDiK3hf3wLsdEUl0VxoplqdBJ7DUf7KJdVjXD6CQmqcRCgWIFNL?=
 =?us-ascii?Q?Dvy9zl2HM3/eGUtzX3k5xVEuE86bM+SVzrAv/gQyvVMPNqBuCLqXcmbKutxm?=
 =?us-ascii?Q?Zw=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 816522d2-6513-4a39-1fc1-08dbf7c893c1
X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7378.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 08:35:04.8455
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hsIPFYoHVTxp8ZaKqE4mBxa1IvkIeUMyH7s9WyJsVQd0l23AJEAB3ymB6qVO2GPi74bywODM1pOwlbrQmrDyoXXDAVtLNWrTcS8vyBC66lo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7599
X-Proofpoint-GUID: SMh1aTmjfmDFYJvZ6dy4Dgcrg2iJcK1r
X-Proofpoint-ORIG-GUID: SMh1aTmjfmDFYJvZ6dy4Dgcrg2iJcK1r
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-16_25,2023-11-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0
 adultscore=0 mlxlogscore=594 malwarescore=0 suspectscore=0 spamscore=0
 mlxscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2311290000 definitions=main-2312080070
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 08 Dec 2023 00:35:57 -0800 (PST)

[[patch 0/2] x86/alternatives: Prevent crash in NOP optimizer] On 07/12/2023 (Thu 20:49) Thomas Gleixner wrote:

> The following series addresses the regression report from Paul on behalf of
> the yocto project. It turns out that the recent changes to alternatives
> opened a race window where interrupts are enabled and NOPs are optimized in
> place. An interrupt hitting into the modification will observe inconsistent
> text and crash and burn.
> 
> A 32bit QEMU crashes w/o these fixes reliably within about 50 boot
> attempts. With the fix applied it survived close to 600 attempts by
> now.

I can confirm that - since I was already set up for it, I let it run
overnight for about 1250 attempts.  With an average of one in 200 that I
was seeing before, I should have had around six fails.  Didn't see one.

> Thanks to Paul for providing all the information!

On behalf of Richard and myself, thanks for the complex fix.

Paul.
--

> 
> Thanks,
> 
> 	tglx
> 
>