Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Suman Ghosh <sumang@marvell.com>
To:     Zhipeng Lu <alexious@zju.edu.cn>
CC:     Chris Snook <chris.snook@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Simon Horman <horms@kernel.org>,
        Yuanjun Gong <ruc_gongyuanjun@163.com>,
        Jie Yang <jie.yang@atheros.com>,
        Jeff Garzik <jgarzik@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] [v2] ethernet: atheros: fix a memleak in
 atl1e_setup_ring_resources
Thread-Topic: [EXT] [PATCH] [v2] ethernet: atheros: fix a memleak in
 atl1e_setup_ring_resources
Thread-Index: AQHaKa/kiVBfutZCDU+U5ccRmrHdR7CfE8aQ
Date:   Fri, 8 Dec 2023 08:51:14 +0000
Message-ID: <SJ0PR18MB5216FB178B2DD2760A3C9C7EDB8AA@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20231208082316.3384650-1-alexious@zju.edu.cn>
In-Reply-To: <20231208082316.3384650-1-alexious@zju.edu.cn>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1f8T5ZDVyYUTgQTRiZbsxtr5KAGWb2sJcfBqZHp5IYJmOHw1I9JwXA+Zf8zY?=
 =?us-ascii?Q?Di5/hmTiKruwRLL5FqGqu5YRaSvvT5qVY0RxlzfCU7XxHl/4eVvwKnUUyHxc?=
 =?us-ascii?Q?lN2Uy9oB0cFdBh4LxA0a6R5FDZ5XILEfRWCw8wb5wJBtpcIsVq6tE1ICUvW+?=
 =?us-ascii?Q?UBx5PUzacHuB+VHuC4XU7e371nKWIId5s2SEmSboZf7YbChR0fY6qlnAenB5?=
 =?us-ascii?Q?lpi2tQLM4bRs2R8N4JJJ35lt61xFYcF836dlc21cgRaG7ScvtODKPy2p5e4p?=
 =?us-ascii?Q?bDEYYE46F+w+Mxwho7KQAAM3tH9QnthGLps0r3kSziTttEqnH7j1cj/4ExeQ?=
 =?us-ascii?Q?f1va33p3YJ4wIjmpcAW4kT7YfDSyBwhPPQlKRzpCJCncjC6bJ+iWl+C8OjAA?=
 =?us-ascii?Q?vcvcDqLWfQTJye3GOxFYdjYEmbipqehMKgeTheBS8ZhfP8syRmwjwqGHNNUS?=
 =?us-ascii?Q?+JOqGxr4CHuKBSEJ97+xhX0xl9j90DJr6tcvm9kxhO01UOgI3nFuQoNCQnj9?=
 =?us-ascii?Q?HPLK5a8fA6+nr0Ib/h+mJYK2uSuOkQZUhz+A1lXmKqYJygksFXTP1xIaGsh+?=
 =?us-ascii?Q?Mve+kcGicwouJ0+0t3Bsw2u/VEJtoIvhh0ny9sdq7mjA0jTa64BRWanDmToM?=
 =?us-ascii?Q?owOuH6w1SryRI3k/R0yk+lxn+PjCjHG+UpvxIKetXYeHnkUYvmAOj4dM3mvX?=
 =?us-ascii?Q?2LrTaOW2gpYRT3DHrL4N5eshuQodoTDAdk2OLbLqZqq8tkoIfI/Os/3X1o7x?=
 =?us-ascii?Q?4wxygYtRgb5C36RojqpF2HICCfdhYYjbF+0/dvn86oaAx6Myf7Ji2wi6PBg4?=
 =?us-ascii?Q?p5OOuAWVIvtiQJqo4jQk9i/QNmn4ng8Egsq4CxXZqPbykGJlv3HGMs61G/oL?=
 =?us-ascii?Q?/Lqy14AqMJwzZsXias+kLmc59xpx7M1ih3f7vrrMIDofeqFvKtgDBN9cWAfW?=
 =?us-ascii?Q?84knfrHa+FPARYmFMQtbUJURejz8zOpW6FQs0RovEMTk1aVEo2xAWRQSo1xd?=
 =?us-ascii?Q?qCk19/t0EULq4hN/sMeQmAR5q3d0DKvF8g3FkCjy0xPckzTQSoyF1X/QpJz3?=
 =?us-ascii?Q?rjxiiqgsiAwnSo+36GgPZd1RbgADojUFDwMfFhJPaVZIW5ex0a7fQpm+WgCe?=
 =?us-ascii?Q?4W8INWSo2mfm2V+PquVOse2QvvokEoxHKMGZqL3xAtkWgTtm/U+lMnTgsA7o?=
 =?us-ascii?Q?5rXM4PaHHXfk+wkGs0MRiUyETnJbCNZMiD3QroPGdKpjCJpfJ9wwD9JR0vA1?=
 =?us-ascii?Q?WZp8CwK56djC8duWDNXveiNQprcbf7Y91mWYEJ4Jwqe5R24jczTX+lUY+7oJ?=
 =?us-ascii?Q?nf1gChkg2Ss2+Nqd3ppqiNpofvNJBCJHdGkjfkI+bhSKfyZuqXTAOWWNpr5o?=
 =?us-ascii?Q?StHsxKUQCZ1VB+XyqYDl9XFvjWplPkQXum7XhHxXjH1oRfyoIJfdH2QxO119?=
 =?us-ascii?Q?O272lMuA7S0S6AZTk6SqaH3mVWY/6ok8uvtRFnyhB4q46sdAnRVfBfR1Ylt+?=
 =?us-ascii?Q?07CljujFqG1zZJntf/wJ48zO0Og4P6R/K4on5ldkkqQ7uVaN+SeLy2BmSM0d?=
 =?us-ascii?Q?XxhNB2mlLAAG8euSa/s=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ab062d2-4c81-4ede-d031-08dbf7cad60e
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2023 08:51:14.9533
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5/x0VQ3FXSnk/BU4j9tj1Mh8Ak0Oh14wmfMHKDuToNe6DIOwLwPq65Tpq5MnaWxYwOfg/bQgf+Ok6tvdUeK3CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR18MB5770
X-Proofpoint-GUID: J38dzf2uVHBLBoFlf0Pp92xXK3OvfC1P
X-Proofpoint-ORIG-GUID: J38dzf2uVHBLBoFlf0Pp92xXK3OvfC1P
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-08_04,2023-12-07_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 08 Dec 2023 00:53:47 -0800 (PST)

>In the error handling of 'offset > adapter->ring_size', the tx_ring-
>>tx_buffer allocated by kzalloc should be freed, instead of 'goto
>failed' instantly.
>
>Fixes: a6a5325239c2 ("atl1e: Atheros L1E Gigabit Ethernet driver")
>Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
>---
Reviewed-by: Suman Ghosh <sumang@marvell.com>
>
>Changelog:
>
>v2: Setting tx_ring->tx_buffer to NULL after free.