Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>
CC:     "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 4/6] iommu/vt-d: Remove 1:1 mappings from identity
 domain
Thread-Topic: [PATCH v2 4/6] iommu/vt-d: Remove 1:1 mappings from identity
 domain
Thread-Index: AQHaJxojfGMimdGl20KFwsu2wXzMo7CfGuwg
Date:   Fri, 8 Dec 2023 09:09:04 +0000
Message-ID: <BN9PR11MB52761FF9AB496B422596DDDF8C8AA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231205012203.244584-1-baolu.lu@linux.intel.com>
 <20231205012203.244584-5-baolu.lu@linux.intel.com>
In-Reply-To: <20231205012203.244584-5-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q7wVIQzR/52KOO/q3eVd/7Kk405+A3yyxHTlwDqJWDX4xvnoOXyQkyuhLFdT?=
 =?us-ascii?Q?6J+S6rxlwQm/U1lMiHC0HSdkzSrFSXMp98reyTlxP5ACsjjESGIyRbSHhoGx?=
 =?us-ascii?Q?rfC09GUainW9oh96Hrz/qKGsu7RYUu3Derxu3TgJsR/JP+L8FIiFq4Bz3rVL?=
 =?us-ascii?Q?mVt0FsDiJMeAX3XlXAWcOamBiDQUAOAZLfYDmXeATcso2Ep9ZnzHtHUTJl9D?=
 =?us-ascii?Q?J1b/DXh6GElgmXMNuzmTvOsf3EYgZZ+izWT6YuNeAlZRuZgt1iJnYPqgdPqt?=
 =?us-ascii?Q?nNKWwKSX98F71QyItk/J4qqCf0SRJiN47SN830nCmG74OWwdGB2rPU1bIcnt?=
 =?us-ascii?Q?sCyKxLwoJhps0BJnx8aLFgTp30NaJDeoMsXrO6P5f9PSDCwEzwlQxGDftW9c?=
 =?us-ascii?Q?0csH2wsPwgMMYW5pzVCXz+n6cBM9Ovr8+fTsOMc4gfZ3eoZbAu5U9WS+CT1a?=
 =?us-ascii?Q?E6XSsqPckmgfLbmhnB7pK7cDvcNrDlRDgl6r91zo+kTsAxyO3SlHZzxRlx3g?=
 =?us-ascii?Q?obwJidjihuMp5bcBINc9YZWjTmRPQ/EZN0SgA3e5r6e33uK36jzr/srUIHfx?=
 =?us-ascii?Q?yMC7eWU9POBpbs15vQ8t5Xct6/+d5wSMB0CrIKWlyuQdOCIGqPj+Byh9Y6Pv?=
 =?us-ascii?Q?kADddqYsLhadav5f6net6caG0xeM1avWaCiwALaVtpxbOj3L7Gmyy95Z7wjH?=
 =?us-ascii?Q?ZQvuiblHe2chgXerbeNBX8Nb9tlssVg7zIOHVOm2K+UyCu1Nh4S1a03zAjst?=
 =?us-ascii?Q?4Qeq/9LviNQNgvxOY4oSx7KpLZF3y2oE2RNkF8+ffEzbcBNWdKlpCnnWGNdK?=
 =?us-ascii?Q?5eqyryZa90imMjMJrwJp3opb4OQtd9eRAlj8iiNV9ETjsFZLIBxjYD1so1sX?=
 =?us-ascii?Q?Rh2cpwM9Vv7S9/55MSLD5L6vWiJqMxOlYr7InIGA8se7kVLfZli2uTmG7XEQ?=
 =?us-ascii?Q?vvBKRASzY/sDzEI1GlFSoJkukyOliUg9zEE525KKQiAyw7+U8hcVgIozzhHz?=
 =?us-ascii?Q?FhnNghp3yDEZHFuZuD8+pU8MbXoqEQ+jX7AE6Tyg2K1URgmEs47ugiaHXi0c?=
 =?us-ascii?Q?sGQmKqq/Yj0OpuGu1MFZ6awVhA5FrSseK2QTZMHzEyW/8XBZw+36IGIvBmMN?=
 =?us-ascii?Q?I1cZ/AFHiRK7cZVBDpIlsqA8MrQG0xm+dhUuEC304cxTZ9OqQbIODWPSCENz?=
 =?us-ascii?Q?CvSzdQ4xZniYQsTpDAshDtkLhvDyR4rpgU0jiIEx7HRgiBY3a+kUkSsm2/Ls?=
 =?us-ascii?Q?zWwUkEQ0RU+RleLX3H0uJIS7MK3HyFo0+mPmhgFiaaK0P3jQEjQQRrvt5vZG?=
 =?us-ascii?Q?1BDkW4xKGsQgbVPCetnMyyYf7bqywAUaPYapjL9U42AfrR596lMigt4YZTec?=
 =?us-ascii?Q?5o6IKvIvOVO6gLlZHTGCC1fRo4PfHUAqDDTBTkYxU1+G8zvCn4TMO+SSal5m?=
 =?us-ascii?Q?XKBYmQ/6EHGj8pyh9w0ouZ4hnmt19k5Ud5nTT4I8WHdZlVdWtwuJBrcOH7xL?=
 =?us-ascii?Q?UrzA4Gb2AnFq46YWigCZ6VdFohf1/vlFJpRbwpRATfgktvA00iELSSlzpBtS?=
 =?us-ascii?Q?gwJ1nXRxSO1rRNm3BC+0zghCiG7k8Ps1wfg25naL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ddeeb12f-31bc-45ad-5e07-08dbf7cd538f
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2023 09:09:04.5229
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kIz8Fp+DKNElzOz/R9L/IeFW+bRUaUBvz2cp2YSjV+udAD1EiRJJzmUCL9mbml0nIrJk2vTcpXQYOEYJnF6v/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7444
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 08 Dec 2023 01:09:18 -0800 (PST)

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, December 5, 2023 9:22 AM
>=20
> Older VT-d hardware implementations did not support pass-through
> translation mode. The iommu driver relied on a DMA domain with all
> physical memory addresses identically mapped to the same IOVA to
> simulate pass-through translation.
>=20
> This workaround is no longer necessary due to the evolution of iommu
> core. The core has introduced def_domain_type op, allowing the iommu
> driver to specify its capabilities. Additionally, the identity domain
> has become a static system domain with "never fail" attach semantics.

I'm not sure above explains the reason for removing the identity support
on older hardware. Looks the reason is simply that continuing to maintain
that debt prevents intel-iommu driver from catching up  with iommu core
evolution so we decide to remove it.

>=20
> Eliminate support for the 1:1 mapping domain on older hardware and
> removes the unused code that created the 1:1 page table. This paves a
> way for the implementation of a global static identity domain.

Do you know how old such hardware is?

> @@ -2311,6 +2257,13 @@ static int device_def_domain_type(struct device
> *dev)
>  			return IOMMU_DOMAIN_IDENTITY;
>  	}
>=20
> +	/*
> +	 * Hardware does not support the passthrough translation mode.
> +	 * Always use a dynamaic mapping domain.
> +	 */
> +	if (!ecap_pass_through(iommu->ecap))
> +		return IOMMU_DOMAIN_DMA;
> +
>  	return 0;

there are two cases above which mandates IDENTITY. Have you confirmed
that those platforms support hardware passthrough? otherwise this change
is broken.