Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2220450rdb; Fri, 8 Dec 2023 01:36:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYjzYa0WDIG0Xhqftf2RgXvEeqdKlUVMEquv/9NVo168tRxVxPhBdSofOIni4gNjJOyJ6c X-Received: by 2002:a05:6870:3307:b0:1fb:75b:999d with SMTP id x7-20020a056870330700b001fb075b999dmr4339519oae.76.1702028201351; Fri, 08 Dec 2023 01:36:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702028201; cv=none; d=google.com; s=arc-20160816; b=f0amGTdESLWLYwzjfKF/PT1VHQNmVgCrusKpNVtBWxmLIQPr1gDY0QvkqesUNboVZ1 ttRHCkTGF9I0iyEXRuXiWwcc7EzS2rgdGnZLWTvH/ppWgKv0WdCmKy82/ppEOPBGqYGU 0ivmYfgPq6bea9WwelV3mEVIf8RNAaorI/IX/VQpAMVXcYa7PWVqPHaY2cnWMDqnoS43 AC5lBd70kfvU+uJuTqzvR4qs+jkwcj02vIzxBveqhpy/lKqfFuiyqywrJnJ52T+lG3fU qkYehiFmWSHg3DXkTeDGzc3t5CDE0VMao8qNP9lwWWhtyd3wqsoQ0oD0bHAB9ZoLnENp V0bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=TupwBfRwDiy+voqaIr9TRUp3WQzTjmw6wm6xkD3HOBs=; fh=puje6nc7R7eTJyvahHt5dDu3jRaQ5SzLZwdz+RjK6pE=; b=j005L71x2WR5FhgZyzKqEa619zaes/eWTtgFub3Ju07jzIfoWQ+x5sjxcxpsFtKdQ0 9Qr61q5NM79SiAn1UHu/vXIle9ABMqXtld/qUNK68tdnZwMm8Rkv2cyBxec+6ifJ8e7Z sysNIuj6jkFgwA0VjmLL+y4uBbRLXV1Vk72UXsAYjDsUlVR/QSHPqTMM53jZAnCZ2vtU Hd4JFpllEsF8TW+f9fhSrBUJZGR9Lxcq2kfnGJHcGWxbl5WEmS715aAxwaEbrx8mEvyE ou6ySXMEddbdqwEk1kNvRPTAker+HMDREewr7IFnc40POPv+1Ej+lr2NhoRN5WGWfEoV laag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qGGib1la; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id v29-20020a63481d000000b005bde6fae09asi1220537pga.135.2023.12.08.01.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 01:36:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qGGib1la; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 60E36817C893; Fri, 8 Dec 2023 01:36:39 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573445AbjLHJgU (ORCPT + 99 others); Fri, 8 Dec 2023 04:36:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235826AbjLHJgS (ORCPT ); Fri, 8 Dec 2023 04:36:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F974171F for ; Fri, 8 Dec 2023 01:36:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E32B3C433C7; Fri, 8 Dec 2023 09:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702028184; bh=2CP+g0JFWDQiXDkdMQf10ayFgPRTjEJo99EqpGJ8aOk=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=qGGib1lagyidxAtZKdJT5zotbna+a0mat76lxP/Bh9bceaO81OJbA93b9DXkUgsXh lk8R7EENn2x8Ue3sBwDwUEE48g2azhiJMI5REeDUYOzcdCEPyl62naOz/J6o7MT8yi c3Dgvi1M6cB6DJOPl8DMWZ1Fk/HJshGl4vqfGCx6L1lrISTT/BvCr+pBpdLii2AWAK ObS+PJiKulS5b+nxAfXqJpScGIE169Bh0OhExwdgev1q1fCxWlD3BMgi0yVeN6oDhB 0y5E1Kozo1vXkaTmOzk6JjJkYtFhVIJUM1d4GFRYy1oXz2J3mIL92tapptGYB8noSY UA49V64VxheHA== From: Maxime Ripard To: Donald Robson , Dan Carpenter Cc: Frank Binns , Matt Coster , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Sarah Walker , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: <13f4278e-af9c-4092-9196-bc0e6b76f1eb@moroto.mountain> References: <13f4278e-af9c-4092-9196-bc0e6b76f1eb@moroto.mountain> Subject: Re: (subset) [PATCH] drm/imagination: Move dereference after NULL check in pvr_mmu_backing_page_init() Message-Id: <170202818166.16687.13249105887832691264.b4-ty@kernel.org> Date: Fri, 08 Dec 2023 10:36:21 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 08 Dec 2023 01:36:39 -0800 (PST) On Wed, 06 Dec 2023 17:37:24 +0300, Dan Carpenter wrote: > This code dereferences "page->pvr_dev" and then checked for NULL on the > next line. Re-order it to avoid a potential NULL pointer dereference. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime