Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2232037rdb; Fri, 8 Dec 2023 02:04:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAiJ//EZX6iAbg6alqiVH//DCGZfMusNLuCKasuc5tFlhzSEHlZYXi3fKDJ284ZrmJRwrP X-Received: by 2002:a17:902:da91:b0:1d0:6ffe:1e64 with SMTP id j17-20020a170902da9100b001d06ffe1e64mr3831761plx.71.1702029892825; Fri, 08 Dec 2023 02:04:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702029892; cv=none; d=google.com; s=arc-20160816; b=YeRjyVrLLuIerl2SsodMy3TkGbxlTh3QPsdNivuh4iVor+IRsns3ywG1kYeLTkpkBC m0nLAMP0NTVPth8inRgSNuOEv/YXl3p68Q+r0+n9ttlx98pSAepiCxSaJEs8CqdvmEPB 2Ys+qYk9A/iyYfUmHG1cnPeyIgt+Ovf8+t07BS5qLgdMOoW1lD5/H5Bazp+czvGFUjGo 8Ze7J6WvZpw8HaJg+d5Ty+uAr682PCqUolUk3VFAVhwTW/dviu4XUOtk6s0O46USlj8P A541xMPrz6QVnP5sTPN8xsLszSRG/UDLBV4h0wPBHnmazj8L3zt2Qe/e8Qf+y2MhxwFh efCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id; bh=vxkEayQKWvqvvV5BS2y7dgr3RtOHHrAV7tr1SLwCKOU=; fh=siXXS4fiKM+UN3XvISWlFHzUucsvWdSox+YvKT1j0bs=; b=IHJHg3lOnTVXPZwXB9MKH7OxjQz/nlfOjDrxot8EGaKUpnlFvVG8AampUBev2LeRuP iJmze6itF87hRhHxcrNPYU1uO3YRuEH6Ly22qiNQipP0Um7MvP2XfSH5SsNN/biXUafS VJ4awq0iO144hsEtRyltMVbTZMzTxMtSv4rFRjvIBloLi0ZNoabzJK6nwe/nXnUNczkE ore/Me+pt70a3urD+9kE0Db95WyWVnu2WNo/0nAXX+qY4ZKq4CSLvJx8ct94pAFadckS YmzUJEVKKu12u53w63YovNCaDuYNmbwiHib+vv/vpodjQw1nuUCvIGgIX/o7dUo8XC3S 7wug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id q7-20020a17090311c700b001d0c783e5a3si1381838plh.244.2023.12.08.02.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 02:04:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B448580BBC7E; Fri, 8 Dec 2023 02:04:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573474AbjLHKEi (ORCPT + 99 others); Fri, 8 Dec 2023 05:04:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbjLHKEd (ORCPT ); Fri, 8 Dec 2023 05:04:33 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 82BDF1720; Fri, 8 Dec 2023 02:04:39 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C69E11FB; Fri, 8 Dec 2023 02:05:24 -0800 (PST) Received: from [10.57.82.108] (unknown [10.57.82.108]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C8D203F762; Fri, 8 Dec 2023 02:04:36 -0800 (PST) Message-ID: Date: Fri, 8 Dec 2023 10:05:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] sched/fair: Be less aggressive in calling cpufreq_update_util() To: Qais Yousef Cc: linux-kernel@vger.kernel.org, Vincent Guittot , Viresh Kumar , "Rafael J. Wysocki" , Dietmar Eggemann , linux-pm@vger.kernel.org, Ingo Molnar , Wei Wang , Rick Yiu , Chung-Kai Mei , Hongyan Xia , Peter Zijlstra References: <20231208015242.385103-1-qyousef@layalina.io> <20231208015242.385103-2-qyousef@layalina.io> Content-Language: en-US From: Lukasz Luba In-Reply-To: <20231208015242.385103-2-qyousef@layalina.io> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 08 Dec 2023 02:04:51 -0800 (PST) Hi Qais, On 12/8/23 01:52, Qais Yousef wrote: [snip] > @@ -6704,14 +6677,6 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags) > */ > util_est_enqueue(&rq->cfs, p); > > - /* > - * If in_iowait is set, the code below may not trigger any cpufreq > - * utilization updates, so do it here explicitly with the IOWAIT flag > - * passed. > - */ > - if (p->in_iowait) > - cpufreq_update_util(rq, SCHED_CPUFREQ_IOWAIT); > - Why this io wait boost is considered as the $subject says 'aggressive' calling? Regards, Lukasz