Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
MIME-Version: 1.0
Date:   Fri, 08 Dec 2023 12:25:07 +0100
From:   =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <zajec5@gmail.com>,
        linux-mtd@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        =?UTF-8?Q?Ar=C4=B1n=C3=A7_=C3=9CNAL?= <arinc.unal@arinc9.com>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Scott Branden <scott.branden@broadcom.com>
Subject: Re: [PATCH V3] nvmem: brcm_nvram: store a copy of NVRAM content
In-Reply-To: <29d2f463-90c2-4c96-8828-96806679db8e@linaro.org>
References: <20231102062848.23965-1-zajec5@gmail.com>
 <29d2f463-90c2-4c96-8828-96806679db8e@linaro.org>
User-Agent: Roundcube Webmail/1.4.15
Message-ID: <7cb70a8ead5f6b74f0a287ac8832873c@milecki.pl>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023-12-08 12:15, Srinivas Kandagatla wrote:
> Thank you for the patch,
> 
> On 02/11/2023 06:28, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>> 
>> This driver uses MMIO access for reading NVRAM from a flash device.
>> Underneath there is a flash controller that reads data and provides
>> mapping window.
>> 
>> Using MMIO interface affects controller configuration and may break 
>> real
>> controller driver. It was reported by multiple users of devices with
>> NVRAM stored on NAND.
>> 
>> Modify driver to read & cache NVRAM content during init and use that
>> copy to provide NVMEM data when requested. On NAND flashes due to 
>> their
>> alignment NVRAM partitions can be quite big (1 MiB and more) while
>> actual NVRAM content stays quite small (usually 16 to 32 KiB). To 
>> avoid
>> allocating so much memory check for actual data length.
>> 
>> Link: 
>> https://lore.kernel.org/linux-mtd/CACna6rwf3_9QVjYcM+847biTX=K0EoWXuXcSMkJO1Vy_5vmVqA@mail.gmail.com/
>> Fixes: 3fef9ed0627a ("nvmem: brcm_nvram: new driver exposing 
>> Broadcom's NVRAM")
> 
> Any reason not to add
> Cc: <Stable@vger.kernel.org>
> ?

Not really. I believe stable team would pick this fix anyway (thanks to
the Fixes:) but doing
Cc: stable@vger.kernel.org
is described as strongly preferred.

Do you think you can just ammend my patch while applying it and add
Cc: stable@vger.kernel.org
to it?

-- 
Rafał Miłecki