Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Fri, 8 Dec 2023 08:52:27 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Aron Silverton <aron.silverton@oracle.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Saeed Mahameed <saeed@kernel.org>,
        David Ahern <dsahern@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Leon Romanovsky <leonro@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>, Leonid Bloch <lbloch@nvidia.com>,
        Itay Avraham <itayavr@nvidia.com>,
        linux-kernel@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH V3 2/5] misc: mlx5ctl: Add mlx5ctl misc driver
Message-ID: <20231208125227.GO2692119@nvidia.com>
References: <ZWZJGF7moDM_k6TU@x130>
 <2023112922-lyricist-unclip-8e78@gregkh>
 <oxtcvxwbj2hzv4lxnxubo3hoxn7diyzhm2oj3tsw2toxbc3og4@ddglhm6r3oa5>
 <20231204185210.030a72ca@kernel.org>
 <fgalnohzpiox7rvsf3wsurkf2x3rdtyhwqq5tk43gesvjlw6yl@i7colkh2sx5h>
 <20231205204855.52fa5cc1@kernel.org>
 <kakenvblxlgrkjvcrwfflnkm6n5fpxgr4qifwkdttjascth3te@57us7mblobjz>
 <20231207092329.3ec04dca@kernel.org>
 <uedlocmp2guvvhgxe2cjrjog3qf6pd7puj7idpygxxpjrnnj2p@nqmg66juf6xm>
 <2023120857-calculus-concerned-cef0@gregkh>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023120857-calculus-concerned-cef0@gregkh>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LvJjzjA381o9DdNnXcmiO8GHrj9+c6yA7dYu0B/1nMTP3nVBZTrR1Q9dFVEN?=
 =?us-ascii?Q?kangAuUuxAdrkz05NHJQwD1Tl/YWjxLoQjwDw9X46ec1zJ9L6mJkkmuoKoXe?=
 =?us-ascii?Q?u3PQhnp5nzMgl+u9IoMU92Ef+ewoz3T6IIzMDIOq+5XEWjvWr/h9h+Ofg3y3?=
 =?us-ascii?Q?h4bQewwvjdnkJHV/w7Izqvsm8tGIZsMN26O3I+u4YGgUH4valrH8KzVHrJPz?=
 =?us-ascii?Q?c7e4Ap8TYAXIj2cbEHnYJ0gqT0ks5CgtBTEb0dOhqqNqW0Ib9xOJwSAawK3X?=
 =?us-ascii?Q?L5CTLhwjytIjYNHT8MTAegI8cpqSMliMH+fjAWBryMvn5zEqMh309Q8fA8h7?=
 =?us-ascii?Q?VQc+sg9V0dMUNTGyrrnaVOTDeF1tFq97uZFeT9Vtua05PCJZUD/EOzWqHsN8?=
 =?us-ascii?Q?tj3EhX66gGoSWqb7jS7URu3QTOUzB1W+GFb3wfKwbOmjF0yQKpvq1lp99L3L?=
 =?us-ascii?Q?ZDUjVtn4y+W2cwsxm5zs3Ys28CJEU70Hm389ww4lMbRC+j7hcf5ieTQ7EFzo?=
 =?us-ascii?Q?jVtCioV+Z0kEmxkUBtFZhumJivRsM/FmDeRDGObt/btJVA+RlwjjyQusUxiC?=
 =?us-ascii?Q?9tO822ZYiT9xnik1A5C3KI5AuHZ6OR20ehHAGYjPZDyFFzCJ7OHU1dre/GFG?=
 =?us-ascii?Q?U1ddPD+l6a+2f1tr4xw1YiKbOI16j0VnutzOU4LffxSImoYS0Tffbnnf1lWd?=
 =?us-ascii?Q?xYx8RdRsCUJt3wwVjBMqKxBqjbX/F4n1BNWwoqx6VotfDNO+NdeF8CEIBxaR?=
 =?us-ascii?Q?j9vrY2nNlGZyNE2yM9cJ894GjR25T27OGlFwIh31GEGV/sAohaOb8K5VYR6P?=
 =?us-ascii?Q?nQjH0O+bnXjIzwrzMm9CGT8c+xDetxtwP8NiMVIFaOIVBqPSf2kTt97pL0KS?=
 =?us-ascii?Q?+P7itPjOnFGLMg5SpIhioHnZo9EnyTfcSa7GBWEJ9jtAoSugVSG9gihsJBvH?=
 =?us-ascii?Q?EqT3M6xt1cMuGyACdHQ2SSj29tIq21AtIWhYBiW6ykRMmIh9gDjVntpa6Tx0?=
 =?us-ascii?Q?CB33pCFb+z6lpfM4t4XzUoEni+ZnsCDipp5RC+4spw4RR6suQ88axdVYfhy3?=
 =?us-ascii?Q?VCl1nwksbR0TmMLzhSG60Yb8Q6I5oP1tHHI/RxRKenOz2lYbxxqs50E7C5QR?=
 =?us-ascii?Q?5xVnv5HUMTHhv/EZf7isJrTQe5wRXP3Zsi42KxKnDek6T1I8zrg8FsXKneO2?=
 =?us-ascii?Q?g6uw2smQbHb9V7aWx9zxSeEKlBYahGksamrCE9QaNrbTpyzVkVt1eIZWoWlC?=
 =?us-ascii?Q?YLZ5w4ZSnvpuzobygRWqSjDo/fcE53fVpnAicV1O59Wd1D947X8q4G5f3/33?=
 =?us-ascii?Q?AsCAioOo4Okg9DmThq0z24d8Qo8PjjjvhDi9eXhhuulUTDETo1TObqvHWf0Q?=
 =?us-ascii?Q?UkN8ddJNJRgsBdOZicVPyGZ4xY7glZwe2D/KeXJakB4H6epTXVLKmPBxPzYG?=
 =?us-ascii?Q?C8gFTRVs66HFbmAw2e7Au46qW/sIpCV7+D+wvbeFJVrDNzDamZTnvKf13WNc?=
 =?us-ascii?Q?frDKL0lz55ZNbc0/l6XP048HkcoK4t6KQk68KJ5AwD2i1rUdL0aaSGLQmoFn?=
 =?us-ascii?Q?DhCW/yr3OMPR1WSThyPt88/60Sdk36z5xnsXWX7g?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37ee2b8b-472f-4dbb-f01b-08dbf7ec892f
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 12:52:29.0730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PyO7wup2XYe/zFpHlApyU/sd26boc4ExyINYEP2fl9w7Vmo2GWyvYLCQx1cUIkuc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6983
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 08 Dec 2023 04:52:41 -0800 (PST)

On Fri, Dec 08, 2023 at 06:27:14AM +0100, Greg Kroah-Hartman wrote:

> When they do that, they break the reason why the distro/vendor decided
> to prevent access to debugfs in the first place, making the whole system
> insecure again!

Maybe others have, be we did not!

In fact Saeed addresses this explicitly in the cover letter:

 Historically a userspace program was used that accessed the PCI register
 and config space directly through /sys/bus/pci/.../XXX and could operate
 these debugging interfaces in parallel with the running driver.
 This approach is incompatible with secure boot and kernel lockdown so this
 driver provides a secure and restricted interface to that.

We did a lot of work here to build an interface that is compatible
with the security principles of lockdown. This work is embodied by the
new FW bit MLX5_UCTX_OBJECT_CAP_TOOLS_RESOURCES which causes the FW to
run these RPCs in a security context that is compatible with lockdown.

The overall philosophical architecture is similar to the NVMe vendor
command channel which is also a way to deliver opaque RPCs to a device
FW and is considered lockdown compatible.

This series is not some insecure attempt to bypass lockdown like you
may have seen in Android. mlx5 is the driver for the most popular high
speed NIC in the world. Our customers take security seriously, and we
take security seriously.

Jason