Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2314610rdb; Fri, 8 Dec 2023 04:57:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEo12CyGGpG+cjP5kuhNFlLkl7g+aYYcaB4CuA3ubVdH6+PUmpzuNOCDKQwYt9FYZZODujX X-Received: by 2002:a92:d150:0:b0:35d:6220:ac8b with SMTP id t16-20020a92d150000000b0035d6220ac8bmr43434ilg.58.1702040227584; Fri, 08 Dec 2023 04:57:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702040227; cv=none; d=google.com; s=arc-20160816; b=FR8ScBA9Y/zr7RK4P7tloa+IK81TofCnRZyPaAGfunqAD46eMtRT1LMAJiHgtzCQYw mLoU3PBnS8YNvmIQt4Wo9OCpkusn9Yw5oL8E/6Y3Vp4ZeRZRJs++//SNKhRzPfxSIbTA DZa+OxytY34oXvF7VmUF2WwrhEQ1pI3aW0DpVAAfuUgb5v59xMVnFZrgBWIymRRITA4X FFBfzWtCwKl6MJ+ctov/oILuSwtgZoWBTnaSVtnZElshiE+ialVqzkQJ0jHYuHP9MRGd QlaG+ooe7tGupPGx3ziuZA5uO4O0+DsnFk+Bs/fNmUVgvosSdEiTyJEA2V4dyUTn51Q5 4OSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QHVMTc7JbOKWQiyE5WnJ1KZVYPGhcddzOdce2g60rHk=; fh=8WK2MfeiYGTN8gN5k2Q88iqRdqfcoS3bVf7Cn7ZMyGA=; b=tktnDOPOj3UiMpOhS/8KF0tTINEi6PxJgPMS6Z5lEvKKpjseH0+gePUSuWvyVtGF2r ADRT8zlp/K94DNfjyBVcvLeiXgd1ATDd51nzXbuEFdcOQfwiJlLMvB9Cky8aPWFpFoHp /N4Ztq9x8vCl8ud5BPXbtd8Y2YCof9lL/tU3/9P/zaInYhKmQTRpS7OXHePM15WXonnh Ma5eoroQgeOVjdvLgqbZMd90OjxWC4oImZKCe5NwBXq8JZVFPLtKzLubCh/0Wr9kPUef UhO6JIFXWSpFNb40sm3B4I38yXNYMxvZeNpAo3hd3jGYr762tuvJFRev5tC9i8wcKwPU JMDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BGURX3Ck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id c9-20020a63da09000000b005c6b4e190b3si1473048pgh.109.2023.12.08.04.57.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 04:57:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BGURX3Ck; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 162458379A62; Fri, 8 Dec 2023 04:57:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232504AbjLHM4v (ORCPT + 99 others); Fri, 8 Dec 2023 07:56:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbjLHM4v (ORCPT ); Fri, 8 Dec 2023 07:56:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93F1410FC for ; Fri, 8 Dec 2023 04:56:57 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3053AC433C7; Fri, 8 Dec 2023 12:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702040217; bh=OSuX71e1jZxpO9PhB7QCT9A4hWvPxJ7NxD/Rhqsq+SI=; h=From:To:Cc:Subject:Date:From; b=BGURX3CkaHSVViOG1V5VQDRQ5+esvsuA8SRZodR/7mOYi2OmZY0YTIIig2EWe/08v v3E1n4bWGqpOHyGi+5jzU6i0m8N4hrKNGX8/jgWPEa4q29TEe55s8Af8NLKvRDtRl6 IuMR2bB3F4SBgvhR2Blk++JH+Fb3W+lZTx5IJ6yyEGeYqJmsoJqfXVq5eICwi6k4vG pzC1qMsDRT+WibmV/PD/CXvAXQwbGsCpEL6yZCBgZDimbODte05HFFP7mdLr9a2vl7 KwhTMc3b6xr1XVFMZYfcKGYgexXgGXNwj/hoORjPg4L+JNDDXutQVx0SMl+7q5dkFN iW8SpZ/UMaNkA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rBaQM-0002gi-2N; Fri, 08 Dec 2023 13:57:47 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] soc: qcom: pmic_glink: disable UCSI on sc8280xp Date: Fri, 8 Dec 2023 13:57:30 +0100 Message-ID: <20231208125730.10323-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 08 Dec 2023 04:57:05 -0800 (PST) Enabling UCSI on sc8280xp and the Lenovo ThinkPad X13s in particular results in a number of errors and timeouts during boot: [ 9.012421] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-95) [ 14.047379] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response [ 14.050708] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) [ 20.192382] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: timeout waiting for UCSI sync write response [ 20.192542] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: GET_CONNECTOR_STATUS failed (-110) Disable UCSI on sc8280xp until this has been resolved. Fixes: 4db09e7b967b ("soc: qcom: pmic_glink: enable UCSI by default) Link: https://lore.kernel.org/r/ZXL5jvDHr-MuxMoz@hovoldconsulting.com Signed-off-by: Johan Hovold --- drivers/soc/qcom/pmic_glink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index 71d8901a9389..511aa40842a1 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -342,6 +342,7 @@ static const unsigned long pmic_glink_sm8450_client_mask = BIT(PMIC_GLINK_CLIENT static const struct of_device_id pmic_glink_of_match[] = { { .compatible = "qcom,sc8180x-pmic-glink", .data = &pmic_glink_sc8180x_client_mask }, + { .compatible = "qcom,sc8280xp-pmic-glink", .data = &pmic_glink_sc8180x_client_mask }, { .compatible = "qcom,pmic-glink", .data = &pmic_glink_sm8450_client_mask }, {} }; -- 2.41.0