Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Fri, 8 Dec 2023 14:19:48 +0100
From:   Alexander Gordeev <agordeev@linux.ibm.com>
To:     "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc:     gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>, linux-s390@vger.kernel.org
Subject: Re: [PATCH 09/27] tty: con3270: convert to u8 and size_t
Message-ID: <ZXMX9AmWwR6hPSMr@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
References: <20231206073712.17776-1-jirislaby@kernel.org>
 <20231206073712.17776-10-jirislaby@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231206073712.17776-10-jirislaby@kernel.org>
Precedence: bulk

On Wed, Dec 06, 2023 at 08:36:54AM +0100, Jiri Slaby (SUSE) wrote:
> Switch character types to u8 and sizes to size_t. To conform to
> characters/sizes in the rest of the tty layer.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: linux-s390@vger.kernel.org
> ---
>  drivers/s390/char/con3270.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c
> index 363315fa1666..251d2a1c3eef 100644
> --- a/drivers/s390/char/con3270.c
> +++ b/drivers/s390/char/con3270.c
> @@ -54,7 +54,7 @@ struct tty3270_attribute {
>  };
>  
>  struct tty3270_cell {
> -	unsigned char character;
> +	u8 character;
>  	struct tty3270_attribute attributes;
>  };
>  
> @@ -123,7 +123,7 @@ struct tty3270 {
>  
>  	/* Character array for put_char/flush_chars. */
>  	unsigned int char_count;
> -	char char_buf[TTY3270_CHAR_BUF_SIZE];
> +	u8 char_buf[TTY3270_CHAR_BUF_SIZE];
>  };
>  
>  /* tty3270->update_flags. See tty3270_update for details. */
> @@ -1255,7 +1255,7 @@ static unsigned int tty3270_write_room(struct tty_struct *tty)
>   * Insert character into the screen at the current position with the
>   * current color and highlight. This function does NOT do cursor movement.
>   */
> -static void tty3270_put_character(struct tty3270 *tp, char ch)
> +static void tty3270_put_character(struct tty3270 *tp, u8 ch)
>  {
>  	struct tty3270_line *line;
>  	struct tty3270_cell *cell;
> @@ -1561,7 +1561,7 @@ static void tty3270_goto_xy(struct tty3270 *tp, int cx, int cy)
>   *  Pn is a numeric parameter, a string of zero or more decimal digits.
>   *  Ps is a selective parameter.
>   */
> -static void tty3270_escape_sequence(struct tty3270 *tp, char ch)
> +static void tty3270_escape_sequence(struct tty3270 *tp, u8 ch)
>  {
>  	enum { ES_NORMAL, ES_ESC, ES_SQUARE, ES_PAREN, ES_GETPARS };
>  
> @@ -1726,7 +1726,7 @@ static void tty3270_escape_sequence(struct tty3270 *tp, char ch)
>   * String write routine for 3270 ttys
>   */
>  static void tty3270_do_write(struct tty3270 *tp, struct tty_struct *tty,
> -			     const unsigned char *buf, int count)
> +			     const u8 *buf, size_t count)
>  {
>  	int i_msg, i;
>  
> @@ -2052,7 +2052,7 @@ con3270_write(struct console *co, const char *str, unsigned int count)
>  {
>  	struct tty3270 *tp = co->data;
>  	unsigned long flags;
> -	char c;
> +	u8 c;
>  
>  	spin_lock_irqsave(&tp->view.lock, flags);
>  	while (count--) {

Acked-by: Alexander Gordeev <agordeev@linux.ibm.com>