Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2345024rdb; Fri, 8 Dec 2023 05:43:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHY9/5ch5N/X4z2okIkmRKlX3SGewr9ugmoke+IpmIo9dmblzw4zch61K4NJUj1AjSb/Qds X-Received: by 2002:a05:6a00:1382:b0:6ce:2731:a083 with SMTP id t2-20020a056a00138200b006ce2731a083mr19100pfg.50.1702043022901; Fri, 08 Dec 2023 05:43:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702043022; cv=none; d=google.com; s=arc-20160816; b=oYXUcopBswKsc1zfrqiVA80PJilCTqTTBBQo2bn6Uoug9y0hAdIkSvSNuFP/3GzgT1 wCbNp8m3rM2l+7brD+aZjLaP1F5/HMWl3E3H6l8B9zOb6pBfAEdB4twQu15wbFqldLHT ODxSIKFlzpTyowjtcTARLjcGPOonA/GUaF02h4SwwvkzvimqV04Ib8MTRsOOg/TPgnxh NbTMki8wEFZSegHEOFnIuhzg3YSgG+N4oSVSvti6cwxy0IB9Q72Gs9hYUbEEITDAHQYE ing+07WEBgWIhycPYXX9vyW79A4MXkL93v6/ihM6e/1pTVy8JUKvPCZ4Xg2gmpPUXsVD K0oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=v41wm5KDGK0BNCPVwtP8xhnbdF1A2BLTbD9AwKGQeP4=; fh=v1AieQ6xn19PAQ8VnNUwelkjh2ysSSLsP24Jxpc5b64=; b=wiwDM0tg9RtuJzmLyA5SN/h7ct5DQD1419JC1rBPCcNVHXKUvJXBfZSufX1HvUTBgE ThEh0u+icvihk4qqs0+Y5SxKFRSxlKW7gbH73k3cX14XXn253Kpvy/7fApWGCE4zz15S m7pg3OFQB2pefqb76MVWMUn4tcx+yxsoh8IxVi48evUJFDTsjltSiB5TnDI47uHAin4M nUWDmzPZg3BavmVN/3Z4dQWmU7oEx7dTyn5qucUCQ+afRzmO2C4mBqHyPN+3HubgkJQS SdGv0nvX7T6HIEULoXB/1gNgWbE+vln9UWHrrcMjpH+YnaZKMBFCxy6Qk9jErFuZFwPG Mn0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cnCFSqoR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id dw26-20020a056a00369a00b006ce54dc2d09si1633509pfb.254.2023.12.08.05.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 05:43:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cnCFSqoR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 718C48116E66; Fri, 8 Dec 2023 05:43:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235890AbjLHNnX (ORCPT + 99 others); Fri, 8 Dec 2023 08:43:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235884AbjLHNnW (ORCPT ); Fri, 8 Dec 2023 08:43:22 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8438172B; Fri, 8 Dec 2023 05:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702043008; x=1733579008; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=dokXxTgyGtPuhjl0x3PnNuEf+Q6HC66XteJbDXhIC2s=; b=cnCFSqoRGvNhWZN1S9ZGBzEANlCOZkHyCGG8meqaOvI6UvSO1Dj1pMtx kSZHOeeUJKTOE6UotGlcXuVm5tl5Ze3d2svX/PUag2Q+dtwMRfsn4MRKQ /t46Pky+Vi0IF9t3+l4u1gnvdBCbGjWknl2Fx+tN54IaguC9pkY3RTEw+ Las7lqTQTt6CQS0JgS+/rVUXWUsnL+tb4sgmK/y7ZHHviOFzaRxoeuZ+4 U7SrQlU/BU4H+INnG+3mMzm3HT24pXWEf4pwpO9ccHJB/dwYRp6rdYLy/ tBWy/3ccJd7VXuPkXStKTIsLoEy9XvRd1NiP8e9wG1YOdifdn1Y9F8USL Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10917"; a="398272108" X-IronPort-AV: E=Sophos;i="6.04,261,1695711600"; d="scan'208";a="398272108" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2023 05:43:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10917"; a="895542733" X-IronPort-AV: E=Sophos;i="6.04,261,1695711600"; d="scan'208";a="895542733" Received: from smatua-mobl.ger.corp.intel.com ([10.251.223.110]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2023 05:43:26 -0800 Date: Fri, 8 Dec 2023 15:43:23 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Armin Wolf cc: Hans de Goede , corbet@lwn.net, Dell.Client.Kernel@dell.com, linux-doc@vger.kernel.org, platform-driver-x86@vger.kernel.org, LKML Subject: Re: [PATCH 4/5] platform/x86: wmi: Remove chardev interface In-Reply-To: <20231207222623.232074-5-W_Armin@gmx.de> Message-ID: <92e2d5f-77cd-30b0-64e5-28f767baf776@linux.intel.com> References: <20231207222623.232074-1-W_Armin@gmx.de> <20231207222623.232074-5-W_Armin@gmx.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1850445610-1702043008=:1875" X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 08 Dec 2023 05:43:40 -0800 (PST) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1850445610-1702043008=:1875 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Thu, 7 Dec 2023, Armin Wolf wrote: > The design of the WMI chardev interface is broken: > - it assumes that WMI drivers are not instantiated twice > - it offers next to no abstractions, the WMI driver gets > a raw byte buffer > - it is only used by a single driver, something which is > unlikely to change > > Since the only user (dell-smbios-wmi) has been migrated > to his own ioctl interface, remove it. > > Signed-off-by: Armin Wolf Reviewed-by: Ilpo J?rvinen -- i. --8323329-1850445610-1702043008=:1875--