Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Max Filippov <jcmvbkbc@gmail.com>, linux-kernel@vger.kernel.org
Cc:     Chris Zankel <chris@zankel.net>, Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH] irqchip/irq-xtensa-pic: clean up
In-Reply-To: <20231205101307.1303186-1-jcmvbkbc@gmail.com>
References: <20231205101307.1303186-1-jcmvbkbc@gmail.com>
Date:   Fri, 08 Dec 2023 14:55:51 +0100
Message-ID: <87r0jwssrc.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Tue, Dec 05 2023 at 02:13, Max Filippov wrote:
> - get rid of the cached_irq_mask variable
> - make mask/unmask operations atomic
> - use BIT() macro instead of bit shifts
> - drop .disable and .enable as they are equivalent to the default
>   implementations
>  static void xtensa_irq_mask(struct irq_data *d)
>  {
> -	cached_irq_mask &= ~(1 << d->hwirq);
> -	xtensa_set_sr(cached_irq_mask, intenable);
> -}
> +	unsigned long flags;
> +	u32 irq_mask;
>  
> -static void xtensa_irq_unmask(struct irq_data *d)
> -{
> -	cached_irq_mask |= 1 << d->hwirq;
> -	xtensa_set_sr(cached_irq_mask, intenable);
> +	local_irq_save(flags);

All of these callbacks are invoked with interrupts disabled already. No
point in disabling them some more.

> +	irq_mask = xtensa_get_sr(intenable);
> +	irq_mask &= ~BIT(d->hwirq);
> +	xtensa_set_sr(irq_mask, intenable);
> +	local_irq_restore(flags);
>  }

Thanks,

        tglx