Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Haoran Liu <liuhaoran14@163.com>, tsbogend@alpha.franken.de
Cc:     fancer.lancer@gmail.com, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, Haoran Liu <liuhaoran14@163.com>
Subject: Re: [PATCH] [irqchip] mips-cpu: Add error handling in
 mips_cpu_register_ipi_domain
In-Reply-To: <20231130040642.36133-1-liuhaoran14@163.com>
References: <20231130040642.36133-1-liuhaoran14@163.com>
Date:   Fri, 08 Dec 2023 15:13:19 +0100
Message-ID: <87o7f0sry8.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, Nov 29 2023 at 20:06, Haoran Liu wrote:

The subject line:

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

> This patch enhances the mips_cpu_register_ipi_domain function in

# git grep 'This patch' Documentation/process/

> drivers/irqchip/irq-mips-cpu.c by adding error handling for the
> kzalloc

The file name is irrelevant. Please read and follow:

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html

> call. Previously, the function lacked proper handling for kzalloc
> failures, which could lead to potential null pointer dereference issues
> under low memory conditions.

The value of this "enhancement" is dubious. if that kzalloc() fails then
any subsequent allocation will fail too and the machine will crash
anyway.