Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <fa3cb4da-fce1-4496-ae5a-78133c4b540d@intel.com>
Date:   Fri, 8 Dec 2023 16:00:59 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 iwl-next] i40e: Use correct buffer size in
 i40e_dbg_command_read
Content-Language: en-US
To:     Kunwu Chan <chentao@kylinos.cn>
CC:     <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <jeffrey.t.kirsher@intel.com>,
        <shannon.nelson@amd.com>, <intel-wired-lan@lists.osuosl.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Simon Horman <horms@kernel.org>,
        Kunwu Chan <kunwu.chan@hotmail.com>
References: <20231208031950.47410-1-chentao@kylinos.cn>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20231208031950.47410-1-chentao@kylinos.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXZpVVlvZ0c4RHEvQnNKMkRuaVZPV3V0MTJBY0NSc0hJR2t4WVN4bU5XTVNo?=
 =?utf-8?B?emxWcHo1c2ZHUEV5ZC9oTHhJSmJUZk15cjg1Qi9PQmxxQzY3L0E5emZ5Y3Bt?=
 =?utf-8?B?bVF4Ymw4dkpzeWdjSnkxYlRwcUl3T2drNVBvYU4zUnRnbHpNNlBMU2ZaZ1Vt?=
 =?utf-8?B?bzFyM01oT1JKcGs3K1RwRExjRWVYYUhROFUzZEJjckxrTmhVaEhPRTd3N0FO?=
 =?utf-8?B?dldQK2VtdlY2YjhUcndJSzU4MjRBSWlkbkxhbER2WURUSVZ3UFp5SXdVVVY5?=
 =?utf-8?B?MTQyZmM4MmJoaFRyRWVBTDZyTWNaNnAvY2l6WlZUb1JVT3R6QTN0cEVWUkZ1?=
 =?utf-8?B?cjQ2RkpmRnRNQ09GQnppTWVFdDVjUzI3cFJsWElEQThRQTErMWFRaHFaczhN?=
 =?utf-8?B?ZnptaWZIZXFqMkVNd1hzSlJwNVpQUkFJbk56YmtvaWtJRlNMOGtTeU1VS3ZC?=
 =?utf-8?B?cXFHa0VRZVVUSG92QXpsVGdOdGZ3SnFBOEJ1MVZBK3dsaFlOdC8vbnpUSEQv?=
 =?utf-8?B?blRDTjg1dFowc3pjV3hsaGJ3dXVrZ0ZCUExOU25WVGdDZjQ3cFBOSGY5cmRQ?=
 =?utf-8?B?eHFWTUl2NHdxUkZ0QkdvUzFpdllyemVyUnBZY3JSYjVzNGpFdERZRENJWlF4?=
 =?utf-8?B?dEZjNjM5d1ZESUMzeUQrZ28xYWdCbWJLeUdIeFpVaU9YRVp6WlRlMnM5Ukts?=
 =?utf-8?B?ZmVSWEF6UG5UTDNobU9pMU1ZOGFvYW1LcGZTZ3hiU0J6RjJ1dWhIZFcrNVVR?=
 =?utf-8?B?MFBQaWFpNFlRWDZVZGhkNE5Md1Fyd1NOU2t0WkhOTVZpMGhnUlUvYW9PN0ZN?=
 =?utf-8?B?YTluajU5NHBjZ0R2b0VXR3RHQnRmYnBHRzA1WlN3TGROTi9vYXhGay9Rd2F1?=
 =?utf-8?B?QjdFMlYxcndyUmZoUUJNQ1Z6d2hrWlZOL2dHTVlMaEI4Y2Rzclk4bG5iNWtZ?=
 =?utf-8?B?blhNRzBGN2VsSlVQQVhublp6aWd4MXVCbHFFVFFLejk5WEJCZkNjTXArNFcx?=
 =?utf-8?B?bGtTVnhaNmdnL1JkV0NwWE1wOURDaVhwWisyRWNtNmRkdGdUUFIvdTFTd0Mx?=
 =?utf-8?B?a2NBYXI2emQ1aVJxWXZjUUx2RUV5Y0dteXYvdGdGVzZKTEY3TzdUSzNGay9E?=
 =?utf-8?B?b2pKQ2h5QndDeVhlWHRnME95OXBJbTU0YUpUemU4bmRTaDRUMjV3SDcvZ0I0?=
 =?utf-8?B?eldDSXhRR0M5ekx6SzZCZjJkb05NU1YyYWh4OUtLS2ZqUjBJWGYrSjVDd0E2?=
 =?utf-8?B?VWxGbDFzVkc0NnFIK0tlcnhSakNqSmw0NDMvQXF5WEFCWFlYYS9hS1hoakE1?=
 =?utf-8?B?aDNoaGpTTzB6ZHZwNUxSMEFhZVNtZFZ6bjNxQzNUb1pPeVA4bzYvSWhGdHRp?=
 =?utf-8?B?L0o1RkViNVBNbmFNQTVQWFFzd3B5ck56cWFKeWRBdmovdTlJd3IzV2ZxQ08x?=
 =?utf-8?B?TzFWZThPSWtvUm4wS0lZYU0wazBGWmtKOUVOVWxpWlpHRDZlbXNlN0ozbENj?=
 =?utf-8?B?U3dzZGF3S2RoaWhxdW9iS3ExbkY5ajNFYm9OeWlQUFRNVVRMZ0RzRjBnOXQw?=
 =?utf-8?B?YmdVNEFjUDZqODZrUkRBRGJUbzhNNDNiYmpkeVUwbHRhMjA2MjF5ZlUzdHNu?=
 =?utf-8?B?ZHZVSXlaS0oxakdiZGdBbm1RTzh4RDZnejJPSkpQSWxHeGpDTmpweGpJOC9H?=
 =?utf-8?B?dDI3N2NYRWMwTXRhalg0UjNSclhlUVlSNVVscWdsOUtucGNqM05IUDlaYmNm?=
 =?utf-8?B?WlE5UFdMNDl4M3g2dFhTeTVBRmN3TnN5aDZsU2xkcHIxTGpjb05VMll5UkRz?=
 =?utf-8?B?TnFJTW03NkxHSUxTLzdTdTd3RjVQbi91NWtROVRyUFJJVU8zeTRmVFBZSjg1?=
 =?utf-8?B?a1c4QksvZi9HVEFJZlJRZ2t3ZExhREhHaFpTRTI0SkRBcjAxTXJkK0htbXU3?=
 =?utf-8?B?VEJicG5yeXpLb1ZKS3kvM0JkUksxZTF5TWFaOWV1TllLbEFrSXR4N0tsckdY?=
 =?utf-8?B?QjVNQ2Q4VUZ0TTVjaEczWXNJbW9LVTJrOEc2UUJvRUt6VDl1eFlIYnpkS1Jm?=
 =?utf-8?B?NkU5MmZ3bWRpeU1DNDB2aDh1b0Q3VXo4SlNqeXZTNzdmYVNsQzVVOEZnV21W?=
 =?utf-8?B?YkJ1OElSOUJwajhaWjhMT2NQc3NldXIxZWNPYWgwK1F5Q1ZMcjV1MUlJRDIx?=
 =?utf-8?B?R3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 06d52069-2a22-42c0-db35-08dbf7fe9a8a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 15:01:49.6254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3GGVl16Muq05KMJFru1iyP+3ySaFP64eB4t1NDnyDlFv1H/+lE0c0K0OcRlFWwUIyGxjcuxTq5fMPGwMNLW9utJiPFiU4ka6gCw/glea8M8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4949
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 08 Dec 2023 07:02:20 -0800 (PST)

From: Kunwu Chan <chentao@kylinos.cn>
Date: Fri, 8 Dec 2023 11:19:50 +0800

> The size of "i40e_dbg_command_buf" is 256, the size of "name"
> depends on "IFNAMSIZ", plus a null character and format size,
> the total size is more than 256.
> 
> Improve readability and maintainability by replacing a hardcoded string
> allocation and formatting by the use of the kasprintf() helper.
> 
> Fixes: 02e9c290814c ("i40e: debugfs interface")
> Suggested-by: Simon Horman <horms@kernel.org>
> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> Suggested-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: Kunwu Chan <kunwu.chan@hotmail.com>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

Thanks,
Olek