Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2398121rdb; Fri, 8 Dec 2023 07:07:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9GNXpxYnjgfrv0JFKnzNIwgZz9rmYrohhJocCBus16B/WQ3+C5T+3lnVtTnPKcgnteGIe X-Received: by 2002:a17:902:c946:b0:1d0:c14b:dd0d with SMTP id i6-20020a170902c94600b001d0c14bdd0dmr152902pla.54.1702048032216; Fri, 08 Dec 2023 07:07:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702048032; cv=none; d=google.com; s=arc-20160816; b=ZigwHp4CgUu0S7f9A+ne83TS/SQjyUZQt3QP1oeUxeeZcm3vX/1OCNw6FnsVvSs4Jk +pmPma36hnaa4+6k8DwxkQ+7MKAhbHVg4XgIzZKYE0p9wv443j4AdAkRgNuOD0lp+vYn ZzCKMhdknVlP2xv3HENBl5fsPADNje6QenMOjHnC+/VEilmd+qrKEIYf1agQO8X5EL6z 0ZO5jrQKH7311LDRqTfVHdcDf3XmiTid6+zDiTnA6VoZKdc6oGgMzkFU11SJMFI/ZIC0 RReMNIOc97VH1FdZGvQEFerS5aUb9oASt5jqczwf1u1DT+m6Jy4lmyLsMlrmn7c+jEwF T9YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=m6pOl44hnRB0dR/4pW+aUDm4MDjfxjNHERGp+p3r9Ks=; fh=wjU2zKekjSVWqfvG+dwVzrN5WXRCf0LfTeLjaKFOrlQ=; b=VGNFY1/peYextc+roZHdiT2bEvA4AFiv8ng0lta5INuc7SkDk+pjMsaI1uyc4fRn7S IL7P32S7/ByGlPVrBw8lcM7edae1dgZdhcijCk4bWpmtqs2ugM/CobV0zadaY16DddDj DiJHXH8YKfbLmpkica4s/pQAhbGZwpwq/BrvUoKFRYm4qnsveF1Hiokx6z8OUB92URMn A+Y7vWorWwazPHDn2FNmJfiggryyHuOTvH5OBFpX0PogLG41GRpaAsQ3X//spdho7/pk QRir8acVOYc+mR4eoDqQ6gXNkCY+JQhFC6BzqJ95wQ3s75kytSAXJmZUn2eS2Kfb0F56 YlrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RKGZJ1oy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id n4-20020a170902e54400b001d05450e410si1753210plf.208.2023.12.08.07.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 07:07:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RKGZJ1oy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id D52C18083A8D; Fri, 8 Dec 2023 07:06:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574161AbjLHPG1 (ORCPT + 99 others); Fri, 8 Dec 2023 10:06:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1574147AbjLHPGX (ORCPT ); Fri, 8 Dec 2023 10:06:23 -0500 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7055F10C0; Fri, 8 Dec 2023 07:06:29 -0800 (PST) Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3b9e07690ccso1087795b6e.3; Fri, 08 Dec 2023 07:06:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702047988; x=1702652788; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=m6pOl44hnRB0dR/4pW+aUDm4MDjfxjNHERGp+p3r9Ks=; b=RKGZJ1oyu1oqtzBh7o6NWd9xtRkwNjSZhcIA60MV6w2bnqt9MEjIUhchJY7zekJOCG JnLVZFybqQpp1lkP4LnAYqXkCcBzV/ngdf0KGu+0fWFG9uo2165cbG/u6dDV8UvrsEXm vwcgPxnNRR12lQRm9i7QXdqaadgOsicojbbYqJV8pdpcFsxBIDYN2UB2Mi24om9FlJdg 2d3s9GAsnY5rqa6YLNJrmMObkf75LNzFIOUKdNk10etNHLrvxtchWY6vIpZJV5BObFiI pkCVm+7A6RfNi34mfIN8XGfV5vQ8o7Ce10LQU8iLLdkVS93yOUzK2dBGaCNscaP705ZZ tnHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702047988; x=1702652788; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m6pOl44hnRB0dR/4pW+aUDm4MDjfxjNHERGp+p3r9Ks=; b=RXFORxUeZn1MQWs7njUjEOnoHIZ+yRGPh8O4sslUXTtAyCRqyXOVrYd1hPKqSYj8c9 zJPUS4CJ5L1uHmWVl6rGR0QIbqEZVOLBU9d1WFKgGzlCYXv6oXo1Qae5ICDRvJWJ4p8m sjXaZc9MOPJ2fzU80xs6yYXjaIIPXJ77ImXMPGVj3nVvpkSkyoywWeqqFSzwbK6lJI6f d+vYvymVH8rMom+c5fp2ZAGc+mz7xGpWrn9KZJBkVrwprR/kHJuHncmSMulaPYnohT/+ 4fEq3mr6B5GrB1/x0/UOS0iw8VWIi69Y3WphJuogOlu7WDrz3vOegoQEz46gjJYqWKdK iGOQ== X-Gm-Message-State: AOJu0YzbDuOG7uSn02bSSf3bQW0Mc8J3c5hwLJmVF2HP4ZbJFZg5p4ng hJV/E2PREsrTC3ALNx9CVH+X1YZO6RM4GKglIkQ= X-Received: by 2002:a05:6808:222a:b0:3b8:b063:5d6c with SMTP id bd42-20020a056808222a00b003b8b0635d6cmr163139oib.83.1702047988710; Fri, 08 Dec 2023 07:06:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Miguel Ojeda Date: Fri, 8 Dec 2023 16:06:17 +0100 Message-ID: Subject: Re: [PATCH] docs: rust: Clarify that 'rustup override' applies to build directory To: Viresh Kumar Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Jonathan Corbet , Vincent Guittot , rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 08 Dec 2023 07:06:52 -0800 (PST) On Fri, Dec 8, 2023 at 11:18=E2=80=AFAM Viresh Kumar wrote: > > @@ -39,8 +39,13 @@ If ``rustup`` is being used, enter the checked out sou= rce code directory > rustup override set $(scripts/min-tool-version.sh rustc) > > This will configure your working directory to use the correct version of > -``rustc`` without affecting your default toolchain. If you are not using > -``rustup``, fetch a standalone installer from: > +``rustc`` without affecting your default toolchain. > + > +Note that the override applies to the build directory (and its sub-direc= tories). > +If the kernel is built with `O=3D`, the override must b= e set for > +the build directory instead. > + > +If you are not using ``rustup``, fetch a standalone installer from: Thanks Viresh! I think it may be a bit more clear/compact if we simply change the "enter the checked out source code directory" sentence instead above? What do you think? Cheers, Miguel