Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2406360rdb; Fri, 8 Dec 2023 07:17:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTP5cTte+JkRqZ87EFfpU9LNjspMFViEJLOaS4Ox6BSQz9+i23VahhC4IGY8wC2jHX64r+ X-Received: by 2002:a05:6a21:a581:b0:190:5c4e:8c99 with SMTP id gd1-20020a056a21a58100b001905c4e8c99mr205553pzc.38.1702048659866; Fri, 08 Dec 2023 07:17:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702048659; cv=none; d=google.com; s=arc-20160816; b=xemrTV3YN6Ot7WSvC8/Voyw/8bEmmHnohvKrxp4W4J+fDaQphrgtF3DvLRJaS1jWNw j+PeYnkGJwKqTMos7uxwmfzdKOfJxGKslsp8GCVM9rYkVfRoP8wN6ZXS3ougCSN98cGH LWQLCKHL7GIwsmLly0bbcfVNWQEYercccY7TGo5yYmbIdtVNaWFrSp8gRxA364zctC06 esXTdfErXdwy/ST/dv0M0DOV8/xilSl9Tj3PIcQM3DJHvZ4vNprrsXpTSLhN7Jk4DtIT 0Eo7Sx9kKY7+orWh6Hz6I7uau+v4LawJLb1HT5xulSL8C6F4wYTABCkfIRMcwMiqX7eo /OJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=enE/8sDewyg1E2UkqVRy9/QcZQqUmzFAES9Al3AooKk=; fh=RbxEv4DHPoUS3bylDTKAQBorYAUVnKm8F+DS1AuFZW0=; b=iILTzC3NfGGwxl5c7hasA1QLgoTreruXymJLL7C2pjG6k/VO6HbKq8VWhrRYW3Z9mL dF0l7uyKBKohSY46mGaJL3FTzmDKTuLXYqZyqxGGS8EJ7VTsbb4oXWl+A+3QFWdEjLIH Era7MJaOLYc8N5jpF6Bx9fg/WgWfb4sUOFSVpCZSMwybyW8CjdL0QWCz8SSj6QGqcCbq vNPsKYoFRFpv/X2I8/cUzQuIfcLZRfz+3kBB7ht2XttclaWxujhEY1TFiLH5/FNArQ6q 2aIBBv7qgs6PT9qWcMXdNfoKC40JBVptqc9RiITHdQ3V/T4ADy2eR8xTkf3xnY8A71/J e4Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EcYhb15z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id kr21-20020a056a004b5500b006ce4df26354si1734866pfb.56.2023.12.08.07.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 07:17:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EcYhb15z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1E5F381CFF10; Fri, 8 Dec 2023 07:17:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574257AbjLHPRZ (ORCPT + 99 others); Fri, 8 Dec 2023 10:17:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1574260AbjLHPRX (ORCPT ); Fri, 8 Dec 2023 10:17:23 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEBBFF1 for ; Fri, 8 Dec 2023 07:17:29 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C2D5C433C7; Fri, 8 Dec 2023 15:17:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702048649; bh=hX6GbMkn+q3aw8cUXh7DUuZsJkUeN7K0RoNohm9TiuA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EcYhb15zqwEBqikmKpTsvrdG37y++jvmYlI7BurSQR8ud2IF9Gh/z3lX9GLQMell8 jhPrY22ycsPYDovQ7F/AaQXBCI3tQa/wEhm1sSGxO5caZFcFAyUKv39ge6c8PrlFg7 JyLbbYc/oNcuUw6k/E++8h2o+75bQLEeGr1ahl7cSA4PQz4X1T8Hz8aypq1Q8I+ES7 vNEsBY8t50F1H0jFzieNDpFMoZW5KtjHutDKb5RhTscPu73t9a0BvYLdrafcw5y7T1 kX6gIIQhPXZjBTYi4THKI/kr0kySau7Djb29E5CNxECMFd+2NC6u8heBTo/GwqMths qYlRVh9itH5gA== Date: Fri, 8 Dec 2023 16:17:24 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Gregory CLEMENT Cc: Sjoerd Simons , kernel@collabora.com, Andrew Lunn , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Sebastian Hesselbarth , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] Moxtet bus fixes Message-ID: <20231208161724.5f4f626a@dellmb> In-Reply-To: <87fs0ceoif.fsf@BL-laptop> References: <20231128213536.3764212-1-sjoerd@collabora.com> <87fs0ceoif.fsf@BL-laptop> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 08 Dec 2023 07:17:37 -0800 (PST) On Fri, 08 Dec 2023 15:51:20 +0100 Gregory CLEMENT wrote: > Hello Marek and Sjoerd, > > > It seems the moxtet bus support was broken since 21aad8ba615e ("arm64: > > dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two > > reasons: > > * The moxtet irq isn't marked as shared so the driver fails to load if > > the rtc driver gets set up first. > > * The dts change didn't set the IRQ type, so in case the rtc driver got > > probed first irq setup ended up wrong (rising instead of falling edge). > > > > On top of that the moxtet module isn't auto-loading due to a missing spi > > table > > > > Changes in v2: > > - Add cover letter > > - Add patch to set the irq type > > > > Sjoerd Simons (3): > > bus: moxtet: Mark the irq as shared > > bus: moxtet: Add spi device table > > arm64: dts: armada-3720-turris-mox: set irq type for RTC > > I only received the previous patch in my inbox, I plan to apply it. But > what about the 2 other patches ? Marek will you do a pull request with > these 2 patches or do you expect that I take them also ? > > Regards, > > Gregory Gregory, as of yet I've never done a pull request. If you are willing to take all 3 patches now, please do. In the future I would like to start doing it for Turris stuff, if you are OK with it. Marek