Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Fri, 8 Dec 2023 14:22:04 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, paul.gortmaker@windriver.com,
        x86@kernel.org, regressions@leemhuis.info,
        richard.purdie@linuxfoundation.org, regressions@lists.linux.dev
Subject: Re: [patch 2/2] x86/alternatives: Disable interrupts and sync when
 optimizing NOPs in place
Message-ID: <20231208132204.GBZXMYfLSaIbn3BvN3@fat_crate.local>
References: <ZXCXc+BtnLzqMbFv@windriver.com>
 <ZUEgAAGDVqXz2Seo@windriver.com>
 <0adb772c-e8d2-4444-92b0-00cbfdaf1fac@leemhuis.info>
 <87r0k9ym0y.ffs@tglx>
 <20231207193859.961361261@linutronix.de>
 <20231207194518.401797191@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231207194518.401797191@linutronix.de>
Precedence: bulk

On Thu, Dec 07, 2023 at 08:49:26PM +0100, Thomas Gleixner wrote:
> +static void __init_or_module noinline optimize_nops_inplace(u8 *instr, size_t len)
> +{
> +	unsigned long flags;
> +
> +	local_irq_save(flags);
> +	optimize_nops(instr, len);
> +	sync_core();
> +	local_irq_restore(flags);
> +}
> +
>  /*
>   * In this context, "source" is where the instructions are placed in the
>   * section .altinstr_replacement, for example during kernel build by the
> @@ -438,7 +448,7 @@ void __init_or_module noinline apply_alt
>  		 *   patch if feature is *NOT* present.
>  		 */
>  		if (!boot_cpu_has(a->cpuid) == !(a->flags & ALT_FLAG_NOT)) {
> -			optimize_nops(instr, a->instrlen);
> +			optimize_nops_inplace(instr, a->instrlen);
>  			continue;
>  		}

Arguably, the proper thing to do here would be to convert the NOP
optimizing to the same 2-stage process as normal patching: write insns
into a buffer and text_poke* it.

VS what we currently do: operating straight on kernel memory.

Lemme put it on the TODO and see how ugly it becomes.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette