Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2421128rdb; Fri, 8 Dec 2023 07:41:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IH8e2a8mks9ijI3XqO2Wmyk68vMXMDzwMqK1jkiZS7N8CmFcXZZBC/wdN34vHK1NINJCj2b X-Received: by 2002:a17:90a:f190:b0:286:6cc1:5fcd with SMTP id bv16-20020a17090af19000b002866cc15fcdmr251816pjb.80.1702050110218; Fri, 08 Dec 2023 07:41:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702050110; cv=none; d=google.com; s=arc-20160816; b=zAY5N+ChnuvJrzCAuRgUsoXifGGku8kkffPcDCIU7j4zU58wGeCxZTlA2dm6rDqtEn +oAc8IZe1qesZznlKVv6mzEBsJIMNs0zGZGTYjULzxnbX7NoLCdyGmvRNXSpupCnNNkj 5Ut8kXtotM9buei6i0of1dmASf1XTbnBGRK/gmSqYtUtWCbLXysx79taasKa2gLKKHHD RHPFSQOGStWuSOMqgQbzqpREb0iR1EW8kFSW3sK+U5XW7pfM4RO9a+GN7ZAlC7CbDh6I Cx5V3l3ioHFCrkeMcAc9hJi0ZTtwSdLsPpQAWHiQAx1cDnx4rH5s6YU9rulN1NrxGteh PHjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=R0pEnoL/Gff0b7iShI70ys3jq+wUbtxEI57WVAKBvbY=; fh=M5OZhock0rb2e8T5sn0xmIPIioY6JfgHfympkPsbZmY=; b=Abm+5LRn69bVA9s2Ntps4Q9B+UpyrBjb00m1kmi92DeGGQ2Cm1dZnBDOc2Gih1hrL0 41eHDB7Rho/X7JVz9rQQqShwDV8xSVqRwA7hPmIh7rPWgp3bNbffUl+9PP5/whtxM2mj 2APIufvk+ne1vZy1ulj6DIKQN80xpgYuQM0GhJJYCQsq+tPuojgkyxKg3JgXpKPzOJ3f 3dg5xaLtIZEltgjntatXPVlDPRG4Bq8H/9GJBAk1LVhRs4DxWshPt8O0NIE5yxgzd0Zn L6f3HZb+A2Sm4D48BM6rtkCh2xJaquEfeCZyKgLyBQ0o8jpAem2AXP7RgTfdLbpt+bjz 1mEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oWIePqJ8; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id x23-20020a17090abc9700b00286c80ac075si3130785pjr.177.2023.12.08.07.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 07:41:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oWIePqJ8; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 1054E8116E6F; Fri, 8 Dec 2023 07:41:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574385AbjLHPlS (ORCPT + 99 others); Fri, 8 Dec 2023 10:41:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1574416AbjLHPlH (ORCPT ); Fri, 8 Dec 2023 10:41:07 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90D69FB; Fri, 8 Dec 2023 07:41:13 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1702050072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R0pEnoL/Gff0b7iShI70ys3jq+wUbtxEI57WVAKBvbY=; b=oWIePqJ8rLv6IqfuQBwmciWl8+bdrvJChn9XZBRwjfn2R+UWGhM9FBfTaNFrvOeTbj+ZiR NtNBvtlFwrJF+x1yyx0T/OegnmxhLYqsNWa2O/yhcAEBqMPhRWAFrmLeaLWH00+f4eDNvW 934LKyPiPipJr89Wkm8/GQ9S7pB3ji0rvjTHyAatGBIPZQK2AqqHOOMll1AEyRlXE8+sWT /FuY01A+R4czn/mAhyyCCrxSc1g+4akz3IijWSSX3fFMf8iHAfj03ZUHDTLrqrURDyPfSe 0YGNg2GuKZ8s5MMbKKi2AQpC2Oy8LVXITVWCk7YDPrbMiw92DDJKfp0RlVLmBA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1702050072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R0pEnoL/Gff0b7iShI70ys3jq+wUbtxEI57WVAKBvbY=; b=Sg/seOJdGSBSS6Nb6kY1FKuVmTB578w4HPATOkDjs5zwTeMdY/8r8MszTIuJ6wOf0gdakt 6hK4QS4r6hfVeADw== To: James Tai , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , James Tai Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel test robot Subject: Re: [PATCH v3 6/6] irqchip: Introduce RTD1619B support using the Realtek common interrupt controller driver In-Reply-To: <20231129054339.3054202-7-james.tai@realtek.com> References: <20231129054339.3054202-1-james.tai@realtek.com> <20231129054339.3054202-7-james.tai@realtek.com> Date: Fri, 08 Dec 2023 16:41:11 +0100 Message-ID: <877closnvs.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 08 Dec 2023 07:41:48 -0800 (PST) On Wed, Nov 29 2023 at 13:43, James Tai wrote: > +static int realtek_intc_rtd1619b_suspend(struct device *dev) > +{ > + struct realtek_intc_data *data = dev_get_drvdata(dev); > + const struct realtek_intc_info *info = data->info; > + > + data->saved_en = readl(data->base + info->scpu_int_en_offset); > + > + writel(DISABLE_INTC, data->base + info->scpu_int_en_offset); > + writel(CLEAN_INTC_STATUS, data->base + info->umsk_isr_offset); > + writel(CLEAN_INTC_STATUS, data->base + info->isr_offset); > + > + return 0; > +} > + > +static int realtek_intc_rtd1619b_resume(struct device *dev) > +{ > + struct realtek_intc_data *data = dev_get_drvdata(dev); > + const struct realtek_intc_info *info = data->info; > + > + writel(CLEAN_INTC_STATUS, data->base + info->umsk_isr_offset); > + writel(CLEAN_INTC_STATUS, data->base + info->isr_offset); > + writel(data->saved_en, data->base + info->scpu_int_en_offset); > + > + return 0; > +} > + > +static const struct dev_pm_ops realtek_intc_rtd1619b_pm_ops = { > + .suspend_noirq = realtek_intc_rtd1619b_suspend, > + .resume_noirq = realtek_intc_rtd1619b_resume, > +}; So this is the 4th copy of the same code, really? Why is this not part of the common code? Thanks, tglx