Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Fri, 8 Dec 2023 17:57:05 +0000
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        rrameshbabu@nvidia.com
Subject: Re: [PATCH v2 2/2] Input: i8042: Add a quirk for Framework 16" laptop
Message-ID: <ZXNY8a_Zja9rSupQ@google.com>
References: <20231206212140.7458-1-mario.limonciello@amd.com>
 <20231206212140.7458-2-mario.limonciello@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231206212140.7458-2-mario.limonciello@amd.com>
Precedence: bulk

On Wed, Dec 06, 2023 at 03:21:40PM -0600, Mario Limonciello wrote:
> The Framework 16" laptop doesn't have a PS/2 keyboard. At bootup the
> following messages are emitted:
> 
> i8042: PNP: No PS/2 controller found.
> i8042: PNP: Probing ports directly.
> i8042: Can't read CTR while initializing i8042
> i8042: probe of i8042 failed with error -5
> 
> There are no PNP devices as those listed in `pnp_kbd_devids` but
> i8042_pnp_init() ignores this and still runs and will continue to
> try to probe.
> 
> As there is no PS/2 keyboard or mouse in this laptop, set a quirk
> to avoid this behavior.

I believe the proper fix for this is for the firmware not report i8042
as present by properly setting up FADT. Please take a look at
arch/x86/kernel/acpi/boot.c::acpi_parse_fadt() and how it sets flag
X86_LEGACY_I8042_FIRMWARE_ABSENT.

It will still say "PNP: No PS/2 controller found" which is an
"informational" message, but should not try to probe ports directly and
report errors.

Thanks.

-- 
Dmitry