Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2504146rdb; Fri, 8 Dec 2023 09:58:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjmQm0+tz5tBOTwUDrTz5uJGowS2yS3xKh7vMojIoGomDp4kkWlSzKMI+QG1gLBsJh/qKg X-Received: by 2002:a05:6358:c696:b0:170:67b3:6d97 with SMTP id fe22-20020a056358c69600b0017067b36d97mr289897rwb.32.1702058287824; Fri, 08 Dec 2023 09:58:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702058287; cv=none; d=google.com; s=arc-20160816; b=h9aNtpeb+FFO6g+Y2DyVSb5Gkhlqsqe5bqBPCj4G7JHbdbl7d11MG3ZckeeGup/Cx7 k2c05K9ZdIUzbUxocH/bAZcJgN3cUpuvU5Zu1fYEwxWSSHME6xbHyxZ18Kw/soI81Ztq 6x+DEROJmYX4YVYc6oT4ESxcX2MkOp98WHeOuGhIguYWSlI+UeskbW8jA0DtB/PNzQK5 bg/ZWGhpiq7n8aKvmltT4nhKzZOsz0gwPDRotV8+A6F76IXtXbsphgCkRm7nCjo0WETp xtCg5Ql3FsoyVuhMnRnn9vPaUdbXWzq8XGYviZJXxD6kKFgzMMeabQ2oR6/uEVXShow+ ePig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=Wj704fWHOpU1SWgHtGl87HPV6WWiN6W5xSeHig4mm5A=; fh=GFsDh6hj+bs95BSlPh1kkGofBMdoBkkJK9HMrobHRtg=; b=jnMXJH/iyxRmFv0vZ78RsZn4SzxS7TdQsXcV6wq8hhg0Q6hNMKcSmzH+pStFqBSj0O DmiEuVvZSMZURjRnSXx70no3lnq70oC6CRKe6kWUsE6pa8UJ6+1e65HH1k75J6XQou64 kvButoUxOUboYed9wtma/4FNgkWsUypt4wXBcKO5RfuEZMGiajuOH4ob2e/v2DaNNfeZ ffSfCQI4/P85FMueL4FlUVJPvXbnmQr18wIthbos4Up2cNAYXJOoiVIwNFYjopKWm3Lp QI4sVvEe7ZyIulezRywV/Hd3/CDXPRRbT9AJKVylQJn9G4cY4+uycMY5q4/D380qNrsw gY7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p0AaqR6C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id i1-20020a635401000000b005c65ed0f680si1865056pgb.463.2023.12.08.09.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 09:58:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p0AaqR6C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8905C833D553; Fri, 8 Dec 2023 09:58:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574581AbjLHR5t (ORCPT + 99 others); Fri, 8 Dec 2023 12:57:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235943AbjLHR5s (ORCPT ); Fri, 8 Dec 2023 12:57:48 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 092071700 for ; Fri, 8 Dec 2023 09:57:54 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c9f166581dso29983101fa.2 for ; Fri, 08 Dec 2023 09:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702058272; x=1702663072; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wj704fWHOpU1SWgHtGl87HPV6WWiN6W5xSeHig4mm5A=; b=p0AaqR6CatJS1hBWcTHNIAh3TO0HJ6LCDSgZ3cbzlmN3KiUCm2HQa86L7gNBNg49iE juf6lGAkmW+/lOp0DoaQzYyUiGHlCvqR+ukBNztstVoosHIZnyN85qH1I290aWnzq7tN 4Gy01Ie/xFTVXEjaQ1NsrjXX5ULw+sqighs6uD6BID/6yQNrpk/oKPvnqu5yXDbCcKTg lWWMakIcN8iYGvEAuqfUO9H+u8Rm/UwgC/nwndo7zHo9khrsmMXn5lQoXKb+aU6z131g N++8EHERNy8nZwdWpLK/oFYztYb6QoOzO5Kmpc5WIZfXOXjre8KukGvsEp4EOPrSCvwM zhPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702058272; x=1702663072; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wj704fWHOpU1SWgHtGl87HPV6WWiN6W5xSeHig4mm5A=; b=B+bpKBdxcVJjlWIhr7rihkAN7oVW9zx9elY12FXnHkTcdjp7CGN0WNxvzj6xJ7CUBn OBuyAJBMNwNSbjikae++xpMtOLwMjH5V/SAnetkaXJE+T+qwmlE07GjPAn8b28UyBMRk lcEuZDG1YX3+vAk1Xe26L2pjI2S+TECbQCwTPx/4fpEBVwfxCnqJLlylFN5MlQFCQP1Z JzmPRfbByx7Gg+vcaTj1nk6kHkhUPqzmbxo6mtpCScTEGg2SYq5ovN/4WcHGhj3sVE4X quNzDuccGtF4bxrPU2Y9V9QoYmyxSc/T0eef4xuo9E7oSyBmFvE6iRNdwVyU6PgGipYf BaTA== X-Gm-Message-State: AOJu0YzI86c/eIfNpEpRB/Cl+nxiXFBLExOIlCjp1qldTtyuzt+S+3m1 vmMgekUWTLFydkfGLpDwLkGNmQ== X-Received: by 2002:a2e:b358:0:b0:2ca:2d96:d99c with SMTP id q24-20020a2eb358000000b002ca2d96d99cmr145214lja.92.1702058272286; Fri, 08 Dec 2023 09:57:52 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id rf19-20020a1709076a1300b00a1f75d21bf3sm498896ejc.6.2023.12.08.09.57.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Dec 2023 09:57:51 -0800 (PST) Message-ID: <9880fbbf-c311-4b6b-a570-aafd61729446@linaro.org> Date: Fri, 8 Dec 2023 18:57:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 16/16] riscv: dts: starfive: jh8100: Add clocks and resets nodes Content-Language: en-US To: Emil Renner Berthing , Sia Jee Heng , kernel@esmil.dk, conor@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, hal.feng@starfivetech.com, xingyu.wu@starfivetech.com Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, leyfoon.tan@starfivetech.com References: <20231206115000.295825-1-jeeheng.sia@starfivetech.com> <20231206115000.295825-17-jeeheng.sia@starfivetech.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 08 Dec 2023 09:58:05 -0800 (PST) On 08/12/2023 17:39, Emil Renner Berthing wrote: > Sia Jee Heng wrote: >> Add SYSCRG/SYSCRG-NE/SYSCRG-NW/SYSCRG-SW/AONCRG clock and reset >> nodes for JH8100 RISC-V SoC. >> >> Signed-off-by: Sia Jee Heng >> Reviewed-by: Ley Foon Tan >> --- >> arch/riscv/boot/dts/starfive/jh8100-clk.dtsi | 180 +++++++++++++++++++ >> arch/riscv/boot/dts/starfive/jh8100.dtsi | 115 ++++++++++++ > > Why the split here? I mean why can't the clocks just be in the jh8100.dtsi? There should be. What's the point? Clocks are internal part of SoC and not really re-usable piece of hardware. Best regards, Krzysztof