Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <8af70f29-0853-42bc-aabd-338eda6ed154@suse.com>
Date:   Fri, 8 Dec 2023 21:28:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH -v2] x86/ia32: State that IA32 emulation is disabled
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
References: <20231130155213.1407-1-bp@alien8.de>
 <20231130160903.GJZWizn+dPaaViFVKN@fat_crate.local>
 <20231206172022.GCZXCtVoZtt4t2TLpe@fat_crate.local>
 <4f232dfb-a112-4271-8f43-f85a02c4abeb@suse.com>
 <20231208192254.GCZXNtDjT73Z4L06h/@fat_crate.local>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20231208192254.GCZXNtDjT73Z4L06h/@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 8.12.23 г. 21:22 ч., Borislav Petkov wrote:
> On Fri, Dec 08, 2023 at 08:42:29PM +0200, Nikolay Borisov wrote:
>>> +static inline bool ia32_enabled_verbose(void)
>>> +{
>>> +	bool enabled = ia32_enabled();
>>> +
>>> +	if (IS_ENABLED(CONFIG_IA32_EMULATION) && !enabled)
>>
>> nit: But why check config_ia32_emulation explicitly, its state should
>> already be accounted for in ia32_enabled's value? So this check can simply
>> be 'if (!enabled)'
>>
>>> +		pr_notice_once("32-bit emulation disabled. You can reenable with ia32_emulation=on\n");
> 				^^^^^^^^^^
> 
> If CONFIG_IA32_EMULATION is disabled, is there any 32-bit emulation to
> be enabled, at all?
> 

Ah, the !enabled condition will then trigger so it will result in a 
false print. Fair enough...