Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <d4b36905-d6dc-eefb-f07d-a78a83526de4@intel.com>
Date:   Fri, 8 Dec 2023 12:12:21 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v11 14/14] dmaengine: idxd: Add support for device/wq
 defaults
Content-Language: en-US
To:     Tom Zanussi <tom.zanussi@linux.intel.com>,
        <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <vkoul@kernel.org>
CC:     <dave.jiang@intel.com>, <tony.luck@intel.com>,
        <wajdi.k.feghali@intel.com>, <james.guilford@intel.com>,
        <kanchana.p.sridhar@intel.com>, <vinodh.gopal@intel.com>,
        <giovanni.cabiddu@intel.com>, <pavel@ucw.cz>,
        <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
        <dmaengine@vger.kernel.org>
References: <20231201201035.172465-1-tom.zanussi@linux.intel.com>
 <20231201201035.172465-15-tom.zanussi@linux.intel.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20231201201035.172465-15-tom.zanussi@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WW56V1Z6dTJtTEowN0VkVE5nMUlNYWRsQjdwR29BdS9rTFVkdGJ1bC9lb3l1?=
 =?utf-8?B?V1pwQlZGL2NHOGVYMXkySkFCS2VXWVBhMmt4N1ozVDhNRWlKZjlTVUkrSXdN?=
 =?utf-8?B?Um1kaFA3bmNTaC9oZlZnbzQ2b2orM3ZjOU5VaVFUY2I2aTd2dERDUEtOTnVn?=
 =?utf-8?B?WFBLaENpb05CVCticTVLV0ROWEZkVDdrdStHSDlnR1owTUhHTVk3VDRSSCt0?=
 =?utf-8?B?WGxFNWRTcGFLRzJWbU9GbjZvazVVOUE3QXU5S1JFY2NOb2RJd0pKUXVZQy9M?=
 =?utf-8?B?KytkeS9DUmM5cXpKa0dCOTJFTHNyMEJoYjJWNzJFbWp1bWQ1bHVtRWFIUHpS?=
 =?utf-8?B?aEJ4aHQyTjRNU2F1dENET0lkalFvQ3NiaDlxZWJKZi85SjJsK0VxTE8rYVp3?=
 =?utf-8?B?bkJOSlBlWXVsZHlFODFibkJqWmM3K1BiNGd4ZUlNVnlzekpJN1U1OVlabHp1?=
 =?utf-8?B?ODJlQ2NUYk1lOU9WYjdIQVA2R21zVkxXRFBBV0tOTHBjTGFBV1FaUGl1bWJY?=
 =?utf-8?B?MDM3R29XZlVNSmJPS1VxT2ZZOHJlWnZtS0JvZ1pzNkJxWTZVc2JWZDUyMHRQ?=
 =?utf-8?B?WFJjUmZkamduVm1DUVNnZ1NNNno4bVZnWkNNMGlyaHR4NDJDT3ZxeXN3U3pm?=
 =?utf-8?B?ZFVEb210NDF1aDRpVjhJRWpUUGZENFNWUXVXS2p1RHA2dkpDOEgyelMvVnNx?=
 =?utf-8?B?S1RzVndWQUgwSHE4aG14LzVoV3FqUUlLSXVoU212Mm9nWXhqak90TU1PUDB0?=
 =?utf-8?B?cGRCV1RJdC9aeFVFZGJTUDJOVFdHWTBMY3NpWE54bWdRa0NWWnJtN2xZQUg5?=
 =?utf-8?B?ZXpobXVXNWxhRzBCbkVsUzRhZnlhaUV2KzlRQlp3TUI2bXVKQUJUcHJWcDJ4?=
 =?utf-8?B?QVBITUZUYVJiVHhJWUpXRjY0OSsyNFJERlZ2NU9OWGhBdldkUDR3ejRXUm1X?=
 =?utf-8?B?MGcwcUU0V2pIOUFEbmNSdmMvSDdXSmF2V2JVbTlSbUFmeWt3U2pmZ2dEWTdX?=
 =?utf-8?B?WUF0ZUhSTHpvVldYaG5iTUprVHZFd05TdXNFc29XTjdpSzlKbER6MHI3VFRr?=
 =?utf-8?B?dzZRMGdzL0kwa0xwdGxTV3NHRmJrZnpRUjJMWTlMNDNCQ2VrdXczbmxRcGhO?=
 =?utf-8?B?Njc5L3UrM3RiVVJmcExwaTlCL3UzUzJJVVcrZ2grZUw2K3h5L1VnZytyZ1M3?=
 =?utf-8?B?Ylo4a2cvWEZEQ2M5REI2V3hSdTJ4RXJmVHpjT1NLdEdDUFZxelRKV2diQkht?=
 =?utf-8?B?V3VucXR5NFpMU3pIRVZ4QUtsNmNvVis2K0FLSlgxTVRHclB1WmVyeVk5TXMz?=
 =?utf-8?B?MWZNUmVGcDc3aDcxZ2NtdjZVd2crcHNBeUE2Vkw1cyt2bjM2RGN4NEJqLzdw?=
 =?utf-8?B?bkxqWEFJeGlRUXVoRlpzSUtSbEt6NGtaUEx5dFVsN0tCSkp4bE5WVHEzK3RB?=
 =?utf-8?B?dnp2c0I0RStVaG85SGd3a0UwUUlvZ3lhNjRtT0E5S1JXNlMwN3ljbENZb1kr?=
 =?utf-8?B?aVpUWjYzdXdDaUM4VUZlYkcrMmNpL0RMVWdYeU5JQlRsbWNvU3BlUGpwd2hW?=
 =?utf-8?B?S0hzUFArSk1IaktZYitpKzdCb1dFd3ErUWRhTG83UTJrSm5ZbHBLRTQ2bUZ0?=
 =?utf-8?B?WGZJVGlOZEFzNEgwTnpnZ0RDVWlQSWpQNkVSelVSc1FBMjFaUW80VStDTlh0?=
 =?utf-8?B?YXc2dEoyRG1NMVNBcURlcS9WbXhQZ1VVOG9RTk1rend1UWR0dUFXUDl5VEZI?=
 =?utf-8?B?aXpRRStaSkJzaldJZHRaZXgzZEU2dmh6a2QzTWpmV1hhQUVlbDBTZlB3QUYz?=
 =?utf-8?B?YVlqbE5OZTNSajRLUWxrNHNydVJraCtkcnR1UGxOMkpuSTdkTWV4OEJ4bnJp?=
 =?utf-8?B?V0xUWlBJMjJselFQWkhmc0NKczJqaWUzMnpVSGwrQ3AzTGdvQVpvSFJGeThQ?=
 =?utf-8?B?MHRMbFpJdjByMVQ0a3lMOW94ckFPUlUxdnJYamNZQjc0WnVmU3lkS0ZXWUwv?=
 =?utf-8?B?MEFBT3BkV1QxYXVaRmdDWit4Q2NsODlkSnBxUldOUjdYVXBNZ05ROG1NeXdI?=
 =?utf-8?B?QmpCdGc5RFRUUFhDSW53WjgyTkhhUFpYSFNGelcrMktDWC9qUFVMWkZsdC9x?=
 =?utf-8?Q?zVZT5VPdGHE/F4U7oBSQnxPQ7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0850bc7e-7fa9-4f76-88c5-08dbf82a0125
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 20:12:29.6434
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +7bMbGvMygP4nE6PrG+iYvRSxH6mx43AfzuenBv6h/iq+ZbXUyiG0byFL0fVT3mpHOeJjVSvHqpSDf2h3vl9cA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7302
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 08 Dec 2023 12:12:41 -0800 (PST)


On 12/1/23 12:10, Tom Zanussi wrote:
> Add a load_device_defaults() function pointer to struct
> idxd_driver_data, which if defined, will be called when an idxd device
> is probed and will allow the idxd device to be configured with default
> values.
> 
> The load_device_defaults() function is passed an idxd device to work
> with to set specific device attributes.
> 
> Also add a load_device_defaults() implementation IAA devices; future
> patches would add default functions for other device types such as
> DSA.
> 
> The way idxd device probing works, if the device configuration is
> valid at that point e.g. at least one workqueue and engine is properly
> configured then the device will be enabled and ready to go.
> 
> The IAA implementation, idxd_load_iaa_device_defaults(), configures a
> single workqueue (wq0) for each device with the following default
> values:
> 
>        mode     	        "dedicated"
>        threshold		0
>        size		Total WQ Size from WQCAP
>        priority		10
>        type		IDXD_WQT_KERNEL
>        group		0
>        name              "iaa_crypto"
>        driver_name       "crypto"
> 
> Note that this now adds another configuration step for any users that
> want to configure their own devices/workqueus with something different
> in that they'll first need to disable (in the case of IAA) wq0 and the
> device itself before they can set their own attributes and re-enable,
> since they've been already been auto-enabled.  Note also that in order
> for the new configuration to be applied to the deflate-iaa crypto
> algorithm the iaa_crypto module needs to unregister the old version,
> which is accomplished by removing the iaa_crypto module, and
> re-registering it with the new configuration by reinserting the
> iaa_crypto module.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua