Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp2621042rdb; Fri, 8 Dec 2023 13:46:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4ST6XnhWsj2AWB5+62WMlwLaYBA85ovaXxyAgJ8aOwJI6w4t1xPBPNzysgTJAc3YTSULk X-Received: by 2002:a17:90b:243:b0:286:8a9c:6804 with SMTP id fz3-20020a17090b024300b002868a9c6804mr677545pjb.44.1702072017930; Fri, 08 Dec 2023 13:46:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702072017; cv=none; d=google.com; s=arc-20160816; b=Jpc9xBA+BPWEi1bLCh9P82fFHkUADJGnBsotoF/FJbRJhE3oh54lehjiL+xpYyMF3e 9b3tPA7ZPGGOJsW9ZJT5YItZCeb4ws313Y6MMGbNB54A3sXFTONf7jlrOPF6fFgwxy98 JyKj6oNBGT3eZU8LXk4u1fDgK2Rm/21+9NqbuJyG1FVkzQ4Ac6yxTEFxPAJcXPFDUx0S dfmqm8R/52T6T/WO9P9AbOmcB1Pvu+XbzvumyjgWF8YBToh/VE16+R9gtUtU8l/OOqbE yvL/dykv4qSy1oKvNeN18qnkYdjHZ68SuDDv88AUE2yPo+READ9OvLSFhnwg9g2ZS/Qo HbHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xQoa4XoYHRaOHV6Nt5gXrEBwcxgLR9S8k0QAcnw7dZQ=; fh=Fk7x4ojnC1toQpJA1fN4fjO3kxmb1D3435Km57b1SgQ=; b=VwphkvNuws1M4jWZ+Hlg8RlZHuecxrvA4EI2fIXRiRRUMbyjOd5eV01RDTpfoIu6YD FdBTywBiD1roe8/tPJsPUmI+wa4iHnK1UnBiaB++5Mr8T6uoEXYkk6h6TnVd99C9ibqa pNiN9wLxq3eq6nJ5G75A7QwikAptKXlHWdmsZFWrGf3l82astT2h7mEP7/IQf90fTjyQ QxpPDsNGKtzpBf1/jlILY4JxZij/FTldbqRPdQVf5ggXa1k/L6wo9UdIeOt2Q4Xq8xTS fyfjGneySOZ7cny3meKSwKUukNLBg8xBISh8ufVELjDRWNjL4G7yThsGrGWwInkeHMpG NFSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tF7HO8t6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id q9-20020a17090a2dc900b002887ef9e143si3350750pjm.126.2023.12.08.13.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 13:46:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tF7HO8t6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id DDF0883BB7D1; Fri, 8 Dec 2023 13:46:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234262AbjLHVq3 (ORCPT + 99 others); Fri, 8 Dec 2023 16:46:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235953AbjLHVq2 (ORCPT ); Fri, 8 Dec 2023 16:46:28 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C38D910E6 for ; Fri, 8 Dec 2023 13:46:34 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D536C433C8; Fri, 8 Dec 2023 21:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702071994; bh=YxUWtkRWJpGUAr3ky7ntglE3+KUpdRkTzGFHiaaIaj0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tF7HO8t6qxKPtPqWQcmb7u0lHrlYtgVHpW+7EVe9JYIYvwjwpfQGqKhWrxzpHI2gi G+XtnfDqNSpryhmqySnfxkWfeb2fAOA9uVHsfmJOtprwfXhqvTasEdb/TdNmvmDhuH 0dcSwQoNqki3pp16GTpT8NLLPGTCJEW2SlFo8i18KW2Iwi6s4xcDl4kmdUiRzbCHaF tCa1seRh1xbRX3/KWbF1/hGiz4F++y+S0QS9mkm9NJn6ReS9VteFAVwaOJ2l70Hl5u T/vvjtBLmpWMCIf9viWJcxBjTA9sToKEBe6sMhZMkxQDWkGQ7LYGol7KfPNhyDQ6Qf 5kbkxloS/XJag== From: Christian Brauner To: Alexander Mikhalitsyn Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, Jan Kara , Alexander Viro , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs: super: use GFP_KERNEL instead of GFP_USER for super block allocation Date: Fri, 8 Dec 2023 22:46:26 +0100 Message-ID: <20231208-monolog-podium-bd91de100ebf@brauner> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231208151022.156273-1-aleksandr.mikhalitsyn@canonical.com> References: <20231208151022.156273-1-aleksandr.mikhalitsyn@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1195; i=brauner@kernel.org; h=from:subject:message-id; bh=YxUWtkRWJpGUAr3ky7ntglE3+KUpdRkTzGFHiaaIaj0=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaQW9210P3U52+lH14SjmTdmerjfuDL9tn6WzvJH+5c6m OxaMC9PtKOUhUGMi0FWTJHFod0kXG45T8Vmo0wNmDmsTCBDGLg4BWAi3moM/0NS+UTrmr4fvFPO uGxu1KTGDJmFdo6MVft2NxonrfB5HMHw3/tNgcq/voRD3xr/hlw8klucVFjxYcJJY1E7s00fTh+ SZgcA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 08 Dec 2023 13:46:55 -0800 (PST) On Fri, 08 Dec 2023 16:10:22 +0100, Alexander Mikhalitsyn wrote: > There is no reason to use a GFP_USER flag for struct super_block allocation > in the alloc_super(). Instead, let's use GFP_KERNEL for that. > > >From the memory management perspective, the only difference between > GFP_USER and GFP_KERNEL is that GFP_USER allocations are tied to a cpuset, > while GFP_KERNEL ones are not. > > [...] Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] fs: super: use GFP_KERNEL instead of GFP_USER for super block allocation https://git.kernel.org/vfs/vfs/c/b91dbdebd653