Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 8 Dec 2023 14:52:04 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Robert Richter <rrichter@amd.com>
CC:     Ira Weiny <ira.weiny@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fan Ni <nifan.cxl@gmail.com>, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] cxl/pci: Get rid of pointer arithmetic reading CDAT table
Message-ID: <65739e147ba03_1e7d272945d@iweiny-mobl.notmuch>
References: <20231116-fix-cdat-devm-free-v1-1-b148b40707d7@intel.com>
 <ZVfIaNhiSc-yQZo5@rric.localdomain>
 <ZVfJ6Fxidvw_gz7r@rric.localdomain>
 <656648433bd82_888fe294a6@iweiny-mobl.notmuch>
 <6572369ea4080_4568a2945f@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6572369ea4080_4568a2945f@dwillia2-xfh.jf.intel.com.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6zS3EQvqI23ONHC5JpuhURf5bJGOzTzRE5+RjP4L97KJFL1/rSZ0YBwaq6xH?=
 =?us-ascii?Q?gFIZZk/DOqsMe0Z+/oHVTKmpmehajrOxclbWCsZr/50C+Wfb6DYHBZV/RDLX?=
 =?us-ascii?Q?ukVonbnjiobEFBNeYi14my/z/48T5LF9kCmFqH8BQyjN0JA1Zu1T9BhDn6Ul?=
 =?us-ascii?Q?3NJPXlRUeMXHP2VEFrg1WB+kKh4Zx+x2vM0pkfg5//HMIkOWKBiaiV0hbGrO?=
 =?us-ascii?Q?Odq5V+M+GeonKzOq8qdkY/jnWi8lZSJdCe2owbCEEu2cf7yM+gY3hThNra8p?=
 =?us-ascii?Q?hjoZ2JnVZMkxaGBhEgprBjY95pEZaSoBOU61WCYbUcNab5CTpQoZsjahY5I0?=
 =?us-ascii?Q?Wi7C6A89VuaFoGlJ6uj3CzvuUl7wQSDIig188V2N94z+5M5a4+yt8FFeEKGi?=
 =?us-ascii?Q?wr7HMkiYGZ+LJGOL0l0aTBDz4mXUUeBN1gqxIHnMntYFORrGxWJTz3o9lGW/?=
 =?us-ascii?Q?i7+U7x/kZkH6XqktfeuQ66+YjPuzo0OdNLNnx000A7Jeq4yXkE1YH5ogWvWf?=
 =?us-ascii?Q?keo/1yZOiXhn+O69JIlPY6wagp8LSpR0JTkGzLWFJhy/efiWdeK2KciXlWjU?=
 =?us-ascii?Q?mwHumbS4+Er1of+nU3BlBdeuPbOJWj9Hn/0cCbuV8kAJ7ZE6rgD6ycMeK+Ba?=
 =?us-ascii?Q?xciryT6ZLntrfESXKxkoO4L4YMJ97CsQYOKMbIoAk0zq8TEF+C+s0DFOzEzH?=
 =?us-ascii?Q?9l45f22U2p4JvliGX6M4cbs/MYeVn3GUiOv6m1H8DXLoxUpsKr66MDlej/4X?=
 =?us-ascii?Q?h7hNg+fSSiBB5lhPSVeNJuJ8zMguv5AFvrBOpJKWSWF2aNjJ5ldHs/vCbWax?=
 =?us-ascii?Q?eUhqOBkhyzbcxaEsN6eRQ/+F/VatuXkvpxUl0EphpXAmZoN0fqptYtdXZRvt?=
 =?us-ascii?Q?GUGY/0KzlFoiyuakb9etj5XWDM2sahFxnjgnAFqGSG5wcP8e7PDyq68mhhwQ?=
 =?us-ascii?Q?GXxifAWZqjlKSLPgzLzFLk2VOWX3eKsYa2vcPucZd5YnY2HOM8H1bPKz/dId?=
 =?us-ascii?Q?r1jgwnHrcTx0LB3Y1RvM+Y5vlztrP7HJqpzOxcX0Dkg0PhhuikidEOX0MBjg?=
 =?us-ascii?Q?ctNRTPYZaVikgiSZp6BCVu6P7Utl5kXRzbeolw04dGB2K1J94UeQTCCZTBxg?=
 =?us-ascii?Q?EHJS92DdFJmHwF/Xx6VoN491mIIwUjvOUvO0wlz6ifpWyfzWu8i5m8hCxmvn?=
 =?us-ascii?Q?bYDG55kM1nu5Df34rw+Z8EVgbc9Bej77puguJ86nbgAC+W9pV3oIsWY4z+xk?=
 =?us-ascii?Q?Z8KtiAFIO2u8sbMG1MLVEn2Ecen1LCk39Xw6EuvRtz5kjnLI9l8J5lrBews1?=
 =?us-ascii?Q?FnujQC0L0gOArw8BQ0bzd8Y5/OUYcuFyJ80QAffGg+HYPa71c8FmZgWzWt0J?=
 =?us-ascii?Q?BUMiH+m8xMZ+H9QQbWcjkEnfCTjaPslSFKMDBzSN66JZI45UTxi/QubcC3kM?=
 =?us-ascii?Q?dF+SgR1nHSONdwAhEi0SIPFSXbMDL9ARGPUEBTUePt9s732Z9+NUbpHj01rl?=
 =?us-ascii?Q?byTYoAzbyrpiptHVh38j70OGAn6AbBnCAb1SKoh47HChSLYQWXx9+qG+9s7E?=
 =?us-ascii?Q?X8Ak9Pf78QMVEZtckG40ZAdOqRmIPdr2+AYEKsFf?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d34deeb-3f83-4639-99c3-08dbf8404f03
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 22:52:09.7863
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rBy8yaj0rUXcBir3mX+VXlfoiPoB2yQBY/MGhL6Odyt5iRVSrjuIGkDIe3j7KvbE5uFn4vUbYDIVrmrJxXor2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5118
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 08 Dec 2023 14:52:27 -0800 (PST)

Dan Williams wrote:
> Ira Weiny wrote:
> > Robert Richter wrote:
> [..]
> > > -	cdat_table = cdat_buf + sizeof(__le32);
> > > -	if (cdat_checksum(cdat_table, cdat_length))
> > > +	if (cdat_checksum(doe->table, length))
> > >  		goto err;
> > >  
> > > -	port->cdat.table = cdat_table;
> > > -	port->cdat.length = cdat_length;
> > > -	return;
> > > +	port->cdat.table = doe->table;
> > 
> > As an aside: the type of port->cdat may need to change at some point too.
> 
> I did not understand this comment relative to what you expect to see in
> the next posting, but maybe Robert will when he respins this patch.

Robert introduced some new types which better defined what the read algorithm
was doing.  Right now the table is just a void *.  It would be nice to type it
more strongly as it starts to be used in the kernel.

Ira