Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Feedback-ID: ifd194980:Fastmail
References: <20231208015536.21013-1-garyrookard@fastmail.org>
 <493fe783-46b3-4da7-b0d9-01425e6adf2a@gmail.com>
User-agent: mu4e 1.10.6; emacs 29.1
From:   Gary Rookard <garyrookard@fastmail.org>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5)
 different variables
Date:   Fri, 08 Dec 2023 16:56:46 -0500
In-reply-to: <493fe783-46b3-4da7-b0d9-01425e6adf2a@gmail.com>
Message-ID: <87y1e4dy2g.fsf@fastmail.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Philipp Hortmann <philipp.g.hortmann@gmail.com> writes:

> On 12/8/23 02:55, Gary Rookard wrote:
>> Hi,
>> This patch series renames 5 different variables with the checkpatch
>> coding style issue, Avoid CamelCase.
>> Patch 1/5) renamed variable bCurShortGI40MHz
>> Patch 2/5) renamed variable bcurShortGI20MHz
>> Patch 3/5) renamed variable CCKOFDMRate
>> Patch 4/5) renamed variable HTIOTActIsCCDFsync
>> Patch 5/5) renamed variable IOTPeer
>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>> Gary Rookard (5):
>>    staging: rtl8192e: renamed variable bCurShortGI40MHz
>>    staging: rtl8192e: renamed variable bCurShortGI20MHz
>>    staging: rtl8192e: renamed variable CCKOFDMRate
>>    staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>>    staging: rtl8192e: renamed variable IOTPeer
>>   .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  4 +-
>>   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    | 22 +++----
>>   drivers/staging/rtl8192e/rtl819x_HT.h         |  6 +-
>>   drivers/staging/rtl8192e/rtl819x_HTProc.c     | 58 +++++++++----------
>>   drivers/staging/rtl8192e/rtllib_tx.c          |  4 +-
>>   5 files changed, 47 insertions(+), 47 deletions(-)
>>=20
>
>
> Please use present-tense as outlined here:
> https://kernelnewbies.org/PatchPhilosophy
> So rename instead of renamed
>
> Please use a more unique Subject for your coverletter.
> It often cannot cover everything. But more unique is better.
>
>
>
> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>

Okay, "rename" it be, instead of me thinking in the past simple tense,
of "renamed".=20

As for the coverletter(s)...repetition a big problem.

There's not much in the way of uniqueness that can be added...regretfully=20
Tagging the Subject line with a numeric value is possible and
should deviate the coverletter(s) enough so they don't "appear the same".
e.g. staging: rtl8192e: this patch series (1) blah blah blah...
e.g. staging: rtl8192e: this patch series (2) blah blah blah...
e.g. staging: rtl8192e: this patch series (3)  "    "    "

Regards,
Gary

=2D-=20
Sent with my mu4e on Gentoo GNU/linux.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJNBAEBCAA3FiEEjsrWb+cZk1AuzV9C2li+Bks2LgAFAmVzs3IZHGdhcnlyb29r
YXJkQGZhc3RtYWlsLm9yZwAKCRDaWL4GSzYuAEdTEACKrPt8/XKR7oOYNGjcUpJm
Mqy+vQB7rSjg6KkHrcxHzM2Pe9RICZOEe2aU0BFhTcpeRvl6PEV1UzW4sd+vz3lL
R1hG2IGStotwSJz/HTI7vs2UR3feMKo3Zwz8Oj9RnhXxCn1TzdMUnGr2drLXnZyo
VUvuD3lUNFm4EDcA6T1ZjALbzO7OrhFyUMWRanND+18DqflQBn2X1AeGvIk9ZVlc
RPk4yl1Or5akTiCcjJXncMiKwtH8BzfxgVy6dHYkZV98NZ+XImZjinaI4gsu2BVP
kXTmeJAQMJi1ez+ecJhV0kNUHw/1Fi8vZEU6EKQuFtoWm7uLZIacCtzRW9HkNdrZ
ZSi0tuiz6+9/jmJUlR0cSVZGl1Ns14QbOJBsTk8nvvHSOp8z/Z3USAH2b/dxh+ft
dScyEaja271DVe+6u1QQHJFKrrGcao62KljnfQMojOwcWYgsXoQ/+0WhdNtDgWsS
Z5a2VrAgh+QWe83An9Vqba2OYGETtfozpbs2Lf96v0imt6gVzwiHHjM2bWlTNcGR
InTDKR8mckF1EXAEolodcBny5zd83OMOU3GVzw2ZQWtIuhpxaGrd6tkdC1zSzJCq
uY/siBkFVD/Sd7gElESOORmQW2+yr/Ovm9SaTFJa/F728I3EUdgcr/oNRsyiFgDT
1ybK4Cc1aklX/Oz6ZvwLVQ==
=fjT6
-----END PGP SIGNATURE-----
--=-=-=--