Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Feedback-ID: ifd194980:Fastmail
References: <20231208015536.21013-1-garyrookard@fastmail.org>
 <493fe783-46b3-4da7-b0d9-01425e6adf2a@gmail.com>
User-agent: mu4e 1.10.6; emacs 29.1
From:   Gary Rookard <garyrookard@fastmail.org>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5)
 different variables
Date:   Fri, 08 Dec 2023 19:41:35 -0500
In-reply-to: <493fe783-46b3-4da7-b0d9-01425e6adf2a@gmail.com>
Message-ID: <87ttosfb3h.fsf@fastmail.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Philipp Hortmann <philipp.g.hortmann@gmail.com> writes:

> On 12/8/23 02:55, Gary Rookard wrote:
>> Hi,
>> This patch series renames 5 different variables with the checkpatch
>> coding style issue, Avoid CamelCase.
>> Patch 1/5) renamed variable bCurShortGI40MHz
>> Patch 2/5) renamed variable bcurShortGI20MHz
>> Patch 3/5) renamed variable CCKOFDMRate
>> Patch 4/5) renamed variable HTIOTActIsCCDFsync
>> Patch 5/5) renamed variable IOTPeer
>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>> Gary Rookard (5):
>>    staging: rtl8192e: renamed variable bCurShortGI40MHz
>>    staging: rtl8192e: renamed variable bCurShortGI20MHz
>>    staging: rtl8192e: renamed variable CCKOFDMRate
>>    staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>>    staging: rtl8192e: renamed variable IOTPeer
>>   .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  4 +-
>>   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    | 22 +++----
>>   drivers/staging/rtl8192e/rtl819x_HT.h         |  6 +-
>>   drivers/staging/rtl8192e/rtl819x_HTProc.c     | 58 +++++++++----------
>>   drivers/staging/rtl8192e/rtllib_tx.c          |  4 +-
>>   5 files changed, 47 insertions(+), 47 deletions(-)
>>=20
>
>
> Please use present-tense as outlined here:
> https://kernelnewbies.org/PatchPhilosophy
> So rename instead of renamed
>
> Please use a more unique Subject for your coverletter.
> It often cannot cover everything. But more unique is better.
>
>
>
> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>

Okay, will use "rename" instead past simple tense "renamed"

The coverletter(s) are having a repetition problem, I can add an
numeric value to their Subject lines to "unique" them as there is not much
else available to do so with.

Regards,
Gary
=2D-=20
Sent with my mu4e on Gentoo GNU/linux.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJNBAEBCAA3FiEEjsrWb+cZk1AuzV9C2li+Bks2LgAFAmVzuxIZHGdhcnlyb29r
YXJkQGZhc3RtYWlsLm9yZwAKCRDaWL4GSzYuALTTEACvsx5Dl5kmKFF7t/GkhACc
FLOP8uIDRRYwGK4d6twWCqaWPeERd3+O1y+OemThbS/mKZ9UP61hQ8VLPdW/zKX9
wnF2A1Ic/DchYcWzEpeDiMQkjy8PlC0Nnx8fZcpLAUYdJNiQYoZ9gEqiwfFQXysa
aDUDcaVdY3NiRJBLfl0CxzSv8pg8EKK16rlG+ii15IMsTamHG1//S5mn7FRHmk6B
x0e0yvGRbXZFGp52/NYwXc0iOF/2us6NZc2V3CuqSgf9MaVW+/QKsIFcZTTzrvLW
gELdxjjo0VJljo+pmMglqeJbXM86s9YdzyWRWhwSrOmUh7m1lwGfQgV6tPnK8LLX
DOXXxJvrlNQO2ZL2+Zh4TWF4TL/6wHkDD3gzxDXPYvpu2GqEYGCkeEevjQ6xy/60
0ITcJVfVytCU58XeJtUQN3RBLZYqfAplNbYkpvvigY5DdNktDn/EeoXTN+1aU4at
rRTVVnx9wIGvjqOY4KPP4dIb2U+fgf52K10OeK1QJYluFCpRHZnsYOxtauggqQSR
4D3nWnRaEX29Jz1kdWVOEff5jl1ygmlaWkSMG9bQK+j0ne/8yPlmR28E+pGS5vHL
dvmJElQJgY8glo/lje8D7qa5y02L9Nm4LFsWowT1KXPyHWYS5iz+M9ZDH9PRjdVw
mcOnmHsmB+7DopD4gVOvPQ==
=WrgT
-----END PGP SIGNATURE-----
--=-=-=--