Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756302AbXLDVSp (ORCPT ); Tue, 4 Dec 2007 16:18:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751644AbXLDVSg (ORCPT ); Tue, 4 Dec 2007 16:18:36 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:57743 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbXLDVSf (ORCPT ); Tue, 4 Dec 2007 16:18:35 -0500 Date: Tue, 4 Dec 2007 13:17:46 -0800 From: Andrew Morton To: Paulo Marques Cc: linux-kernel@vger.kernel.org, compudj@krystal.dyndns.org, rusty@rustcorp.com.au Subject: Re: [-mm PATCH] kallsyms should prefer non weak symbols Message-Id: <20071204131746.ede01c65.akpm@linux-foundation.org> In-Reply-To: <4755BA14.8060706@grupopie.com> References: <4755BA14.8060706@grupopie.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 23 On Tue, 04 Dec 2007 20:35:32 +0000 Paulo Marques wrote: > When resolving symbol names from addresses with aliased symbol names, > kallsyms_lookup always returns the first symbol, even if it is a weak > symbol. > > This patch changes this by sorting the symbols with the weak symbols > last before feeding them to the kernel. This way the kernel runtime > isn't changed at all, only the kallsyms build system is changed. > > Another side effect is that the symbols get sorted by address, too. So, > even if future binutils version have some bug in "nm" that makes it fail > to correctly sort symbols by address, the kernel won't be affected by this. > > I don't understand the reason for making this change. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/