Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Sat, 09 Dec 2023 09:10:55 +0100
Message-ID: <87ttor6bjk.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Gergo Koteles <soyer@irl.hu>
Cc:     Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
        Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/tas2781: leave hda_component in usable state
In-Reply-To: <c3e903fedec7d84929664377307019e58dc22494.1702058704.git.soyer@irl.hu>
References: <c3e903fedec7d84929664377307019e58dc22494.1702058704.git.soyer@irl.hu>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 08 Dec 2023 19:06:49 +0100,
Gergo Koteles wrote:
> 
> @@ -612,9 +612,13 @@ static void tas2781_hda_unbind(struct device *dev,
>  {
>  	struct tasdevice_priv *tas_priv = dev_get_drvdata(dev);
>  	struct hda_component *comps = master_data;
> +	comps = &comps[tas_priv->index];
>  
> -	if (comps[tas_priv->index].dev == dev)
> -		memset(&comps[tas_priv->index], 0, sizeof(*comps));
> +	if (comps->dev == dev) {
> +		comps->dev = NULL;
> +		strscpy(comps->name, "", sizeof(comps->name));

This looks suboptimal.  Either just set *comp->name = 0, or fill all
with memset().


thanks,

Takashi