Date: Tue, 4 Dec 2007 22:32:47 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86: Unify include/asm-x86/linkage_[32|64].h
Message-ID: <20071204213247.GA11216@elte.hu>
References: <1196801629.10408.26.camel@brick>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1196801629.10408.26.camel@brick>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 813
Lines: 21


* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> I'm not sure if the definition of asmlinkage and prevent_tail_call can 
> be omitted as well and let the linux/linkage.h version get picked up 
> instead.

no, we cannot remove them - asmlinkage is needed for the syscall entry 
(and other entry code) to work, the and the prevent_tail_call works 
around a compiler bug. (which might or might not be fixed in latest gcc 
- but we generally dont remove workarounds unless we are really sure 
it's fine.)

so your patch looks good to me, i've queued it up.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/