Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   "Song, Xiongwei" <Xiongwei.Song@windriver.com>
To:     "sxwjean@me.com" <sxwjean@me.com>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>,
        "cl@linux.com" <cl@linux.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
CC:     "penberg@kernel.org" <penberg@kernel.org>,
        "rientjes@google.com" <rientjes@google.com>,
        "iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
        "roman.gushchin@linux.dev" <roman.gushchin@linux.dev>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 4/4] mm/slub: correct the default value of
 slub_min_objects in doc
Thread-Topic: [PATCH v3 4/4] mm/slub: correct the default value of
 slub_min_objects in doc
Thread-Index: AQHaKqcV8dGsEfjopEGn6BLZnPOw/7Cg+bOw
Date:   Sat, 9 Dec 2023 13:59:47 +0000
Message-ID: <PH0PR11MB51928F0D78863B3E76457622EC89A@PH0PR11MB5192.namprd11.prod.outlook.com>
References: <20231209135203.303508-1-sxwjean@me.com>
 <20231209135203.303508-5-sxwjean@me.com>
In-Reply-To: <20231209135203.303508-5-sxwjean@me.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OxzN7wVr6IA8ilb9a+10Ta0DgrAJ8eBY74ALoEO4Mt836R27VEkzwtQYRb3v?=
 =?us-ascii?Q?2Yc93QRZ3zjVuzrOQYg4zmy3epdpuvR01AdbE/sIFqoPk8b5hch6eKKHtUPt?=
 =?us-ascii?Q?7iWQo/Jcj8v+92hvJ6FcpWTSzA7h3cjtYhS9iJCRz5Wdd8gvNnWuWbxvKGXV?=
 =?us-ascii?Q?T4MCYR+M8fElWhitR54DFtQY6X8YtWuWPbi3UQk1of0KuvhBuQ/p2/TLKf55?=
 =?us-ascii?Q?6lJnDdysQMeAW6+9IkEyPBFolO5R/oYxgIjagjQ55rf93k/rVapNJ1uwKgOD?=
 =?us-ascii?Q?kYXXR/WM9774gtsRYY4/6Cs1udb1wOLsjMUn8MoxsnM2oYnRj8LLfNse+JjZ?=
 =?us-ascii?Q?VhARWb0FzTiMMDsdvQPWUUSX42Lddi8wvEgKPWg65PMS5O2McgLkIP5zS7a/?=
 =?us-ascii?Q?spIqnd4rpmq+o5K++wLgTyAtEjS0eJVwCxLorXPP8GCsi1+wqu/FnM/Q+Mag?=
 =?us-ascii?Q?gZTR8tbeNPqAuzNnPPtJur2HfG21qO1FHUlJwshDu85Y9rmLEFWGnILRxDBp?=
 =?us-ascii?Q?4E/eWz8VOyXbfpB4WscNcZZAkGOme5Wx3ArSDO69ePMzNxpMXmTCpq277sl5?=
 =?us-ascii?Q?zSNp4co9y8MGggz8CtjvzIjx3D/kg7PkV863cRi1ngayIaaCByqgnq5DIr9F?=
 =?us-ascii?Q?JnAZkFZfjlmnEer5awh2TEZ16PzFhDmff14hLKRpxQGV76qiXQvjELZ05OeZ?=
 =?us-ascii?Q?KBSU366kxRyf35hjG9QAEtY96yj1oGoP0gEE487iydCCHHR9J28EBt4mNEXW?=
 =?us-ascii?Q?5P4rsyz6nUzQaCau1Kh/W6iQo869zDRaY/4J6BBrOrpxd+s1MFmgIRZt176O?=
 =?us-ascii?Q?Fr7JDFLgDLi0JTbLg1xsvH70v33iWCkll9ORaG4b2prf8LeYiysur8ccTli6?=
 =?us-ascii?Q?gkcpyMS+32QuY3wPnNhRGeuYVrDC+byh0Rm76dVU79vKb/NETLz8J3x3ffoc?=
 =?us-ascii?Q?vCSry+EG346HSHZs8PAS4X89zcF/hLaGqOqR0hY0PsNlUAr8PppJGqC9RWkp?=
 =?us-ascii?Q?pLb1tVc6PgcBxF801VwYofbZhurCnOEVQw6gCT7olhO6bLxTE+Jun555PMGW?=
 =?us-ascii?Q?8nWKsgbA0LgD4S1OU3isNgCqwhQWFL8YLwCuetXxej1d17As/wfJuIdmaAVQ?=
 =?us-ascii?Q?CeHDaOM+f8ML2uOmjpe5otLrVpZq7qjGiijysaupLDhtinNO5fMnWuUfU6bE?=
 =?us-ascii?Q?2xPYFGX0xIBxrPPXBebWFQBXzfFaopmAZM+E0LEnSIwXgMt6Rhf4831jRGBE?=
 =?us-ascii?Q?Mtx8Oyqw4sBInM5+eyasX65/anygy+Cz3NOlxS/5FHb7PawypJdcH9VcVbYA?=
 =?us-ascii?Q?sDMEySJXCKS8tcE1d7ix6dgr5SwftIqprrBL1+gGKrQanw25EzHXUXxgqgI2?=
 =?us-ascii?Q?3JJQ63RhhPnCLnFY00e8uwRQxMuTZxQOFCzmTcq5wlJU5EOSCeNENCqjYsh7?=
 =?us-ascii?Q?E9bIo3p/z7x4eCQ8J82oY6kZdmp4POKCcZTGTD832bwuNg1IP/ctWcgtxxhl?=
 =?us-ascii?Q?pyw2ZpaS0P0ghquGsp0/ezPpe3gtoXl1dRadqrxIAMCUkxs8APrt4EzNkqR2?=
 =?us-ascii?Q?vZViWb2NfjbhBDM3GW5uWR8QLI4LmKo07kxamSFSxXYC8fQOzBrdmd7SmyeY?=
 =?us-ascii?Q?+2Llwm6w37c7WEQ0gVeMt1EnnU/33VVBTAdBC3ejm1/xXiUxYFlh6I4cGfXU?=
 =?us-ascii?Q?4CpyJQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5192.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c25e55c-a86b-4719-448f-08dbf8bf1b0c
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2023 13:59:47.9012
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DvTgFdBXz5JDkK98TxcIr9M6vHuH0uFu5/ah4rDJAAbz8z284S4I8MjFGYv2xcx6RJlIlZsBz6A8gzb9Gujbi8sEQF+9oLINuI87c0T3KpU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8086
X-Proofpoint-GUID: Fe09WIa3KjWJO4sXJt91qkoPu9zoUAi2
X-Proofpoint-ORIG-GUID: Fe09WIa3KjWJO4sXJt91qkoPu9zoUAi2
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-16_25,2023-11-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0
 mlxlogscore=999 priorityscore=1501 spamscore=0 suspectscore=0
 lowpriorityscore=0 bulkscore=0 phishscore=0 mlxscore=0 adultscore=0
 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.19.0-2311290000 definitions=main-2312090121
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 09 Dec 2023 06:00:56 -0800 (PST)

Hi Vlastimil,

I didn't change description as you mentioned because slab_min_objects doesn=
't
save the calculated value based on the number of processors, but the local
variables min_objects doesn't.

Regards,
Xiongwei=20

> -----Original Message-----
> From: owner-linux-mm@kvack.org <owner-linux-mm@kvack.org> On Behalf Of
> sxwjean@me.com
> Sent: Saturday, December 9, 2023 9:52 PM
> To: vbabka@suse.cz; 42.hyeyoo@gmail.com; cl@linux.com; linux-mm@kvack.org
> Cc: penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@lge.com;
> roman.gushchin@linux.dev; corbet@lwn.net; keescook@chromium.org; arnd@arn=
db.de;
> akpm@linux-foundation.org; gregkh@linuxfoundation.org; linux-doc@vger.ker=
nel.org; linux-
> kernel@vger.kernel.org; Song, Xiongwei <Xiongwei.Song@windriver.com>
> Subject: [PATCH v3 4/4] mm/slub: correct the default value of slub_min_ob=
jects in doc
>=20
> From: Xiongwei Song <xiongwei.song@windriver.com>
>=20
> There is no a value assigned to slub_min_objects by default, it always
> is 0 that is initialized by compiler if no assigned value by command line=
.
> min_objects is calculated based on processor numbers in calculate_order()=
.
> For more details, see commit 9b2cd506e5f2 ("slub: Calculate min_objects
> based on number of processors.")
>=20
> Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com>
> ---
>  Documentation/mm/slub.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/Documentation/mm/slub.rst b/Documentation/mm/slub.rst
> index 6579a55b7852..56b27f493ba7 100644
> --- a/Documentation/mm/slub.rst
> +++ b/Documentation/mm/slub.rst
> @@ -150,7 +150,7 @@ list_lock once in a while to deal with partial slabs.=
 That overhead is
>  governed by the order of the allocation for each slab. The allocations
>  can be influenced by kernel parameters:
>=20
> -.. slab_min_objects=3Dx          (default 4)
> +.. slab_min_objects=3Dx          (default 0)
>  .. slab_min_order=3Dx            (default 0)
>  .. slab_max_order=3Dx            (default 3 (PAGE_ALLOC_COSTLY_ORDER))
>=20
> --
> 2.34.1
>=20