Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   "Chilakala, Mallikarjuna" <mallikarjuna.chilakala@intel.com>
To:     "Gomes, Vinicius" <vinicius.gomes@intel.com>,
        Rodrigo Cataldo via B4 Relay 
        <devnull+rodrigo.cadore.l-acoustics.com@kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Aravindhan Gunasekaran <aravindhan.gunasekaran@intel.com>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Kurt Kanzenbach" <kurt@linutronix.de>,
        Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
Subject: RE: [PATCH iwl-net] igc: Fix hicredit calculation
Thread-Topic: [PATCH iwl-net] igc: Fix hicredit calculation
Thread-Index: AQHaKecKtZcyqHkzjE6/SXpDp61lzrCgIKqAgAETW6A=
Date:   Sat, 9 Dec 2023 17:22:10 +0000
Message-ID: <DM4PR11MB60941A401AF5BF6B70473A768489A@DM4PR11MB6094.namprd11.prod.outlook.com>
References: <20231208-igc-fix-hicredit-calc-v1-1-7e505fbe249d@l-acoustics.com>
 <871qbwry9y.fsf@intel.com>
In-Reply-To: <871qbwry9y.fsf@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A1YfQAX6+XsM6Ff1RnPTYiS1/xjYQLgDTf3tWweCGU3dPV+x9YSIwx7XHlch?=
 =?us-ascii?Q?xfvRAEsVfvc4DPHfFitbKT88akE/AW3jeHgkS6RVCXV8ELA8EWirSs9W/u9l?=
 =?us-ascii?Q?a6YH4Kd3zHaljTm3nMnrgTyqutNw9ubESI9DMn77dxO0Ia7HCg5bL8/mV7ty?=
 =?us-ascii?Q?Nh1R1CSvjR8bMqnvEBkuB4q0LimW8LxHmROfGDVvsOGrrGd3wCAos1YH4AaF?=
 =?us-ascii?Q?EfFPwwuRGRPUUwxCGnFDOsq38aBZCugacFfLBLud8SvAVQXhxD4ql8hzmS9s?=
 =?us-ascii?Q?AUCXeBckp34WyXgsXycKfyS2ZrpPjmePuPMSunpaIx/SzUvMl1iEEFInaa2O?=
 =?us-ascii?Q?yJbjikKQcAT/oKW/D80uGL8HQFWBZHmMkX3TwI5jhTqkouKPxI1Odc9M+Mby?=
 =?us-ascii?Q?iOmaMeuVJyb0ce3WAPhqYwezGDAWyidNWfxcxeSt7tX3R6vr44h1QXFTIdyV?=
 =?us-ascii?Q?2+1TNSVHGq9SpWYRxME1ji3ksG0Ve2D3Vv2zzMXGdMiJyoW7t6PZ9PsU6X+b?=
 =?us-ascii?Q?ZAxlMll5PLUMOBolBdsCGoTdb0buwmKn321nzQE58q2jiAhNKZMUfY39WGbn?=
 =?us-ascii?Q?M4LJIRmBPfCRe6KdBVMfvW7ok3TwT9bQ7bY+ZXRjtphJm6JvSeDUHJpL6j9H?=
 =?us-ascii?Q?IIsU3yroRQj6j4tehOCl6bxJD35R0mBQ3BJxpgwUgKpmmJh6UMU1Sh7p9X0x?=
 =?us-ascii?Q?4naKgDr7Yt7WZcGzSoSvAKm8XumbSRPN3JGXEQrruQ/ADTRathk6dUPO3QPo?=
 =?us-ascii?Q?HpfTbBfX5NgLgbBkJpHlLdjGP1UAqmtp1pDseQhrHPa+UmhqjoxWexEAWoko?=
 =?us-ascii?Q?dofDTvsH1U2TmOnn5RbnbG4YDiC+cBRb4vF9wxh6pp1ovXNJ1naUqczGOt4Y?=
 =?us-ascii?Q?r4OFjKkIK5b50Y/lYJFktkfWWAAvv3R7Tbq8pqShUyMpeIaXQsq3vpGBGtjH?=
 =?us-ascii?Q?4QL6neTY0YAGHNiSGEiR8PQ0j2eqHD/fFqVppzr5FbHJ8v0wyHBd6MVCFvkR?=
 =?us-ascii?Q?tqrvu1n9DdJ4k9Dv6pwW6bJHaNOiVe/824BZ8g2DSknf3DZKyPw61HbrvKdq?=
 =?us-ascii?Q?9chvxuetmblp41doAuAw65P4Ucd3EAzPhvVZ2dPsK87wVvN1+2G8mjB35sdP?=
 =?us-ascii?Q?t7ecr7afx2zsTq+q9PGPUJt3iM7H5YFefTFxCFAMz60+/FE+0BXGoIWNFAc7?=
 =?us-ascii?Q?p+aZJZJPepeWycf3bXPUkcBTFkqBQ/fLBoMLGZlynypxQnZAd5xXkJYMgCC7?=
 =?us-ascii?Q?Ptg9xEiqYDSO+QYylxM9fd1gL2lpYPV9cYMXZ6MONgMfjLm3IoHp56lERjbK?=
 =?us-ascii?Q?SDXDM6evPNG8q7W8CkVofTktwu0ite3OVPcLCrf/mqvlSw1F0wwQE3G/25Ac?=
 =?us-ascii?Q?8ufzBgMoR1yP8Qm1Sbx9tEQyxdICmDSxFFmgusUKBmw2WEmDJSVCUnYBQCFH?=
 =?us-ascii?Q?jkcfi4N3LTda1mTE2DtcVRvfiRcIgroqkN4z7nJoWj7Ity+0UJxFlTBL+Pkf?=
 =?us-ascii?Q?aPwe2Ozpnbz4OpQKc7E/ag+IKAdJYA8V2ES04v7z6ZDuFXW9c9B9sMIm4Fpi?=
 =?us-ascii?Q?AOj7BwThKPDf734gNbWvPYHOHwr6japZklzzMYBzYSAGABcZP83UXt0tgC8L?=
 =?us-ascii?Q?0Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6094.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60cee8eb-8e06-442f-02c2-08dbf8db606d
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2023 17:22:10.2246
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iSMWOtajn7E3rvdyhdhtSOn0jlOitE7VWIRnPuXolwdLxgj9CFPVkNHbxkPvOcR2CdChIrobF9CWmRyvCkNmNEJVHFeM6q9LBbj0REUkhU8ICgIfFnW5nq4sclicn7NJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5333
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 09 Dec 2023 09:22:30 -0800 (PST)

Rodrigo Cataldo via B4 Relay
<devnull+rodrigo.cadore.l-acoustics.com@kernel.org> writes:

> From: Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
>
> According to the Intel Software Manual for I225, Section 7.5.2.7,=20
> hicredit should be multiplied by the constant link-rate value, 0x7736.
>
> Currently, the old constant link-rate value, 0x7735, from the boards=20
> supported on igb are being used, most likely due to a copy'n'paste, as=20
> the rest of the logic is the same for both drivers.
>
> Update hicredit accordingly.
>
> Fixes: 1ab011b0bf07 ("igc: Add support for CBS offloading")
> Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
> Signed-off-by: Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
> ---

Looks good to me!
Acked-by: Malli Chilakala <mallikarjuna.chilakala@intel.com>

> This is a simple fix for the credit calculation on igc devices
> (i225/i226) to match the Intel software manual.
>
> This is my first contribution to the Linux Kernel. Apologies for any=20
> mistakes and let me know if I improve anything.
> ---
>  drivers/net/ethernet/intel/igc/igc_tsn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c=20
> b/drivers/net/ethernet/intel/igc/igc_tsn.c
> index a9c08321aca9..22cefb1eeedf 100644
> --- a/drivers/net/ethernet/intel/igc/igc_tsn.c
> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c
> @@ -227,7 +227,7 @@ static int igc_tsn_enable_offload(struct igc_adapter =
*adapter)
>  			wr32(IGC_TQAVCC(i), tqavcc);
> =20
>  			wr32(IGC_TQAVHC(i),
> -			     0x80000000 + ring->hicredit * 0x7735);
> +			     0x80000000 + ring->hicredit * 0x7736);
>  		} else {
>  			/* Disable any CBS for the queue */
>  			txqctl &=3D ~(IGC_TXQCTL_QAV_SEL_MASK);
>
> ---
> base-commit: 2078a341f5f609d55667c2dc6337f90d8f322b8f
> change-id: 20231206-igc-fix-hicredit-calc-028bf73c50a8
>
> Best regards,
> --
> Rodrigo Cataldo <rodrigo.cadore@l-acoustics.com>
>