Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp3165155rdb; Sat, 9 Dec 2023 14:34:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwCPoGEspWE1BMd8XzgPH6kGnjnVpNHTCK0x3/Fb1dvB1qRzqS3R0K1GNXuVECg05phnqc X-Received: by 2002:a05:6a21:998e:b0:18c:ece:a2f6 with SMTP id ve14-20020a056a21998e00b0018c0ecea2f6mr3214631pzb.19.1702161270376; Sat, 09 Dec 2023 14:34:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702161270; cv=none; d=google.com; s=arc-20160816; b=g+OlzbZhrT1XFPwzNjFXDfMvt+60mywBYcR0xYffWhZcp0LTHQzUUo41/O0XfINOhY 8jpABNZpWAELT7O8oWFXryhVmoHyTs5ptFGqS4Zd/06Cpv9CaqvkQ7mwN6vtH+NKbgP7 HXRZHZGf3FyvJ5/UAdfGDMEE+mVOyBoJfj3orpwbIQPGK/TGv8QjfqZhX8kfO8Skca/q u8+tUBR0cHLhZeH3XvyE0bxVCEDzoj4vrsenMuRZKPXfRl4XIPkG3hQz2kf6sjUzCOnK XqsBjFaV1ZK/fhkNnBZufmnJlXdpgc6Gg4CmbK6lbNYM0Fhp7TDWdG4GhKofUf9ReAWa VSrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=J6LN+KgSMdUJzWFbD8B9tTe+LuCcX4re6QidDv+5G0I=; fh=iNN4nupC7Tb1xs6dhzczjg0SngN695aVEP1qK5PIiuI=; b=zKUzwyFuXTLFlf01djX89s+7T4ioDBxg6nDt4Llrgtvm9rxEYcQJGc/xsYGvPX5bT7 KEba2tJ9SyTF8H3Zoc1TC5Tiz3xSp3zyotaHkoVGUwv/MPx7B1kRFXxz1E4y8ZvE/Ykb xfLhk4zj8HneCYO+mY7u/tGKVyShaVXNY1RaPhQOJLR8RISKFng9wrwQlFH/L4eJnyII C1TQ97+38sfhIWjU9mj98aEL+LU856SWNO/VgsnC8jZ1wkjjyfhxnkMDJwtioAjvmQbJ a1V2wZ7FXQ152gTkBbyD6e6TtonUOoz5/Xqpm76OJ7FZRYv6YnizObHyvq3LJxy8+r9J MLOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=C+3ya32i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id y24-20020a634958000000b005c6faf0a66csi2422296pgk.247.2023.12.09.14.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 14:34:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=C+3ya32i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id E2C1B8080EE8; Sat, 9 Dec 2023 14:34:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229518AbjLIWeO (ORCPT + 99 others); Sat, 9 Dec 2023 17:34:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjLIWeN (ORCPT ); Sat, 9 Dec 2023 17:34:13 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08B66100 for ; Sat, 9 Dec 2023 14:34:20 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44937C433C7; Sat, 9 Dec 2023 22:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702161259; bh=XsuMwPIsmzIChD8ndzu9XynHImam+pakPevqcPXRNtg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C+3ya32iasF+Y/ixGjJWRb6MVRkCX7SUQSlOC7QcPVmApdwOw8RsA8eKFvh3qbP7S qurGC4BZ7+i6bSPwU0DlnsrWqZIH5edTjZK1gJcsz1xuzDcGKFKhsQBdtd2EjljejQ EBBBXu+OIRpADiQ9c+pKSlLavInXYnnt2LwNDXDc= Date: Sat, 9 Dec 2023 14:34:18 -0800 From: Andrew Morton To: Yuntao Wang Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Baoquan He , Vivek Goyal , Dave Young , Zhen Lei Subject: Re: [PATCH] crash_core: Fix the check for whether crashkernel is from high memory Message-Id: <20231209143418.92f02de6b6c6db2b7b3b1815@linux-foundation.org> In-Reply-To: <20231209141438.77233-1-ytcoode@gmail.com> References: <20231209141438.77233-1-ytcoode@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 09 Dec 2023 14:34:28 -0800 (PST) On Sat, 9 Dec 2023 22:14:38 +0800 Yuntao Wang wrote: > If crash_base is equal to CRASH_ADDR_LOW_MAX, it also indicates that > the crashkernel memory is allocated from high memory. However, the > current check only considers the case where crash_base is greater than > CRASH_ADDR_LOW_MAX. Fix it. > > This patch also includes some minor cleanups. Can we please include a description of the runtime effects of this change? ie, what happens now and under what circumstances, and how does the fix alter these things?